Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-10798

globStatus() should always return a sorted list of files

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.3.0
    • 2.8.0, 3.0.0-alpha1
    • None

    Description

      (FileSystem) globStatus() does not return a sorted file list anymore.

      But the API says: " ... Results are sorted by their names."

      Seems to be lost, when the Globber Object was introduced. Can't find a sort in actual code.

      code to check this behavior:

              Configuration conf = new Configuration();
              FileSystem fs = FileSystem.get(conf);
              Path path = new Path("/tmp/" + System.currentTimeMillis());
              fs.mkdirs(path);
              fs.deleteOnExit(path);
              fs.createNewFile(new Path(path, "2"));
              fs.createNewFile(new Path(path, "3"));
              fs.createNewFile(new Path(path, "1"));
      
              FileStatus[] status = fs.globStatus(new Path(path, "*"));
              Collection list = new ArrayList();
              for (FileStatus f: status) {
                  list.add(f.getPath().toString());
                  //System.out.println(f.getPath().toString());
              }
              boolean sorted = Ordering.natural().isOrdered(list);
              Assert.assertTrue(sorted);
      

      Attachments

        1. HADOOP-10798.001.patch
          3 kB
          Colin McCabe

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            cmccabe Colin McCabe
            fborchers Felix Borchers
            Votes:
            1 Vote for this issue
            Watchers:
            12 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment