Hadoop Common
  1. Hadoop Common
  2. HADOOP-10657

Have RetryInvocationHandler log failover attempt at INFO level

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      RetryInovcationHandler uses worthLogging flag to decide if it will do logging. worthLogging will be false for first fails over given invocationFailoverCount is zero. That addresses the log noise where the second-listed NN is active.

      For other failover scenarios, it will be useful to log the error message at info level for analysis purpose.

      1. HADOOP-10657-2.patch
        1.0 kB
        Ming Ma
      2. HADOOP-10657.patch
        0.9 kB
        Ming Ma

        Activity

        Ming Ma created issue -
        Ming Ma made changes -
        Field Original Value New Value
        Project Hadoop HDFS [ 12310942 ] Hadoop Common [ 12310240 ]
        Key HDFS-6477 HADOOP-10657
        Ming Ma made changes -
        Assignee Ming Ma [ mingma ]
        Hide
        Ming Ma added a comment -

        Here is the patch.

        Show
        Ming Ma added a comment - Here is the patch.
        Ming Ma made changes -
        Attachment HADOOP-10657.patch [ 12648719 ]
        Ming Ma made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12648719/HADOOP-10657.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4022//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4022//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12648719/HADOOP-10657.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4022//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4022//console This message is automatically generated.
        Hide
        Jing Zhao added a comment -

        For LOG.info seems like we usually do not need to call "isInfoEnabled". Other than that +1.

        Show
        Jing Zhao added a comment - For LOG.info seems like we usually do not need to call "isInfoEnabled". Other than that +1.
        Hide
        Ming Ma added a comment -

        Thanks, Jing. Yeah, it isn't necessary in this case. New patch uploaded.

        Show
        Ming Ma added a comment - Thanks, Jing. Yeah, it isn't necessary in this case. New patch uploaded.
        Ming Ma made changes -
        Attachment HADOOP-10657-2.patch [ 12649513 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12649513/HADOOP-10657-2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4038//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4038//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12649513/HADOOP-10657-2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4038//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4038//console This message is automatically generated.
        Hide
        Jing Zhao added a comment -

        Thanks for the contribution, Ming Ma! I've committed this to trunk and branch-2.

        Show
        Jing Zhao added a comment - Thanks for the contribution, Ming Ma ! I've committed this to trunk and branch-2.
        Jing Zhao made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.5.0 [ 12326263 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #5709 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5709/)
        HADOOP-10657. Have RetryInvocationHandler log failover attempt at INFO level. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1602941)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #5709 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5709/ ) HADOOP-10657 . Have RetryInvocationHandler log failover attempt at INFO level. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1602941 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #586 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/586/)
        HADOOP-10657. Have RetryInvocationHandler log failover attempt at INFO level. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1602941)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #586 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/586/ ) HADOOP-10657 . Have RetryInvocationHandler log failover attempt at INFO level. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1602941 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1777 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1777/)
        HADOOP-10657. Have RetryInvocationHandler log failover attempt at INFO level. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1602941)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1777 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1777/ ) HADOOP-10657 . Have RetryInvocationHandler log failover attempt at INFO level. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1602941 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1804 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1804/)
        HADOOP-10657. Have RetryInvocationHandler log failover attempt at INFO level. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1602941)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1804 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1804/ ) HADOOP-10657 . Have RetryInvocationHandler log failover attempt at INFO level. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1602941 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        Karthik Kambatla (Inactive) made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Ming Ma
            Reporter:
            Ming Ma
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development