Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-10615

FileInputStream in JenkinsHash#main() is never closed

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

          FileInputStream in = new FileInputStream(args[0]);
      

      The above FileInputStream is not closed upon exit of main.

      1. HADOOP-10615-2.patch
        1 kB
        Chen He
      2. HADOOP-10615.patch
        1 kB
        Chen He
      3. HADOOP-10615.003.patch
        1 kB
        Chen He

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #256 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/256/)
        HADOOP-10615. FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #256 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/256/ ) HADOOP-10615 . FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #246 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/246/)
        HADOOP-10615. FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #246 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/246/ ) HADOOP-10615 . FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Hadoop-Mapreduce-trunk #2204 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2204/)
        HADOOP-10615. FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Mapreduce-trunk #2204 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2204/ ) HADOOP-10615 . FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Hadoop-Hdfs-trunk #2185 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2185/)
        HADOOP-10615. FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk #2185 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2185/ ) HADOOP-10615 . FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #988 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/988/)
        HADOOP-10615. FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #988 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/988/ ) HADOOP-10615 . FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #258 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/258/)
        HADOOP-10615. FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #258 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/258/ ) HADOOP-10615 . FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8170 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8170/)
        HADOOP-10615. FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8170 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8170/ ) HADOOP-10615 . FileInputStream in JenkinsHash#main() is never closed. Contributed by Chen He. (ozawa: rev 111e6a3fdf613767782817836c42810bf2bda5e8) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/JenkinsHash.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Committed this to trunk and branch-2. Thanks Chen He for your contribution and thansk Ted Yu for your report.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Chen He for your contribution and thansk Ted Yu for your report.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        +1

        Show
        ozawa Tsuyoshi Ozawa added a comment - +1
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 24s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 38s There were no new javac warning messages.
        +1 javadoc 9m 34s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 4s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 21s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 9s Tests passed in hadoop-common.
            60m 57s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12745497/HADOOP-10615.003.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / edcaae4
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7285/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7285/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7285/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 24s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 4s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 9s Tests passed in hadoop-common.     60m 57s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12745497/HADOOP-10615.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / edcaae4 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7285/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7285/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7285/console This message was automatically generated.
        Hide
        airbots Chen He added a comment -

        patch updated.

        Show
        airbots Chen He added a comment - patch updated.
        Hide
        airbots Chen He added a comment -

        Sure, thank you for the suggestion, Tsuyoshi Ozawa.

        Show
        airbots Chen He added a comment - Sure, thank you for the suggestion, Tsuyoshi Ozawa .
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Hi Chen He, thank you for taking this issue. Could you use try-with-resources statement instead of IOUtils.closeStream?

        Show
        ozawa Tsuyoshi Ozawa added a comment - Hi Chen He , thank you for taking this issue. Could you use try-with-resources statement instead of IOUtils.closeStream?
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 55s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 52s There were no new javac warning messages.
        +1 javadoc 9m 54s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 4s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 16s Tests passed in hadoop-common.
            62m 28s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12662559/HADOOP-10615-2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / d3797f9
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7098/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7098/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7098/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 55s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 52s There were no new javac warning messages. +1 javadoc 9m 54s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 4s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 16s Tests passed in hadoop-common.     62m 28s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12662559/HADOOP-10615-2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d3797f9 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7098/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7098/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7098/console This message was automatically generated.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Moving bugs out of previously closed releases into the next minor release 2.8.0.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Moving bugs out of previously closed releases into the next minor release 2.8.0.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 38s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 28s There were no new javac warning messages.
        +1 javadoc 9m 44s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 9s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 22m 43s Tests passed in hadoop-common.
            59m 56s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12662559/HADOOP-10615-2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 6ae2a0d
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6440/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6440/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6440/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 44s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 9s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 22m 43s Tests passed in hadoop-common.     59m 56s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12662559/HADOOP-10615-2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6ae2a0d hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6440/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6440/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6440/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12662559/HADOOP-10615-2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

        org.apache.hadoop.ha.TestActiveStandbyElector

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4503//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4503//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12662559/HADOOP-10615-2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestActiveStandbyElector +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4503//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4503//console This message is automatically generated.
        Hide
        airbots Chen He added a comment -

        update patch based on latest Hadoop

        Show
        airbots Chen He added a comment - update patch based on latest Hadoop
        Hide
        airbots Chen He added a comment -

        This change does not need include unit test, I think.

        Show
        airbots Chen He added a comment - This change does not need include unit test, I think.
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        lgtm

        Show
        yuzhihong@gmail.com Ted Yu added a comment - lgtm
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12645417/HADOOP-10615.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3954//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3954//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12645417/HADOOP-10615.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3954//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3954//console This message is automatically generated.

          People

          • Assignee:
            airbots Chen He
            Reporter:
            yuzhihong@gmail.com Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development