Hadoop Common
  1. Hadoop Common
  2. HADOOP-10585

Retry polices ignore interrupted exceptions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha, 3.0.0
    • Fix Version/s: 2.5.0
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:

      Description

      Retry polices should not use ThreadUtil.sleepAtLeastIgnoreInterrupts. This prevents FsShell commands from being aborted during retries. It also causes orphaned webhdfs DN DFSClients to keep running after the webhdfs client closes the connection. Jetty goes into a loop constantly sending interrupts to the handler thread. Webhdfs retries cause multiple nodes to have these orphaned clients. The DN cannot shutdown until orphaned clients complete.

        Activity

        Hide
        Kihwal Lee added a comment -

        The patch looks straightforward. +1 pending successful precommit.

        Show
        Kihwal Lee added a comment - The patch looks straightforward. +1 pending successful precommit.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12643984/HADOOP-10585.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3931//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3931//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12643984/HADOOP-10585.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3931//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3931//console This message is automatically generated.
        Hide
        Jonathan Eagles added a comment -

        +1. Committing to trunk and branch-2. Thanks Daryn Sharp and Kihwal Lee

        Show
        Jonathan Eagles added a comment - +1. Committing to trunk and branch-2. Thanks Daryn Sharp and Kihwal Lee
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #561 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/561/)
        HADOOP-10585. Retry polices ignore interrupted exceptions (Daryn Sharp via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594267)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #561 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/561/ ) HADOOP-10585 . Retry polices ignore interrupted exceptions (Daryn Sharp via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594267 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1779 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1779/)
        HADOOP-10585. Retry polices ignore interrupted exceptions (Daryn Sharp via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594267)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1779 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1779/ ) HADOOP-10585 . Retry polices ignore interrupted exceptions (Daryn Sharp via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594267 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #1753 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1753/)
        HADOOP-10585. Retry polices ignore interrupted exceptions (Daryn Sharp via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594267)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1753 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1753/ ) HADOOP-10585 . Retry polices ignore interrupted exceptions (Daryn Sharp via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594267 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #5605 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5605/)
        HADOOP-10585. Retry polices ignore interrupted exceptions (Daryn Sharp via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594267)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5605 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5605/ ) HADOOP-10585 . Retry polices ignore interrupted exceptions (Daryn Sharp via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594267 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java

          People

          • Assignee:
            Daryn Sharp
            Reporter:
            Daryn Sharp
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development