Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-10582

Fix the test case for copying to non-existent dir in TestFsShellCopy

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: fs
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      In TestFsShellCopy#checkPut, there is a following code.

      final Path dstPath = new Path("path");
      final Path childPath = new Path(dstPath, "childPath");
      
      ...
      
      // copy to non-existent subdir
      prepPut(childPath, false, false);
      checkPut(1, srcPath, dstPath, useWindowsPath);
      

      The code expect to test the case when we put a file to non-exsistent directory. But the code delete childPath and then copy to its parent directory (dstPath).

      1. HADOOP-10582.patch
        0.9 kB
        Kousuke Saruta

        Activity

        Hide
        sarutak Kousuke Saruta added a comment -

        I've attached a patch for this issue.

        Show
        sarutak Kousuke Saruta added a comment - I've attached a patch for this issue.
        Hide
        hadoopqa Hadoop QA added a comment -

        The patch artifact directory has been removed!
        This is a fatal error for test-patch.sh. Aborting.
        Jenkins (node H3) information at https://builds.apache.org/job/PreCommit-HADOOP-Build/6429/ may provide some hints.

        Show
        hadoopqa Hadoop QA added a comment - The patch artifact directory has been removed! This is a fatal error for test-patch.sh. Aborting. Jenkins (node H3) information at https://builds.apache.org/job/PreCommit-HADOOP-Build/6429/ may provide some hints.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1 pending Jenkins. Kicked Jenkins build : https://builds.apache.org/job/PreCommit-HADOOP-Build/6725/

        Show
        ajisakaa Akira Ajisaka added a comment - +1 pending Jenkins. Kicked Jenkins build : https://builds.apache.org/job/PreCommit-HADOOP-Build/6725/
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 5m 8s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 26s There were no new javac warning messages.
        +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 6s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
        +1 findbugs 1m 41s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 23m 13s Tests passed in hadoop-common.
            41m 1s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12643658/HADOOP-10582.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / cab0dad
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6725/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6725/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6725/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 8s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 26s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 6s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 1m 41s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 23m 13s Tests passed in hadoop-common.     41m 1s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12643658/HADOOP-10582.patch Optional Tests javac unit findbugs checkstyle git revision trunk / cab0dad hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6725/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6725/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6725/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        I'll commit this shortly.

        Show
        ajisakaa Akira Ajisaka added a comment - I'll commit this shortly.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 5m 17s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 28s There were no new javac warning messages.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 3s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 22m 48s Tests passed in hadoop-common.
            40m 45s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12643658/HADOOP-10582.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / cab0dad
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6726/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6726/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6726/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 17s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 3s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 22m 48s Tests passed in hadoop-common.     40m 45s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12643658/HADOOP-10582.patch Optional Tests javac unit findbugs checkstyle git revision trunk / cab0dad hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6726/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6726/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6726/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk and branch-2. Thanks Kousuke Saruta for the contribution.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Kousuke Saruta for the contribution.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7849 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7849/)
        HADOOP-10582. Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7849 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7849/ ) HADOOP-10582 . Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #200 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/200/)
        HADOOP-10582. Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #200 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/200/ ) HADOOP-10582 . Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #931 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/931/)
        HADOOP-10582. Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #931 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/931/ ) HADOOP-10582 . Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #199 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/199/)
        HADOOP-10582. Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #199 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/199/ ) HADOOP-10582 . Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2129 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2129/)
        HADOOP-10582. Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2129 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2129/ ) HADOOP-10582 . Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/189/)
        HADOOP-10582. Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/189/ ) HADOOP-10582 . Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2147 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2147/)
        HADOOP-10582. Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2147 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2147/ ) HADOOP-10582 . Fix the test case for copying to non-existent dir in TestFsShellCopy. Contributed by Kousuke Saruta. (aajisaka: rev a46506d99cb1310c0e446d590f36fb9afae0fa60) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java

          People

          • Assignee:
            sarutak Kousuke Saruta
            Reporter:
            sarutak Kousuke Saruta
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development