Hadoop Common
  1. Hadoop Common
  2. HADOOP-10465

Fix use of generics within SortedMapWritable

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.0.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Target Version/s:

      Description

      SortedMapWritable could use Generics the right way so that there is no warning within the implementation and more important for the consumer.

      1. HADOOP-10465-4.patch
        12 kB
        Bertrand Dechoux
      2. HADOOP-10465-3.patch
        11 kB
        Bertrand Dechoux

        Activity

        Hide
        Bertrand Dechoux added a comment -

        Patch available and made from the trunk. It would be a sane foundation for other issues : MAPREDUCE-2816, HADOOP-5454, HADOOP-9295.

        Show
        Bertrand Dechoux added a comment - Patch available and made from the trunk. It would be a sane foundation for other issues : MAPREDUCE-2816 , HADOOP-5454 , HADOOP-9295 .
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12638990/HADOOP-10465-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3747//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12638990/HADOOP-10465-1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3747//console This message is automatically generated.
        Hide
        Bertrand Dechoux added a comment -

        All hadoop tests are not passing locally but the specific tests about SortedMapWritable have been fixed. The comparable bound was incorrect.

        Show
        Bertrand Dechoux added a comment - All hadoop tests are not passing locally but the specific tests about SortedMapWritable have been fixed. The comparable bound was incorrect.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12639020/HADOOP-10465-2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3749//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12639020/HADOOP-10465-2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3749//console This message is automatically generated.
        Hide
        Bertrand Dechoux added a comment -

        Might introduce source incompatibilities.
        That's the case here with hadoop-streaming.

        Show
        Bertrand Dechoux added a comment - Might introduce source incompatibilities. That's the case here with hadoop-streaming.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12639036/HADOOP-10465-3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        -1 javac. The applied patch generated 1485 javac compiler warnings (more than the trunk's current 1484 warnings).

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-tools/hadoop-streaming.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3750//testReport/
        Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/3750//artifact/trunk/patchprocess/diffJavacWarnings.txt
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3750//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12639036/HADOOP-10465-3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The applied patch generated 1485 javac compiler warnings (more than the trunk's current 1484 warnings). +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-tools/hadoop-streaming. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3750//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/3750//artifact/trunk/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3750//console This message is automatically generated.
        Hide
        Bertrand Dechoux added a comment -

        Cleaning streaming code impacted by SortedMapWritable.

        Show
        Bertrand Dechoux added a comment - Cleaning streaming code impacted by SortedMapWritable.
        Hide
        Adam Pritchard added a comment -

        Hi Bertrand,

        I am new to Hadoop but would like to help contribute in anyway. I'd like to help test these patches. Could you please provide steps to reproduce / test these patches? I know how to install a patch, just wondering what specific tests I should run on this. - Thanks

        Show
        Adam Pritchard added a comment - Hi Bertrand, I am new to Hadoop but would like to help contribute in anyway. I'd like to help test these patches. Could you please provide steps to reproduce / test these patches? I know how to install a patch, just wondering what specific tests I should run on this. - Thanks
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12639060/HADOOP-10465-4.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-tools/hadoop-streaming.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3752//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3752//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12639060/HADOOP-10465-4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-tools/hadoop-streaming. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3752//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3752//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 42s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 42s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 19s The applied patch generated 3 new checkstyle issues (total was 6, now 6).
        -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 17s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 22m 46s Tests passed in hadoop-common.
        +1 tools/hadoop tests 6m 8s Tests passed in hadoop-streaming.
            67m 1s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12639060/HADOOP-10465-4.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 6ae2a0d
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6425/artifact/patchprocess/diffcheckstylehadoop-common.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6425/artifact/patchprocess/whitespace.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6425/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6425/artifact/patchprocess/testrun_hadoop-streaming.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6425/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6425/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 42s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 19s The applied patch generated 3 new checkstyle issues (total was 6, now 6). -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 17s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 22m 46s Tests passed in hadoop-common. +1 tools/hadoop tests 6m 8s Tests passed in hadoop-streaming.     67m 1s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12639060/HADOOP-10465-4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6ae2a0d checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6425/artifact/patchprocess/diffcheckstylehadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6425/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6425/artifact/patchprocess/testrun_hadoop-common.txt hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6425/artifact/patchprocess/testrun_hadoop-streaming.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6425/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6425/console This message was automatically generated.

          People

          • Assignee:
            Unassigned
            Reporter:
            Bertrand Dechoux
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development