[HADOOP-10440] HarFsInputStream of HarFileSystem, when reading data, computing the position has bug

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.0
• Fix Version/s: 2.4.0
• Component/s: fs
• Hadoop Flags: Reviewed
• Assignee: guodongdong
• Reporter: guodongdong
• Created: 26/Mar/14 11:21
• Updated: 10/Apr/14 13:12
• Resolved: 26/Mar/14 17:50

Description

In the HarFsInputStream of HarFileSystem, when reading data by interface "int read(byte[] b)", "int read(byte[] b, int offset, int len)" wille be called and position wille be update, so position need not be update in interface "int read(byte[] b)"

//HarFileSystem.HarFsInputStream
      public synchronized int read(byte[] b) throws IOException {
        int ret = read(b, 0, b.length);
        if (ret != -1) {
          position += ret;
        }
        return ret;
      }

      /**
       *
       */
      public synchronized int read(byte[] b, int offset, int len)
        throws IOException {
        int newlen = len;
        int ret = -1;
        if (position + len > end) {
          newlen = (int) (end - position);
        }
        // end case
        if (newlen == 0)
          return ret;
        ret = underLyingStream.read(b, offset, newlen);
        position += ret;
        return ret;
      }

Issue Links

• relates to: HADOOP-9361 Strictly define the expected behavior of filesystem APIs and write tests to verify compliance