Hadoop Common
  1. Hadoop Common
  2. HADOOP-10414

Incorrect property name for RefreshUserMappingProtocol in hadoop-policy.xml

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.0
    • Fix Version/s: 2.5.0
    • Component/s: conf
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      In HDFS-1096 and MAPREDUCE-1836, the name of the ACL property for the RefreshUserMappingsProtocol service changed from security.refresh.usertogroups.mappings.protocol.acl to security.refresh.user.mappings.protocol.acl, but the example in hadoop-policy.xml was not updated. The example should be fixed to avoid confusion.

      1. HADOOP-10414.patch
        0.6 kB
        Joey Echeverria

        Activity

        Joey Echeverria created issue -
        Hide
        Joey Echeverria added a comment -

        Simple patch to fix the example hadoop-policy.xml file.

        Show
        Joey Echeverria added a comment - Simple patch to fix the example hadoop-policy.xml file.
        Joey Echeverria made changes -
        Field Original Value New Value
        Attachment HADOOP-10414.patch [ 12635775 ]
        Joey Echeverria made changes -
        Assignee Joey Echeverria [ fwiffo ]
        Joey Echeverria made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12635775/HADOOP-10414.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3687//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3687//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12635775/HADOOP-10414.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3687//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3687//console This message is automatically generated.
        Hide
        Joey Echeverria added a comment -

        I manually verified that the updated parameter in hadoop-policy.xml matches what's in the source code. I don't think a test is needed.

        Show
        Joey Echeverria added a comment - I manually verified that the updated parameter in hadoop-policy.xml matches what's in the source code. I don't think a test is needed.
        Aaron T. Myers made changes -
        Description In HDFS-1096 and MAPREDUCE-1836, the name of the ACL property for the RefreshUserMappingsProtocol service changed form security.refresh.usertogroups.mappings.protocol.acl to security.refresh.user.mappings.protocol.acl, but the example in hadoop-policy.xml was not updated. The example should be fixed to avoid confusion. In HDFS-1096 and MAPREDUCE-1836, the name of the ACL property for the RefreshUserMappingsProtocol service changed from security.refresh.usertogroups.mappings.protocol.acl to security.refresh.user.mappings.protocol.acl, but the example in hadoop-policy.xml was not updated. The example should be fixed to avoid confusion.
        Hide
        Aaron T. Myers added a comment -

        I agree - no test needed for this simple fix.

        +1, the patch looks good to me. I'm going to commit this momentarily.

        Show
        Aaron T. Myers added a comment - I agree - no test needed for this simple fix. +1, the patch looks good to me. I'm going to commit this momentarily.
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to trunk and branch-2.

        Thanks a lot for the contribution, Joey.

        Show
        Aaron T. Myers added a comment - I've just committed this to trunk and branch-2. Thanks a lot for the contribution, Joey.
        Aaron T. Myers made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Target Version/s 2.5.0 [ 12326263 ]
        Fix Version/s 2.5.0 [ 12326263 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #5442 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5442/)
        HADOOP-10414. Incorrect property name for RefreshUserMappingProtocol in hadoop-policy.xml. Contributed by Joey Echeverria. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1583729)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-policy.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5442 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5442/ ) HADOOP-10414 . Incorrect property name for RefreshUserMappingProtocol in hadoop-policy.xml. Contributed by Joey Echeverria. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1583729 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-policy.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #527 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/527/)
        HADOOP-10414. Incorrect property name for RefreshUserMappingProtocol in hadoop-policy.xml. Contributed by Joey Echeverria. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1583729)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-policy.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #527 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/527/ ) HADOOP-10414 . Incorrect property name for RefreshUserMappingProtocol in hadoop-policy.xml. Contributed by Joey Echeverria. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1583729 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-policy.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1745 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1745/)
        HADOOP-10414. Incorrect property name for RefreshUserMappingProtocol in hadoop-policy.xml. Contributed by Joey Echeverria. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1583729)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-policy.xml
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1745 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1745/ ) HADOOP-10414 . Incorrect property name for RefreshUserMappingProtocol in hadoop-policy.xml. Contributed by Joey Echeverria. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1583729 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-policy.xml
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        3m 30s 1 Joey Echeverria 20/Mar/14 11:56
        Patch Available Patch Available Resolved Resolved
        12d 4h 26m 1 Aaron T. Myers 01/Apr/14 17:22

          People

          • Assignee:
            Joey Echeverria
            Reporter:
            Joey Echeverria
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development