Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-10325

improve jenkins javadoc warnings from test-patch.sh

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Currently test-patch.sh uses OK_JAVADOC_WARNINGS to know how many warnings trunk is expected to have. However, this is a fragile and difficult to use system, since different build slaves may generate different numbers of warnings (based on compiler revision, etc.). Also, programmers must remember to update OK_JAVADOC_WARNINGS, which they don't always. Finally, there is no easy way to find what the new javadoc warnings are in the huge pile of warnings.

      We should change this to work the same way the javac warnings code does: to simply build with and without the patch and do a diff. The diff should be saved for easy perusal. We also should not complain about warnings being removed.

        Attachments

        1. HADOOP-10325.001.patch
          3 kB
          Colin P. McCabe
        2. HADOOP-10325.002.patch
          3 kB
          Colin P. McCabe
        3. HADOOP-10325.003.patch
          3 kB
          Colin P. McCabe
        4. HADOOP-10325.004.patch
          4 kB
          Colin P. McCabe

          Activity

            People

            • Assignee:
              cmccabe Colin P. McCabe
              Reporter:
              cmccabe Colin P. McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: