Details
-
Bug
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
2.3.0
-
None
-
Reviewed
Description
HADOOP-10085 fixes some synchronization issues in CompositeService#addService(). The tests should cover all cases.
Attachments
Attachments
- HADOOP10321-01.patch
- 20 kB
- Ray Chiang
- HADOOP-10321-02.patch
- 20 kB
- Ray Chiang
- HADOOP-10321-03.patch
- 20 kB
- Ray Chiang
- HADOOP-10321-04.patch
- 21 kB
- Ray Chiang
- HADOOP-10321-04.patch
- 21 kB
- Karthik Kambatla
Activity
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12662557/HADOOP-10321-02.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 javadoc. The javadoc tool appears to have generated 24 warning messages.
See https://builds.apache.org/job/PreCommit-HADOOP-Build/4500//artifact/trunk/patchprocess/diffJavadocWarnings.txt for details.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestActiveStandbyElector
org.apache.hadoop.ha.TestZKFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4500//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4500//console
This message is automatically generated.
No changes, but submitting new patch. Currently does not show Javadoc warnings against trunk.
Still running into Javadoc warnings. Canceling patch until it can be fixed.
Submitting duplicate patch against latest trunk. Javadoc warnings for Junit/@Test/timeout are apparently well known.
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12674873/HADOOP-10321-04.patch
against trunk revision cdce883.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 javadoc. The javadoc tool appears to have generated 24 warning messages.
See https://builds.apache.org/job/PreCommit-HADOOP-Build/4925//artifact/patchprocess/diffJavadocWarnings.txt for details.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4925//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4925//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4925//console
This message is automatically generated.
RE: Javadoc warnings
This appears to be in the "known" category of warnings as mentioned in https://issues.apache.org/jira/browse/HADOOP-11082?focusedCommentId=14140193&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14140193
RE: Findbugs warnings
None of these belong to the modified file
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | pre-patch | 5m 16s | Pre-patch trunk compilation is healthy. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | tests included | 0m 0s | The patch appears to include 1 new or modified test files. |
+1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
+1 | javac | 7m 28s | There were no new javac warning messages. |
+1 | release audit | 0m 21s | The applied patch does not increase the total number of release audit warnings. |
+1 | checkstyle | 7m 1s | There were no new checkstyle issues. |
+1 | install | 1m 32s | mvn install still works. |
+1 | eclipse:eclipse | 0m 31s | The patch built with eclipse:eclipse. |
+1 | findbugs | 1m 40s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. |
+1 | common tests | 24m 16s | Tests passed in hadoop-common. |
48m 22s |
Subsystem | Report/Notes |
---|---|
Patch URL | http://issues.apache.org/jira/secure/attachment/12674873/HADOOP-10321-04.patch |
Optional Tests | javac unit findbugs checkstyle |
git revision | trunk / 6bae596 |
hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6198/artifact/patchprocess/testrun_hadoop-common.txt |
Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6198/testReport/ |
Java | 1.7.0_55 |
uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6198/console |
This message was automatically generated.
The patch looks good to me. +1
Resubmitting the patch to kick Jenkins to be safe. Will commit once it passes.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 13s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
+1 | mvninstall | 7m 2s | trunk passed |
+1 | compile | 8m 0s | trunk passed with JDK v1.8.0_72 |
+1 | compile | 7m 9s | trunk passed with JDK v1.7.0_95 |
+1 | checkstyle | 0m 19s | trunk passed |
+1 | mvnsite | 1m 4s | trunk passed |
+1 | mvneclipse | 0m 11s | trunk passed |
+1 | findbugs | 1m 38s | trunk passed |
+1 | javadoc | 1m 14s | trunk passed with JDK v1.8.0_72 |
+1 | javadoc | 1m 7s | trunk passed with JDK v1.7.0_95 |
+1 | mvninstall | 0m 40s | the patch passed |
+1 | compile | 7m 58s | the patch passed with JDK v1.8.0_72 |
+1 | javac | 7m 58s | the patch passed |
+1 | compile | 7m 16s | the patch passed with JDK v1.7.0_95 |
+1 | javac | 7m 16s | the patch passed |
+1 | checkstyle | 0m 20s | the patch passed |
+1 | mvnsite | 1m 2s | the patch passed |
+1 | mvneclipse | 0m 13s | the patch passed |
+1 | whitespace | 0m 0s | Patch has no whitespace issues. |
+1 | findbugs | 1m 52s | the patch passed |
+1 | javadoc | 1m 2s | the patch passed with JDK v1.8.0_72 |
+1 | javadoc | 1m 6s | the patch passed with JDK v1.7.0_95 |
+1 | unit | 8m 37s | hadoop-common in the patch passed with JDK v1.8.0_72. |
+1 | unit | 8m 19s | hadoop-common in the patch passed with JDK v1.7.0_95. |
+1 | asflicense | 0m 21s | Patch does not generate ASF License warnings. |
67m 47s |
Subsystem | Report/Notes |
---|---|
Docker | Image:yetus/hadoop:0ca8df7 |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12790612/HADOOP-10321-04.patch |
JIRA Issue | |
Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
uname | Linux 21fe4fe92613 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
git revision | trunk / 2151716 |
Default Java | 1.7.0_95 |
Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 |
findbugs | v3.0.0 |
JDK v1.7.0_95 Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/8752/testReport/ |
modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/8752/console |
Powered by | Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Thanks a bunch for working on this, rchiang. Feels good to commit this two-year old JIRA
Just committed to trunk and branch-2.
FAILURE: Integrated in Hadoop-trunk-Commit #9398 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9398/)
HADOOP-10321. TestCompositeService should cover all enumerations of (kasha: rev 680f3fc02d0037d13c84a8b5c1a7e8729c0bcc94)
- hadoop-common-project/hadoop-common/CHANGES.txt
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/service/TestCompositeService.java
Add test functions for all permutations of Service.STATE for parent/child and parent/sibling.