Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-10318

Incorrect reference to nodeFile in RumenToSLSConverter error message

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

          if (! nodeFile.getParentFile().exists()
                  && ! nodeFile.getParentFile().mkdirs()) {
            System.err.println("ERROR: Cannot create output directory in path: "
                    + jsonFile.getParentFile().getAbsoluteFile());
      

      jsonFile on the last line should be nodeFile

        Activity

        Hide
        ywskycn Wei Yan added a comment -

        Thanks, Ted Yu. Just upload a patch to fix that bug.

        Show
        ywskycn Wei Yan added a comment - Thanks, Ted Yu . Just upload a patch to fix that bug.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12626263/HADOOP-10318.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-sls.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3510//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3510//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12626263/HADOOP-10318.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-sls. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3510//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3510//console This message is automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 40s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 38s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 23s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 0m 41s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 tools/hadoop tests 0m 51s Tests passed in hadoop-sls.
            36m 15s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12626263/HADOOP-10318.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 6ae2a0d
        hadoop-sls test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6422/artifact/patchprocess/testrun_hadoop-sls.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6422/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6422/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 40s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 23s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 41s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 tools/hadoop tests 0m 51s Tests passed in hadoop-sls.     36m 15s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12626263/HADOOP-10318.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6ae2a0d hadoop-sls test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6422/artifact/patchprocess/testrun_hadoop-sls.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6422/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6422/console This message was automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        +1, checking this in.

        Show
        ozawa Tsuyoshi Ozawa added a comment - +1, checking this in.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Committed this to trunk and branch-2. Thanks
        Wei Yan for your contribution and Akira Ajisaka for your review.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Wei Yan for your contribution and Akira Ajisaka for your review.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8396 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8396/)
        HADOOP-10318. Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9)

        • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8396 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8396/ ) HADOOP-10318 . Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9) hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #347 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/347/)
        HADOOP-10318. Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9)

        • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #347 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/347/ ) HADOOP-10318 . Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9) hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1077 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1077/)
        HADOOP-10318. Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9)

        • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1077 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1077/ ) HADOOP-10318 . Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9) hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2289 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2289/)
        HADOOP-10318. Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9)

        • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2289 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2289/ ) HADOOP-10318 . Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9) hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        ywskycn Wei Yan added a comment -

        Thanks, Tsuyoshi Ozawa.

        Show
        ywskycn Wei Yan added a comment - Thanks, Tsuyoshi Ozawa .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #340 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/340/)
        HADOOP-10318. Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #340 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/340/ ) HADOOP-10318 . Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2268 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2268/)
        HADOOP-10318. Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2268 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2268/ ) HADOOP-10318 . Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #330 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/330/)
        HADOOP-10318. Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9)

        • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #330 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/330/ ) HADOOP-10318 . Incorrect reference to nodeFile in RumenToSLSConverter error message. Contributed by Wei Yan. (ozawa: rev 355eaaa33d01f06e9efe960b8888fb925e03ffb9) hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RumenToSLSConverter.java hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            ywskycn Wei Yan
            Reporter:
            yuzhihong@gmail.com Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development