Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4.0
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      We wish to swap the active call queue during runtime in order to do performance tuning without restarting the namenode.
      This patch adds the ability to refresh the call queue on the namenode, through dfsadmin -refreshCallQueue

      1. HADOOP-10285.patch
        28 kB
        Chris Li
      2. bisection-test.patch
        23 kB
        Chris Li
      3. bisection-test.patch
        10 kB
        Chris Li
      4. bisection-test.patch
        13 kB
        Chris Li
      5. bisection-test.patch
        5 kB
        Chris Li
      6. bisection-test.patch
        0.7 kB
        Chris Li
      7. HADOOP-10285.patch
        28 kB
        Chris Li
      8. HADOOP-10285.patch
        27 kB
        Chris Li
      9. HADOOP-10285.patch
        27 kB
        Chris Li

        Issue Links

          Activity

          Hide
          Chris Li added a comment -

          Users can swap the queue by running

          hadoop dfsadmin -refreshCallQueue

          The code touches a lot of places, but is effectively a mirror of what refreshServiceAcl does to accomplish the same thing.

          Show
          Chris Li added a comment - Users can swap the queue by running hadoop dfsadmin -refreshCallQueue The code touches a lot of places, but is effectively a mirror of what refreshServiceAcl does to accomplish the same thing.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12625700/subtask3_admin_interface.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3491//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12625700/subtask3_admin_interface.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3491//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12628662/HADOOP-10285.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3566//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12628662/HADOOP-10285.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3566//console This message is automatically generated.
          Hide
          Chris Li added a comment -

          Add admin interface, meant to be patched on top of HADOOP-10278-atomicref-adapter

          Show
          Chris Li added a comment - Add admin interface, meant to be patched on top of HADOOP-10278 -atomicref-adapter
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12629199/HADOOP-10285.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          -1 javac. The patch appears to cause the build to fail.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3584//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629199/HADOOP-10285.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3584//console This message is automatically generated.
          Hide
          Chris Li added a comment -

          Re-uploading the patch to get QA to run again

          Show
          Chris Li added a comment - Re-uploading the patch to get QA to run again
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12630389/HADOOP-10285.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3595//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/3595//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3595//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12630389/HADOOP-10285.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3595//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/3595//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3595//console This message is automatically generated.
          Hide
          Chris Li added a comment -

          Suppress findbugs errors like the other protobufs do; not sure why the HA test fails, it passed on my machine. Let's try again.

          Show
          Chris Li added a comment - Suppress findbugs errors like the other protobufs do; not sure why the HA test fails, it passed on my machine. Let's try again.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12630428/HADOOP-10285.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3596//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3596//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12630428/HADOOP-10285.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3596//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3596//console This message is automatically generated.
          Hide
          Chris Li added a comment -

          I'm not sure how this patch affects NN HA.. does anyone have any ideas? The test doesn't fail on my local dev machine either.

          Show
          Chris Li added a comment - I'm not sure how this patch affects NN HA.. does anyone have any ideas? The test doesn't fail on my local dev machine either.
          Hide
          Chris Li added a comment -

          Okay well this is pretty unfortunate. What I can do is try to isolate the change that causes QA to fail by submitting a ton of patches. I'll start with this one change, which should not cause any tests to fail.

          Show
          Chris Li added a comment - Okay well this is pretty unfortunate. What I can do is try to isolate the change that causes QA to fail by submitting a ton of patches. I'll start with this one change, which should not cause any tests to fail.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12631091/bisection-test.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3606//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3606//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631091/bisection-test.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3606//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3606//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12631128/bisection-test.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3608//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3608//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631128/bisection-test.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3608//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3608//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12631342/bisection-test.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javac. The patch appears to cause the build to fail.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3609//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631342/bisection-test.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3609//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12631408/bisection-test.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3611//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3611//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631408/bisection-test.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3611//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3611//console This message is automatically generated.
          Hide
          Arpit Agarwal added a comment -

          Hi Chris, a few questions unrelated to the test failure.

          1. refreshCallQueue calls will be accepted by both the datanode and the client RPC services. Is the former necessary? It looks like DFSAdmin will only target the client RPC service.
          2. For the refresh call to work the configuration must have been modified on the server. Is the administrator required to do so manually before calling refresh?
          3. Do we need separate protocols for each Refresh... call? Perhaps we can't remove existing protocols for backwards compatibility, but going forward can we have a single protocol? What do you think?

          Thanks.

          Show
          Arpit Agarwal added a comment - Hi Chris, a few questions unrelated to the test failure. refreshCallQueue calls will be accepted by both the datanode and the client RPC services. Is the former necessary? It looks like DFSAdmin will only target the client RPC service. For the refresh call to work the configuration must have been modified on the server. Is the administrator required to do so manually before calling refresh? Do we need separate protocols for each Refresh... call? Perhaps we can't remove existing protocols for backwards compatibility, but going forward can we have a single protocol? What do you think? Thanks.
          Hide
          Chris Li added a comment -

          Sure thing.

          refreshCallQueue calls will be accepted by both the datanode and the client RPC services. Is the former necessary? It looks like DFSAdmin will only target the client RPC service.

          I don't think it's necessary on the datanode at this point. It doesn't hurt to restart the datanode.

          For the refresh call to work the configuration must have been modified on the server. Is the administrator required to do so manually before calling refresh?

          Yup. This is how the other refresh* calls work too I believe.

          Do we need separate protocols for each Refresh... call? Perhaps we can't remove existing protocols for backwards compatibility, but going forward can we have a single protocol? What do you think?

          Interesting idea, I also think it would be nice to have a return status on the Refresh* calls too, because right now they're just void. Is that something we'd want done in this patch, or a separate issue to refactor RefreshCallQueueProto into something more generic?

          Show
          Chris Li added a comment - Sure thing. refreshCallQueue calls will be accepted by both the datanode and the client RPC services. Is the former necessary? It looks like DFSAdmin will only target the client RPC service. I don't think it's necessary on the datanode at this point. It doesn't hurt to restart the datanode. For the refresh call to work the configuration must have been modified on the server. Is the administrator required to do so manually before calling refresh? Yup. This is how the other refresh* calls work too I believe. Do we need separate protocols for each Refresh... call? Perhaps we can't remove existing protocols for backwards compatibility, but going forward can we have a single protocol? What do you think? Interesting idea, I also think it would be nice to have a return status on the Refresh* calls too, because right now they're just void. Is that something we'd want done in this patch, or a separate issue to refactor RefreshCallQueueProto into something more generic?
          Hide
          Arpit Agarwal added a comment -

          I don't think it's necessary on the datanode at this point. It doesn't hurt to restart the datanode.

          Sorry I meant this in the NameNodeRpcServer constructor.

                DFSUtil.addPBProtocol(conf, RefreshCallQueueProtocolPB.class,
                    refreshCallQueueService, serviceRpcServer);
          

          I don't think we need to accept refreshCallQueue on the serviceRpcServer port. We can remove this line of code.

          Interesting idea, I also think it would be nice to have a return status on the Refresh* calls too, because right now they're just void. Is that something we'd want done in this patch, or a separate issue to refactor RefreshCallQueueProto into something more generic?

          We can address it in a separate Jira if it makes sense, but ideally in the same release so we don't have to support RefreshCallQueueProto forever.

          Thanks for the quick response.

          Show
          Arpit Agarwal added a comment - I don't think it's necessary on the datanode at this point. It doesn't hurt to restart the datanode. Sorry I meant this in the NameNodeRpcServer constructor. DFSUtil.addPBProtocol(conf, RefreshCallQueueProtocolPB.class, refreshCallQueueService, serviceRpcServer); I don't think we need to accept refreshCallQueue on the serviceRpcServer port. We can remove this line of code. Interesting idea, I also think it would be nice to have a return status on the Refresh* calls too, because right now they're just void. Is that something we'd want done in this patch, or a separate issue to refactor RefreshCallQueueProto into something more generic? We can address it in a separate Jira if it makes sense, but ideally in the same release so we don't have to support RefreshCallQueueProto forever. Thanks for the quick response.
          Hide
          Chris Li added a comment -

          The service RPC queue is so that we can get through in the event the clientRPC queue is completely full.

          We can address it in a separate Jira if it makes sense, but ideally in the same release so we don't have to support RefreshCallQueueProto forever.

          Makes sense, I'll give that a shot.

          Show
          Chris Li added a comment - The service RPC queue is so that we can get through in the event the clientRPC queue is completely full. We can address it in a separate Jira if it makes sense, but ideally in the same release so we don't have to support RefreshCallQueueProto forever. Makes sense, I'll give that a shot.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12631588/bisection-test.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3616//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3616//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631588/bisection-test.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3616//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3616//console This message is automatically generated.
          Hide
          Arpit Agarwal added a comment -

          Thanks Chris,the patch looks good, couple of points:

          1. Can you please add a comment in the NameNodeRpcServer constructor explaining why the service RPC endpoint supports refreshCallQueue?
          2. Is it easy to add an end-end test case now that the client and server pieces are in place?

          I am not sure if the TestHASafeMode failure is related. I can't repro it on OS X or Centos 6 with your changes. I think it is a Jenkins quirk and I am inclined to commit it even with the failure.

          Show
          Arpit Agarwal added a comment - Thanks Chris,the patch looks good, couple of points: Can you please add a comment in the NameNodeRpcServer constructor explaining why the service RPC endpoint supports refreshCallQueue ? Is it easy to add an end-end test case now that the client and server pieces are in place? I am not sure if the TestHASafeMode failure is related. I can't repro it on OS X or Centos 6 with your changes. I think it is a Jenkins quirk and I am inclined to commit it even with the failure.
          Hide
          Chris Li added a comment -

          Sure I can do 1 & 2.

          Do you still want me to make a generic RefreshConfigurationProtocol? Or can that be done in another patch?

          Show
          Chris Li added a comment - Sure I can do 1 & 2. Do you still want me to make a generic RefreshConfigurationProtocol? Or can that be done in another patch?
          Hide
          Arpit Agarwal added a comment -

          Your call, either is fine by me. Thanks!

          Show
          Arpit Agarwal added a comment - Your call, either is fine by me. Thanks!
          Hide
          Chris Li added a comment -

          Okay, here's 10285, adding the comment

          On closer inspection, a true end to end test would be difficult, because refreshCallQueue() has a void response, so we'd have to go digging around in the server's internals to verify (we'd have to add more @visibleForTesting getters)

          We can open another issue to refactor the refresh*protos into one generic RefreshConfigurationProto, which can provide a return value indicating success or failure. This will also make testing easier to do.

          Let me know if that's okay.

          Show
          Chris Li added a comment - Okay, here's 10285, adding the comment On closer inspection, a true end to end test would be difficult, because refreshCallQueue() has a void response, so we'd have to go digging around in the server's internals to verify (we'd have to add more @visibleForTesting getters) We can open another issue to refactor the refresh*protos into one generic RefreshConfigurationProto, which can provide a return value indicating success or failure. This will also make testing easier to do. Let me know if that's okay.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12631633/HADOOP-10285.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3620//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3620//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631633/HADOOP-10285.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3620//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3620//console This message is automatically generated.
          Hide
          Arpit Agarwal added a comment -

          +1 for the latest patch. I will commit it today.

          Chris Li could you please file Jiras for the two remaining tasks: End-end test case; and Refactor to create a generic refresh protocol?

          Show
          Arpit Agarwal added a comment - +1 for the latest patch. I will commit it today. Chris Li could you please file Jiras for the two remaining tasks: End-end test case; and Refactor to create a generic refresh protocol?
          Show
          Chris Li added a comment - Sounds good; Done: https://issues.apache.org/jira/browse/HADOOP-10376 https://issues.apache.org/jira/browse/HADOOP-10377
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #5247 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5247/)
          HADOOP-10285. Admin interface to swap callqueue at runtime. (Contributed by Chris Li) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573052)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RefreshCallQueueProtocol.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolClientSideTranslatorPB.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolPB.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolServerSideTranslatorPB.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RefreshCallQueueProtocol.proto
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/NamenodeProtocols.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestIsMethodSupported.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5247 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5247/ ) HADOOP-10285 . Admin interface to swap callqueue at runtime. (Contributed by Chris Li) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573052 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RefreshCallQueueProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolClientSideTranslatorPB.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolPB.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolServerSideTranslatorPB.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RefreshCallQueueProtocol.proto /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/NamenodeProtocols.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestIsMethodSupported.java
          Hide
          Arpit Agarwal added a comment -

          I committed this to trunk through branch-2.4.

          Thanks for the contribution Chris.

          Show
          Arpit Agarwal added a comment - I committed this to trunk through branch-2.4. Thanks for the contribution Chris.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #5248 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5248/)
          Update target version to 2.4.0 for HADOOP-10278 and HADOOP-10285 in CHANGES.txt (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573070)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5248 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5248/ ) Update target version to 2.4.0 for HADOOP-10278 and HADOOP-10285 in CHANGES.txt (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573070 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Chris Li added a comment -

          Awesome, thanks!

          Also to any watchers, the next step in the patch is the Schedulable interface, here: https://issues.apache.org/jira/browse/HADOOP-10280

          Show
          Chris Li added a comment - Awesome, thanks! Also to any watchers, the next step in the patch is the Schedulable interface, here: https://issues.apache.org/jira/browse/HADOOP-10280
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #496 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/496/)
          Update target version to 2.4.0 for HADOOP-10278 and HADOOP-10285 in CHANGES.txt (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573070)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            HADOOP-10285. Admin interface to swap callqueue at runtime. (Contributed by Chris Li) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573052)
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RefreshCallQueueProtocol.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolClientSideTranslatorPB.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolPB.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolServerSideTranslatorPB.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RefreshCallQueueProtocol.proto
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/NamenodeProtocols.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestIsMethodSupported.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #496 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/496/ ) Update target version to 2.4.0 for HADOOP-10278 and HADOOP-10285 in CHANGES.txt (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573070 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-10285 . Admin interface to swap callqueue at runtime. (Contributed by Chris Li) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573052 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RefreshCallQueueProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolClientSideTranslatorPB.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolPB.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolServerSideTranslatorPB.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RefreshCallQueueProtocol.proto /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/NamenodeProtocols.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestIsMethodSupported.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1688 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1688/)
          Update target version to 2.4.0 for HADOOP-10278 and HADOOP-10285 in CHANGES.txt (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573070)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            HADOOP-10285. Admin interface to swap callqueue at runtime. (Contributed by Chris Li) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573052)
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RefreshCallQueueProtocol.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolClientSideTranslatorPB.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolPB.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolServerSideTranslatorPB.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RefreshCallQueueProtocol.proto
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/NamenodeProtocols.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestIsMethodSupported.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1688 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1688/ ) Update target version to 2.4.0 for HADOOP-10278 and HADOOP-10285 in CHANGES.txt (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573070 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-10285 . Admin interface to swap callqueue at runtime. (Contributed by Chris Li) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573052 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RefreshCallQueueProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolClientSideTranslatorPB.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolPB.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolServerSideTranslatorPB.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RefreshCallQueueProtocol.proto /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/NamenodeProtocols.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestIsMethodSupported.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1713 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1713/)
          Update target version to 2.4.0 for HADOOP-10278 and HADOOP-10285 in CHANGES.txt (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573070)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            HADOOP-10285. Admin interface to swap callqueue at runtime. (Contributed by Chris Li) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573052)
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RefreshCallQueueProtocol.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolClientSideTranslatorPB.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolPB.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolServerSideTranslatorPB.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RefreshCallQueueProtocol.proto
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/NamenodeProtocols.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestIsMethodSupported.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1713 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1713/ ) Update target version to 2.4.0 for HADOOP-10278 and HADOOP-10285 in CHANGES.txt (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573070 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-10285 . Admin interface to swap callqueue at runtime. (Contributed by Chris Li) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573052 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RefreshCallQueueProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolClientSideTranslatorPB.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolPB.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/RefreshCallQueueProtocolServerSideTranslatorPB.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RefreshCallQueueProtocol.proto /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/NamenodeProtocols.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestIsMethodSupported.java

            People

            • Assignee:
              Chris Li
              Reporter:
              Chris Li
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development