Hadoop Common
  1. Hadoop Common
  2. HADOOP-10252

HttpServer can't start if hostname is not specified

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 2.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Target Version/s:

      Description

      HADOOP-8362 added a checking to make sure configuration values are not null. By default, we don't specify the hostname for the HttpServer. So we could not start info server due to

      2014-01-22 08:43:05,969 FATAL [M:0;localhost:48573] master.HMaster(2187): Unhandled exception. Starting shutdown.
      java.lang.IllegalArgumentException: Property value must not be null
      	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:92)
      	at org.apache.hadoop.conf.Configuration.set(Configuration.java:958)
      	at org.apache.hadoop.conf.Configuration.set(Configuration.java:940)
      	at org.apache.hadoop.http.HttpServer.initializeWebServer(HttpServer.java:510)
      	at org.apache.hadoop.http.HttpServer.<init>(HttpServer.java:470)
      	at org.apache.hadoop.http.HttpServer.<init>(HttpServer.java:458)
      	at org.apache.hadoop.http.HttpServer.<init>(HttpServer.java:412)
      	at org.apache.hadoop.hbase.util.InfoServer.<init>(InfoServer.java:59)
      	at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:584)
      	at java.lang.Thread.run(Thread.java:722)

        Issue Links

          Activity

          Hide
          Aaron T. Myers added a comment -

          Patch looks good to me. +1 pending Jenkins.

          Show
          Aaron T. Myers added a comment - Patch looks good to me. +1 pending Jenkins.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12624372/hadoop-10252.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3459//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3459//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12624372/hadoop-10252.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3459//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3459//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          I've just committed this to trunk and branch-2.

          Thanks a lot for the contribution, Jimmy.

          Show
          Aaron T. Myers added a comment - I've just committed this to trunk and branch-2. Thanks a lot for the contribution, Jimmy.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #5032 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5032/)
          HADOOP-10252. HttpServer can't start if hostname is not specified. Contributed by Jimmy Xiang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560450)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5032 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5032/ ) HADOOP-10252 . HttpServer can't start if hostname is not specified. Contributed by Jimmy Xiang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560450 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Hide
          Haohui Mai added a comment -

          This is due to hbase is using the deprecated constructor. HBASE-10336 is tracking the issue.

          Show
          Haohui Mai added a comment - This is due to hbase is using the deprecated constructor. HBASE-10336 is tracking the issue.
          Hide
          Jimmy Xiang added a comment -

          Yes, HBase uses the deprecate constructor. It should work if it is not removed.

          Show
          Jimmy Xiang added a comment - Yes, HBase uses the deprecate constructor. It should work if it is not removed.
          Hide
          Haohui Mai added a comment -

          My concern is that it might not solve the HBase problem completely. Recently HttpServer has gone through major surgeries for HTTPS support. For obvious reason the deprecated code path is not very well tested.

          I have spent reasonable amount of time to test the current code paths of the HttpServer in NN / DN / JN / SNN in various configuration. In my opinion the approach that HBASE-10336 takes might be a safer bet.

          Show
          Haohui Mai added a comment - My concern is that it might not solve the HBase problem completely. Recently HttpServer has gone through major surgeries for HTTPS support. For obvious reason the deprecated code path is not very well tested. I have spent reasonable amount of time to test the current code paths of the HttpServer in NN / DN / JN / SNN in various configuration. In my opinion the approach that HBASE-10336 takes might be a safer bet.
          Hide
          Jimmy Xiang added a comment -

          I think we can do both for now. Otherwise, existing older versions of HBase will have problem to work with HDFS 2.4+.

          Show
          Jimmy Xiang added a comment - I think we can do both for now. Otherwise, existing older versions of HBase will have problem to work with HDFS 2.4+.
          Hide
          Andrew Purtell added a comment -

          Based on the discussion on HBASE-10336, it is likely not to go in on any released or soon to be released version of HBase. The next release is likely a few months out.

          Show
          Andrew Purtell added a comment - Based on the discussion on HBASE-10336 , it is likely not to go in on any released or soon to be released version of HBase. The next release is likely a few months out.
          Hide
          stack added a comment -

          Thanks for applying this patch. We are working to undo our dependency but cannot take the hit just yet; the undo will go into our trunk in a day or so with a release to follow soon after (a few months at most as per Andrew Purtell above). Thanks.

          Show
          stack added a comment - Thanks for applying this patch. We are working to undo our dependency but cannot take the hit just yet; the undo will go into our trunk in a day or so with a release to follow soon after (a few months at most as per Andrew Purtell above). Thanks.
          Hide
          Haohui Mai added a comment -

          Created HADOOP-10253 to track the effort of removing deprecated methods in HttpServer. Let's coordinate our effort in that jira.

          Show
          Haohui Mai added a comment - Created HADOOP-10253 to track the effort of removing deprecated methods in HttpServer . Let's coordinate our effort in that jira.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #461 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/461/)
          HADOOP-10252. HttpServer can't start if hostname is not specified. Contributed by Jimmy Xiang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560450)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #461 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/461/ ) HADOOP-10252 . HttpServer can't start if hostname is not specified. Contributed by Jimmy Xiang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560450 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1678 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1678/)
          HADOOP-10252. HttpServer can't start if hostname is not specified. Contributed by Jimmy Xiang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560450)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1678 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1678/ ) HADOOP-10252 . HttpServer can't start if hostname is not specified. Contributed by Jimmy Xiang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560450 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1653 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1653/)
          HADOOP-10252. HttpServer can't start if hostname is not specified. Contributed by Jimmy Xiang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560450)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1653 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1653/ ) HADOOP-10252 . HttpServer can't start if hostname is not specified. Contributed by Jimmy Xiang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560450 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java

            People

            • Assignee:
              Jimmy Xiang
              Reporter:
              Jimmy Xiang
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development