Hadoop Common
  1. Hadoop Common
  2. HADOOP-10244

TestKeyShell improperly tests the results of a Delete

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: security
    • Labels:
      None
    • Release Note:
      Fix of inappropriate test of delete functionality.

      Description

      The TestKeyShell.testKeySuccessfulKeyLifecycle test is supposed to ensure that the deleted key is no longer in the results of a subsequent delete command. Mistakenly, it is testing that it is STILL there.

      The delete command is actually working but the stdout capture should be reset instead of flushed. Therefore, the test is picking up the existence of the key name from the deletion message in the previous command.

      1. 10244.patch
        3 kB
        Larry McCay

        Activity

        Larry McCay created issue -
        Hide
        Larry McCay added a comment -

        Fix TestKeyShell test.

        Show
        Larry McCay added a comment - Fix TestKeyShell test.
        Larry McCay made changes -
        Field Original Value New Value
        Attachment 10244.patch [ 12624011 ]
        Hide
        Larry McCay added a comment -

        Fix of inappropriate test of delete functionality. Changed the use of flush to reset and test that the deleted keyName is expected to NOT be in the list output after a delete.

        Show
        Larry McCay added a comment - Fix of inappropriate test of delete functionality. Changed the use of flush to reset and test that the deleted keyName is expected to NOT be in the list output after a delete.
        Larry McCay made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Release Note Fix of inappropriate test of delete functionality.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12624011/10244.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3448//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3448//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12624011/10244.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3448//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3448//console This message is automatically generated.
        Hide
        Owen O'Malley added a comment -

        I just committed this. Thanks, Larry!

        Show
        Owen O'Malley added a comment - I just committed this. Thanks, Larry!
        Owen O'Malley made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 3.0.0 [ 12320357 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #5100 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5100/)
        HADOOP-10244. TestKeyShell improperly tests the results of delete (Larry
        McCay via omalley) (omalley: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1564137)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestKeyShell.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5100 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5100/ ) HADOOP-10244 . TestKeyShell improperly tests the results of delete (Larry McCay via omalley) (omalley: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1564137 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestKeyShell.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #471 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/471/)
        HADOOP-10244. TestKeyShell improperly tests the results of delete (Larry
        McCay via omalley) (omalley: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1564137)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestKeyShell.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #471 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/471/ ) HADOOP-10244 . TestKeyShell improperly tests the results of delete (Larry McCay via omalley) (omalley: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1564137 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestKeyShell.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1688 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1688/)
        HADOOP-10244. TestKeyShell improperly tests the results of delete (Larry
        McCay via omalley) (omalley: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1564137)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestKeyShell.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1688 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1688/ ) HADOOP-10244 . TestKeyShell improperly tests the results of delete (Larry McCay via omalley) (omalley: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1564137 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestKeyShell.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1663 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1663/)
        HADOOP-10244. TestKeyShell improperly tests the results of delete (Larry
        McCay via omalley) (omalley: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1564137)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestKeyShell.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1663 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1663/ ) HADOOP-10244 . TestKeyShell improperly tests the results of delete (Larry McCay via omalley) (omalley: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1564137 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestKeyShell.java

          People

          • Assignee:
            Larry McCay
            Reporter:
            Larry McCay
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development