Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: HDFS ACLs (HDFS-4685)
    • Fix Version/s: HDFS ACLs (HDFS-4685)
    • Component/s: fs
    • Labels:
      None

      Description

      This patch will take a previously unused bit in the 16-bit FsPermission and use it to indicate the presence of an ACL on the file or directory. The CLI will use this to display an indicator in the permission string if an ACL is present. The NameNode will use it in ACL modification APIs, permission checks, and display of an indicator in the directory browser web UI.

        Issue Links

          Activity

          Hide
          Chris Nauroth added a comment -

          Summary of changes:

          1. Add ACL bit member to FsPermission. Add new constructor, bit twiddling and string parsing.
          2. Update TestFsPermission to fully cover new constructor, binary parsing and string parsing for the new ACL bit. While I was in here, I noticed that TestFsPermission#testFsPermission was not fully covering sticky bit handling, so I also added tests for that.
          3. RawLocalFileSystem previously had a special case to ignore the '+' ACL indicator when parsing results from a local file system that might have ACLs enabled. Now that we have an ACL bit, we don't need this special case.

          This patch is targeted for the HDFS-4685 feature branch, but it can apply cleanly to trunk, so I'm going to try submitting it for a Jenkins run.

          Show
          Chris Nauroth added a comment - Summary of changes: Add ACL bit member to FsPermission . Add new constructor, bit twiddling and string parsing. Update TestFsPermission to fully cover new constructor, binary parsing and string parsing for the new ACL bit. While I was in here, I noticed that TestFsPermission#testFsPermission was not fully covering sticky bit handling, so I also added tests for that. RawLocalFileSystem previously had a special case to ignore the '+' ACL indicator when parsing results from a local file system that might have ACLs enabled. Now that we have an ACL bit, we don't need this special case. This patch is targeted for the HDFS-4685 feature branch, but it can apply cleanly to trunk, so I'm going to try submitting it for a Jenkins run.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12622421/HADOOP-10220.1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3425//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3425//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12622421/HADOOP-10220.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3425//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3425//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good. Thanks, Chris.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good. Thanks, Chris.
          Hide
          Chris Nauroth added a comment -

          I committed this to the HDFS-4685 feature branch. Nicholas, thank you for the code review.

          Show
          Chris Nauroth added a comment - I committed this to the HDFS-4685 feature branch. Nicholas, thank you for the code review.

            People

            • Assignee:
              Chris Nauroth
              Reporter:
              Chris Nauroth
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development