Hadoop Common
  1. Hadoop Common
  2. HADOOP-10173

Remove UGI from DIGEST-MD5 SASL server creation

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 3.0.0, 2.3.0
    • Fix Version/s: 3.0.0, 2.3.0
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Target Version/s:

      Description

      Instantiation of SASL server instances within the readers threads is performed within a UGI.getCurrentUser().doAs. getCurrentUser is synchronized, and doAs also degrades performance. GSSAPI (kerberos) requires instantiation within a doAs, but DIGEST-MD5 (token) does not.

        Issue Links

          Activity

          Daryn Sharp created issue -
          Daryn Sharp made changes -
          Field Original Value New Value
          Link This issue relates to HADOOP-10172 [ HADOOP-10172 ]
          Daryn Sharp made changes -
          Link This issue is related to HADOOP-10174 [ HADOOP-10174 ]
          Hide
          Daryn Sharp added a comment -

          This jira will accelerate token auth, but not kerberos auth. HADOOP-10174 should eventually supersede this jira and accelerate both.

          Show
          Daryn Sharp added a comment - This jira will accelerate token auth, but not kerberos auth. HADOOP-10174 should eventually supersede this jira and accelerate both.
          Hide
          Daryn Sharp added a comment -

          Only use UGI.doAs for kerberos, not tokens. No tests because TestSaslRPC already proves the changes are sound.

          Show
          Daryn Sharp added a comment - Only use UGI.doAs for kerberos, not tokens. No tests because TestSaslRPC already proves the changes are sound.
          Daryn Sharp made changes -
          Attachment HADOOP-10173.patch [ 12619617 ]
          Daryn Sharp made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619617/HADOOP-10173.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3372//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3372//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619617/HADOOP-10173.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3372//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3372//console This message is automatically generated.
          Hide
          Kihwal Lee added a comment -

          +1 Looks straightforward.

          Show
          Kihwal Lee added a comment - +1 Looks straightforward.
          Hide
          Kihwal Lee added a comment -

          Thanks Daryn. I've committed this to trunk and branch-2.

          Show
          Kihwal Lee added a comment - Thanks Daryn. I've committed this to trunk and branch-2.
          Kihwal Lee made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 3.0.0 [ 12320357 ]
          Fix Version/s 2.4.0 [ 12324587 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #4947 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4947/)
          HADOOP-10173. Remove UGI from DIGEST-MD5 SASL server creation. Contributed by Daryn Sharp. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1554815)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcServer.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4947 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4947/ ) HADOOP-10173 . Remove UGI from DIGEST-MD5 SASL server creation. Contributed by Daryn Sharp. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1554815 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcServer.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #441 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/441/)
          HADOOP-10173. Remove UGI from DIGEST-MD5 SASL server creation. Contributed by Daryn Sharp. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1554815)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcServer.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #441 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/441/ ) HADOOP-10173 . Remove UGI from DIGEST-MD5 SASL server creation. Contributed by Daryn Sharp. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1554815 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcServer.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1633 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1633/)
          HADOOP-10173. Remove UGI from DIGEST-MD5 SASL server creation. Contributed by Daryn Sharp. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1554815)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcServer.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1633 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1633/ ) HADOOP-10173 . Remove UGI from DIGEST-MD5 SASL server creation. Contributed by Daryn Sharp. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1554815 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcServer.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1658 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1658/)
          HADOOP-10173. Remove UGI from DIGEST-MD5 SASL server creation. Contributed by Daryn Sharp. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1554815)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcServer.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1658 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1658/ ) HADOOP-10173 . Remove UGI from DIGEST-MD5 SASL server creation. Contributed by Daryn Sharp. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1554815 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcServer.java
          Arun C Murthy made changes -
          Affects Version/s 2.3.0 [ 12325254 ]
          Affects Version/s 2.4.0 [ 12324587 ]
          Fix Version/s 2.3.0 [ 12325254 ]
          Fix Version/s 2.4.0 [ 12324587 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development