Hadoop Common
  1. Hadoop Common
  2. HADOOP-10167

Mark hadoop-common source as UTF-8 in Maven pom files / refactoring

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.6-alpha
    • Fix Version/s: 2.3.0
    • Component/s: build
    • Labels:
    • Environment:

      Fedora 19 x86-64

      Description

      While looking at BIGTOP-831, turned out that the way Bigtop calls maven build / site:site generation causes the errors like this:

      [ERROR] Exit code: 1 - /home/user/jenkins/workspace/BigTop-RPM/label/centos-6-x86_64-HAD-1-buildbot/bigtop-repo/build/hadoop/rpm/BUILD/hadoop-2.0.2-alpha-src/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetricsInfo.java:31: error: unmappable character for encoding ANSI_X3.4-1968
      [ERROR] JvmMetrics("JVM related metrics etc."), // record info??

      Making the whole hadoop-common to use UTF-8 fixes that and seems in general good thing to me.

      Attaching first version of patch for review.

      Original issue was observed on openjdk 7 (x86-64).

      1. HADOOP-10167-1.patch
        3 kB
        Mikhail Antonov

        Issue Links

          Activity

          Hide
          Mikhail Antonov added a comment -

          First version of patch

          Show
          Mikhail Antonov added a comment - First version of patch
          Hide
          Steve Loughran added a comment -

          Seems good -I renamed the title to indicate its a source code attribute change, rather than just marking the POM XML as UTF-8.

          You are only patching a few of he POMs -is this because the rest already have the declaration?

          Show
          Steve Loughran added a comment - Seems good -I renamed the title to indicate its a source code attribute change, rather than just marking the POM XML as UTF-8. You are only patching a few of he POMs -is this because the rest already have the declaration?
          Hide
          Mikhail Antonov added a comment -

          Thanks for review!

          Currently, hadoop-main pom doesn't define encodings, but few of the subprojects do in their own POMs. Since there is probably no good reason for some of the other subprojects to not use UTF-8, I've actually added the encoding settings into hadoop-main POM (under hadoop-common), and removed from all other places.

          Show
          Mikhail Antonov added a comment - Thanks for review! Currently, hadoop-main pom doesn't define encodings, but few of the subprojects do in their own POMs. Since there is probably no good reason for some of the other subprojects to not use UTF-8, I've actually added the encoding settings into hadoop-main POM (under hadoop-common), and removed from all other places.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12618832/HADOOP-10167-1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-distcp hadoop-tools/hadoop-openstack.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3360//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3360//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618832/HADOOP-10167-1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-distcp hadoop-tools/hadoop-openstack. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3360//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3360//console This message is automatically generated.
          Hide
          Mikhail Antonov added a comment -

          On the hadoop-qa comment:

          Patch only includes POM files file encoding settings, so not new tests. The manual build passes on my machine (fedora 19/x86-64), but the tests on openjdk7 doesn't seem to work (all tests passed on the hadoop jenkins, as I see).

          Show
          Mikhail Antonov added a comment - On the hadoop-qa comment: Patch only includes POM files file encoding settings, so not new tests. The manual build passes on my machine (fedora 19/x86-64), but the tests on openjdk7 doesn't seem to work (all tests passed on the hadoop jenkins, as I see).
          Hide
          Mikhail Antonov added a comment -

          not => no new tests

          Show
          Mikhail Antonov added a comment - not => no new tests
          Hide
          Mikhail Antonov added a comment -

          Please let me know if there is anything I should improve in the patch or any other comments.

          Show
          Mikhail Antonov added a comment - Please let me know if there is anything I should improve in the patch or any other comments.
          Hide
          Konstantin Boudnik added a comment -

          Patch looks good - there was a line with trailing whitespaces that I've fixed for the same of time. Committing now.

          Show
          Konstantin Boudnik added a comment - Patch looks good - there was a line with trailing whitespaces that I've fixed for the same of time. Committing now.
          Hide
          Konstantin Boudnik added a comment -

          Committed to trunk, branch-2, branch-2.3
          Thank you Mikhail

          Show
          Konstantin Boudnik added a comment - Committed to trunk, branch-2, branch-2.3 Thank you Mikhail
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #5036 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5036/)
          HADOOP-10167. Mark hadoop-common source as UTF-8 in Maven pom files / refactoring. Contributed by Mikhail Antonov. (cos: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560831)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml
          • /hadoop/common/trunk/hadoop-project/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-openstack/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/pom.xml
          • /hadoop/common/trunk/pom.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5036 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5036/ ) HADOOP-10167 . Mark hadoop-common source as UTF-8 in Maven pom files / refactoring. Contributed by Mikhail Antonov. (cos: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560831 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml /hadoop/common/trunk/hadoop-project/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-openstack/pom.xml /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml /hadoop/common/trunk/hadoop-yarn-project/pom.xml /hadoop/common/trunk/pom.xml
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #461 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/461/)
          HADOOP-10167. Mark hadoop-common source as UTF-8 in Maven pom files / refactoring. Contributed by Mikhail Antonov. (cos: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560831)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml
          • /hadoop/common/trunk/hadoop-project/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-openstack/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/pom.xml
          • /hadoop/common/trunk/pom.xml
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #461 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/461/ ) HADOOP-10167 . Mark hadoop-common source as UTF-8 in Maven pom files / refactoring. Contributed by Mikhail Antonov. (cos: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560831 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml /hadoop/common/trunk/hadoop-project/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-openstack/pom.xml /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml /hadoop/common/trunk/hadoop-yarn-project/pom.xml /hadoop/common/trunk/pom.xml
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1678 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1678/)
          HADOOP-10167. Mark hadoop-common source as UTF-8 in Maven pom files / refactoring. Contributed by Mikhail Antonov. (cos: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560831)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml
          • /hadoop/common/trunk/hadoop-project/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-openstack/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/pom.xml
          • /hadoop/common/trunk/pom.xml
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1678 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1678/ ) HADOOP-10167 . Mark hadoop-common source as UTF-8 in Maven pom files / refactoring. Contributed by Mikhail Antonov. (cos: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560831 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml /hadoop/common/trunk/hadoop-project/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-openstack/pom.xml /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml /hadoop/common/trunk/hadoop-yarn-project/pom.xml /hadoop/common/trunk/pom.xml
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1653 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1653/)
          HADOOP-10167. Mark hadoop-common source as UTF-8 in Maven pom files / refactoring. Contributed by Mikhail Antonov. (cos: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560831)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml
          • /hadoop/common/trunk/hadoop-project/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-openstack/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/pom.xml
          • /hadoop/common/trunk/pom.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1653 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1653/ ) HADOOP-10167 . Mark hadoop-common source as UTF-8 in Maven pom files / refactoring. Contributed by Mikhail Antonov. (cos: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560831 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml /hadoop/common/trunk/hadoop-project/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-openstack/pom.xml /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml /hadoop/common/trunk/hadoop-yarn-project/pom.xml /hadoop/common/trunk/pom.xml

            People

            • Assignee:
              Mikhail Antonov
              Reporter:
              Mikhail Antonov
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development