[HADOOP-10146] Workaround JDK7 Process fd close bug

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.23.0, 2.0.0-alpha, 3.0.0-alpha1
• Fix Version/s: 0.23.11, 2.3.0
• Component/s: util
• Target Version/s: 0.23.11
• Hadoop Flags: Reviewed
• Assignee: Daryn Sharp
• Reporter: Daryn Sharp
• Created: 05/Dec/13 17:25
• Updated: 04/Jun/18 17:07
• Resolved: 16/Jan/14 18:58

Description

JDK7's Process output streams have an async fd-close race bug. This manifests as commands run via o.a.h.u.Shell causing threads to hang, OOM, or cause other bizarre behavior. The NM is likely to encounter the bug under heavy load.

Specifically, ProcessBuilder's UNIXProcess starts a thread to reap the process and drain stdout/stderr to avoid a lingering zombie process. A race occurs if the thread using the stream closes it, the underlying fd is recycled/reopened, while the reaper is draining it. ProcessPipeInputStream.drainInputStream's will OOM allocating an array if in.available() returns a huge number, or may wreak havoc by incorrectly draining the fd.

Issue Links

• breaks: HADOOP-10622 Shell.runCommand can deadlock
• is related to: HADOOP-15512 clean up Shell from JDK7 workarounds