Hadoop Common
  1. Hadoop Common
  2. HADOOP-10132

RPC#stopProxy() should log the class of proxy when IllegalArgumentException is encountered

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When investigating HBASE-10029, Tsz Wo Nicholas Sze made the suggestion of logging the class of proxy when IllegalArgumentException is thrown.

      1. hadoop-10132.txt
        0.7 kB
        Ted Yu
      2. hadoop-10132-v2.txt
        0.8 kB
        Ted Yu

        Activity

        Ted Yu created issue -
        Hide
        Jing Zhao added a comment -

        I think this jira should be moved to HADOOP?

        Show
        Jing Zhao added a comment - I think this jira should be moved to HADOOP?
        Jing Zhao made changes -
        Field Original Value New Value
        Project Hadoop HDFS [ 12310942 ] Hadoop Common [ 12310240 ]
        Key HDFS-5576 HADOOP-10132
        Ted Yu made changes -
        Attachment hadoop-10132.txt [ 12616090 ]
        Ted Yu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12616090/hadoop-10132.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3319//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3319//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12616090/hadoop-10132.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3319//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3319//console This message is automatically generated.
        Hide
        Uma Maheswara Rao G added a comment -

        May be use proxy.getClass.getName()? as you already included class= in the log message. Otherwise log will look like "RPC.stopProxy called on non proxy: class=class java.lang.Class"

        Show
        Uma Maheswara Rao G added a comment - May be use proxy.getClass.getName()? as you already included class= in the log message. Otherwise log will look like "RPC.stopProxy called on non proxy: class=class java.lang.Class"
        Hide
        Ted Yu added a comment -

        Patch v2 follows Uma's advice.

        Show
        Ted Yu added a comment - Patch v2 follows Uma's advice.
        Ted Yu made changes -
        Attachment hadoop-10132-v2.txt [ 12616105 ]
        Ted Yu made changes -
        Assignee Ted Yu [ yuzhihong@gmail.com ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12616105/hadoop-10132-v2.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3320//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3320//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12616105/hadoop-10132-v2.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3320//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3320//console This message is automatically generated.
        Hide
        Uma Maheswara Rao G added a comment -

        +1

        Show
        Uma Maheswara Rao G added a comment - +1
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks a lot, Ted for the patch. I have just committed this to trunk, branhc-2 and 2.2.

        Show
        Uma Maheswara Rao G added a comment - Thanks a lot, Ted for the patch. I have just committed this to trunk, branhc-2 and 2.2.
        Uma Maheswara Rao G made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 3.0.0 [ 12320357 ]
        Fix Version/s 2.3.0 [ 12324587 ]
        Fix Version/s 2.2.1 [ 12325254 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #4803 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4803/)
        HADOOP-10132. RPC#stopProxy() should log the class of proxy when IllegalArgumentException is encountered. Contributed by Ted Yu (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1546192)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4803 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4803/ ) HADOOP-10132 . RPC#stopProxy() should log the class of proxy when IllegalArgumentException is encountered. Contributed by Ted Yu (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1546192 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #405 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/405/)
        HADOOP-10132. RPC#stopProxy() should log the class of proxy when IllegalArgumentException is encountered. Contributed by Ted Yu (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1546192)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #405 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/405/ ) HADOOP-10132 . RPC#stopProxy() should log the class of proxy when IllegalArgumentException is encountered. Contributed by Ted Yu (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1546192 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1622 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1622/)
        HADOOP-10132. RPC#stopProxy() should log the class of proxy when IllegalArgumentException is encountered. Contributed by Ted Yu (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1546192)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1622 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1622/ ) HADOOP-10132 . RPC#stopProxy() should log the class of proxy when IllegalArgumentException is encountered. Contributed by Ted Yu (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1546192 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1596 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1596/)
        HADOOP-10132. RPC#stopProxy() should log the class of proxy when IllegalArgumentException is encountered. Contributed by Ted Yu (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1546192)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1596 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1596/ ) HADOOP-10132 . RPC#stopProxy() should log the class of proxy when IllegalArgumentException is encountered. Contributed by Ted Yu (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1546192 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Arun C Murthy made changes -
        Fix Version/s 2.4.0 [ 12324587 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Allen Wittenauer made changes -
        Fix Version/s 3.0.0 [ 12320357 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1h 11m 1 Ted Yu 27/Nov/13 18:44
        Patch Available Patch Available Resolved Resolved
        2h 16m 1 Uma Maheswara Rao G 27/Nov/13 21:00
        Resolved Resolved Closed Closed
        88d 23h 57m 1 Arun C Murthy 24/Feb/14 20:57

          People

          • Assignee:
            Ted Yu
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development