[HADOOP-10116] fix "inconsistent synchronization" warnings in ZlibCompressor

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Assignee: Unassigned
• Reporter: Colin McCabe
• Created: 19/Nov/13 20:21
• Updated: 16/Apr/15 19:04
• Resolved: 16/Apr/15 19:04

Description

Fix findbugs warnings in ZlibCompressor. I believe these were introduced by HADOOP-10047.

Code	Warning
IS	Inconsistent synchronization of org.apache.hadoop.io.compress.zlib.ZlibCompressor.keepUncompressedBuf; locked 57% of time
IS	Inconsistent synchronization of org.apache.hadoop.io.compress.zlib.ZlibCompressor.userBuf; locked 60% of time
IS	Inconsistent synchronization of org.apache.hadoop.io.compress.zlib.ZlibCompressor.userBufLen; locked 85% of time
IS	Inconsistent synchronization of org.apache.hadoop.io.compress.zlib.ZlibDecompressor.userBuf; locked 60% of time
IS	Inconsistent synchronization of org.apache.hadoop.io.compress.zlib.ZlibDecompressor.userBufLen; locked 77% of time
Dodgy Warnings

Code	Warning
DLS	Dead store to pos2 in org.apache.hadoop.io.compress.zlib.ZlibCompressor.put(ByteBuffer, ByteBuffer)
DLS	Dead store to pos2 in org.apache.hadoop.io.compress.zlib.ZlibDecompressor.put(ByteBuffer, ByteBuffer)

Issue Links

• duplicates: HADOOP-10681 Remove synchronized blocks from SnappyCodec and ZlibCodec buffering inner loop
• relates to: HADOOP-10047 Add a directbuffer Decompressor API to hadoop