Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.0
    • Fix Version/s: 2.3.0
    • Component/s: build
    • Labels:
      None
    • Target Version/s:

      Description

      update commons-lang from 2.5 to 2.6

      1. HADOOP-10103.patch
        0.4 kB
        Akira Ajisaka

        Activity

        Hide
        ajisakaa Akira Ajisaka added a comment -

        Attaching a patch to fix pom.xml.
        Steve Loughran, is there anything to do for updating jar except editing pom?

        Show
        ajisakaa Akira Ajisaka added a comment - Attaching a patch to fix pom.xml. Steve Loughran , is there anything to do for updating jar except editing pom?
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12614588/HADOOP-10103.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3298//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3298//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614588/HADOOP-10103.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3298//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3298//console This message is automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Akira,

        1. review the changes and see if there are any changes that require action
        2. run is a complete buld and test of Hadoop, including HDFS & YARN -Jenkins doesn't do that for a change to hadoop-common.
        Show
        stevel@apache.org Steve Loughran added a comment - Akira, review the changes and see if there are any changes that require action run is a complete buld and test of Hadoop, including HDFS & YARN -Jenkins doesn't do that for a change to hadoop-common.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks!

        review the changes and see if there are any changes that require action

        Lang 2.6 is binary compatible release with Lang 2.5.
        http://commons.apache.org/proper/commons-lang/release-notes/RELEASE-NOTES-2.6.txt
        There is no need to action.

        run is a complete buld and test of Hadoop, including HDFS & YARN -Jenkins doesn't do that for a change to hadoop-common.

        I built with the patch. I'll run complete test.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks! review the changes and see if there are any changes that require action Lang 2.6 is binary compatible release with Lang 2.5. http://commons.apache.org/proper/commons-lang/release-notes/RELEASE-NOTES-2.6.txt There is no need to action. run is a complete buld and test of Hadoop, including HDFS & YARN -Jenkins doesn't do that for a change to hadoop-common. I built with the patch. I'll run complete test.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        There's a trick to getting jenkins to run the tests for you: submit the same patch to HDFS, YARN, MAPREDUCE: see HADOOP-10101

        I'm explicitly doing that where there are code changes, otherwise just running the tests locally

        Show
        stevel@apache.org Steve Loughran added a comment - There's a trick to getting jenkins to run the tests for you: submit the same patch to HDFS, YARN, MAPREDUCE: see HADOOP-10101 I'm explicitly doing that where there are code changes, otherwise just running the tests locally
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thank you for sharing!
        If there is a need to change the code, I'll use the trick. I'm running the tests locally.

        Show
        ajisakaa Akira Ajisaka added a comment - Thank you for sharing! If there is a need to change the code, I'll use the trick. I'm running the tests locally.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        I confirmed all the unit tests passed except TestRMContainerAllocator, which is already reported at MAPREDUCE-5427 and MAPREDUCE-5632.

        Show
        ajisakaa Akira Ajisaka added a comment - I confirmed all the unit tests passed except TestRMContainerAllocator, which is already reported at MAPREDUCE-5427 and MAPREDUCE-5632 .
        Hide
        stevel@apache.org Steve Loughran added a comment -

        link to HADOOP-9991

        Show
        stevel@apache.org Steve Loughran added a comment - link to HADOOP-9991
        Hide
        stevel@apache.org Steve Loughran added a comment -

        +1, fixed in branch-2

        Thanks, and thanks for helping with this slow and painful dependency update work

        Show
        stevel@apache.org Steve Loughran added a comment - +1, fixed in branch-2 Thanks, and thanks for helping with this slow and painful dependency update work
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #4776 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4776/)
        HADOOP-10103 commons-lang->2.6 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1544174)

        • /hadoop/common/trunk
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-project/pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4776 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4776/ ) HADOOP-10103 commons-lang->2.6 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1544174 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #399 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/399/)
        HADOOP-10103 commons-lang->2.6 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1544174)

        • /hadoop/common/trunk
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-project/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #399 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/399/ ) HADOOP-10103 commons-lang->2.6 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1544174 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #1590 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1590/)
        HADOOP-10103 commons-lang->2.6 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1544174)

        • /hadoop/common/trunk
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-project/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1590 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1590/ ) HADOOP-10103 commons-lang->2.6 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1544174 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1616 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1616/)
        HADOOP-10103 commons-lang->2.6 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1544174)

        • /hadoop/common/trunk
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-project/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1616 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1616/ ) HADOOP-10103 commons-lang->2.6 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1544174 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml

          People

          • Assignee:
            ajisakaa Akira Ajisaka
            Reporter:
            stevel@apache.org Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development