Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.3.0
    • Component/s: build
    • Labels:
      None
    • Target Version/s:

      Description

      commons IO is at v2.4, release notes: http://commons.apache.org/proper/commons-io/upgradeto2_4.html

      One change is marked as source & semantically incompatible with 2.2: IO-318

      1. HADOOP-10102.patch
        0.4 kB
        Akira AJISAKA

        Activity

        Hide
        Akira AJISAKA added a comment -

        At IO-318,

        If you somehow relied on catching the checked UnsupportedEncodingException instead of IOException, its superclass, you should catch the unchecked java.nio.charset.UnsupportedCharsetException to act on the fact that the charset is not available.

        I searched the source-codes catching UnsupportedEncodingException and all of them looks unrelated to the methods of commons IO.
        I'll build and run all the unit tests with commons IO 2.4.

        Show
        Akira AJISAKA added a comment - At IO-318 , If you somehow relied on catching the checked UnsupportedEncodingException instead of IOException, its superclass, you should catch the unchecked java.nio.charset.UnsupportedCharsetException to act on the fact that the charset is not available. I searched the source-codes catching UnsupportedEncodingException and all of them looks unrelated to the methods of commons IO. I'll build and run all the unit tests with commons IO 2.4.
        Hide
        Akira AJISAKA added a comment -

        Attaching a patch.

        Show
        Akira AJISAKA added a comment - Attaching a patch.
        Hide
        Akira AJISAKA added a comment -

        I built and confirmed almost all of the unit tests passed with the patch.
        The failed tests are as follows:

        • TestCacheDirectives and TestFsDatasetCache reported at HDFS-5562
        • TestRMContainerAllocator reported at MAPREDUCE-5632
        • TestUnmanagedAMLauncher reported at YARN-1450

        These tests fail on trunk also.

        Show
        Akira AJISAKA added a comment - I built and confirmed almost all of the unit tests passed with the patch. The failed tests are as follows: TestCacheDirectives and TestFsDatasetCache reported at HDFS-5562 TestRMContainerAllocator reported at MAPREDUCE-5632 TestUnmanagedAMLauncher reported at YARN-1450 These tests fail on trunk also.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12615314/HADOOP-10102.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3315//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3315//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615314/HADOOP-10102.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3315//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3315//console This message is automatically generated.
        Hide
        Steve Loughran added a comment -

        +1, committed, thanks!

        Show
        Steve Loughran added a comment - +1, committed, thanks!
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #4824 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4824/)
        HADOOP-10102. Update commons IO from 2.1 to 2.4 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547759)

        • /hadoop/common/trunk
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-project/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4824 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4824/ ) HADOOP-10102 . Update commons IO from 2.1 to 2.4 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547759 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1628 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1628/)
        HADOOP-10102. Update commons IO from 2.1 to 2.4 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547759)

        • /hadoop/common/trunk
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-project/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1628 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1628/ ) HADOOP-10102 . Update commons IO from 2.1 to 2.4 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547759 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1602 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1602/)
        HADOOP-10102. Update commons IO from 2.1 to 2.4 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547759)

        • /hadoop/common/trunk
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-project/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1602 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1602/ ) HADOOP-10102 . Update commons IO from 2.1 to 2.4 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547759 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #412 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/412/)
        HADOOP-10102. Update commons IO from 2.1 to 2.4 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547759)

        • /hadoop/common/trunk
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-project/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #412 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/412/ ) HADOOP-10102 . Update commons IO from 2.1 to 2.4 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547759 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml

          People

          • Assignee:
            Akira AJISAKA
            Reporter:
            Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development