Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.2.0, 2.6.0
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      Jetty6 is no longer maintained. Update the dependency to jetty9.

      1. HADOOP-10075_addendum.001.patch
        1 kB
        Robert Kanter
      2. HADOOP-10075_addendum.002.patch
        2 kB
        Robert Kanter
      3. HADOOP-10075_addendum.003.patch
        2 kB
        Robert Kanter
      4. HADOOP-10075_addendum.004.patch
        2 kB
        Robert Kanter
      5. HADOOP-10075.003.patch
        713 kB
        Robert Kanter
      6. HADOOP-10075.004.patch
        1.05 MB
        Robert Kanter
      7. HADOOP-10075.005.patch
        1.25 MB
        Robert Kanter
      8. HADOOP-10075.006.patch
        1.27 MB
        Robert Kanter
      9. HADOOP-10075.007.patch
        1.27 MB
        Robert Kanter
      10. HADOOP-10075.008.patch
        1.27 MB
        Robert Kanter
      11. HADOOP-10075.009.patch
        1.29 MB
        Robert Kanter
      12. HADOOP-10075.010.patch
        1.30 MB
        Robert Kanter
      13. HADOOP-10075.011.patch
        1.32 MB
        Robert Kanter
      14. HADOOP-10075.patch
        100 kB
        Robert Rati
      15. HADOOP-10075-002-wip.patch
        18 kB
        Tsuyoshi Ozawa

        Issue Links

          Activity

          Hide
          Robert Rati added a comment -

          This patch brings the source from 6->9. There is a different jira (https://issues.apache.org/jira/browse/HADOOP-9650) for updating to jetty8. If that patch is accepted, this will need to be updated to address moving from 8->9.

          This patch uses glassfish in combination with jetty9 for jsp compilation.

          Show
          Robert Rati added a comment - This patch brings the source from 6->9. There is a different jira ( https://issues.apache.org/jira/browse/HADOOP-9650 ) for updating to jetty8. If that patch is accepted, this will need to be updated to address moving from 8->9. This patch uses glassfish in combination with jetty9 for jsp compilation.
          Hide
          Colin P. McCabe added a comment -

          be sure to hit "submit patch" so that you will get a jenkins run on this.

          Show
          Colin P. McCabe added a comment - be sure to hit "submit patch" so that you will get a jenkins run on this.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12610564/HADOOP-10075.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3303//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12610564/HADOOP-10075.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3303//console This message is automatically generated.
          Hide
          Colin P. McCabe added a comment -

          Thanks for looking at this. I think you will need to re-generate the patch, since it failed to apply on jenkins.

          --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestSSLHttpServer.java
          +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestSSLHttpServer.java
          @@ -76,6 +76,7 @@ public void setup() throws Exception {
           
               conf.setInt(HttpServer.HTTP_MAX_THREADS, 10);
               conf.addResource(CONFIG_SITE_XML);
          +    conf.addResource(conf.get("hadoop.ssl.server.conf","ssl-server.xml"));
               server = createServer("test", conf);
               server.addServlet("echo", "/echo", TestHttpServer.EchoServlet.class);
               server.start();
          

          Why do we need this addition?

          -        InetAddress.getByName(server.getConnectors()[0].getHost());
          -      int port = server.getConnectors()[0].getPort();
          +        InetAddress.getByName(((ServerConnector)server.getConnectors()[0]).getHost());
          +      int port = ((ServerConnector)server.getConnectors()[0]).getPort();
          

          I see a lot of new typecasts like this. Is it possible to avoid these? If not, could we have an accessor function that makes this easier to read? Thanks.

          Show
          Colin P. McCabe added a comment - Thanks for looking at this. I think you will need to re-generate the patch, since it failed to apply on jenkins. --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestSSLHttpServer.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestSSLHttpServer.java @@ -76,6 +76,7 @@ public void setup() throws Exception { conf.setInt(HttpServer.HTTP_MAX_THREADS, 10); conf.addResource(CONFIG_SITE_XML); + conf.addResource(conf.get( "hadoop.ssl.server.conf" , "ssl-server.xml" )); server = createServer( "test" , conf); server.addServlet( "echo" , "/echo" , TestHttpServer.EchoServlet.class); server.start(); Why do we need this addition? - InetAddress.getByName(server.getConnectors()[0].getHost()); - int port = server.getConnectors()[0].getPort(); + InetAddress.getByName(((ServerConnector)server.getConnectors()[0]).getHost()); + int port = ((ServerConnector)server.getConnectors()[0]).getPort(); I see a lot of new typecasts like this. Is it possible to avoid these? If not, could we have an accessor function that makes this easier to read? Thanks.
          Hide
          Robert Rati added a comment -

          The patch applies cleanly against branch-2.2.0. Which branch should I target? branch-2.2? The nature of these changes will probably result in the patch failing to apply pretty consistently as development continues until/less it makes it into a source mainline.

          conf.addResource(conf.get("hadoop.ssl.server.conf","ssl-server.xml"));
          was needed for tests to succeed on Fedora. Jetty 8 revamped the ssl configuration and this change was part of that for the test to pass.

          Jetty 9 completely revamped Connector and related classes and casts such as:
          (ServerConnector)server.getConnectors()[0])
          was the only way I could see to get at the needed data. If there's a cleaner way I'm all for it.

          Show
          Robert Rati added a comment - The patch applies cleanly against branch-2.2.0. Which branch should I target? branch-2.2? The nature of these changes will probably result in the patch failing to apply pretty consistently as development continues until/less it makes it into a source mainline. conf.addResource(conf.get("hadoop.ssl.server.conf","ssl-server.xml")); was needed for tests to succeed on Fedora. Jetty 8 revamped the ssl configuration and this change was part of that for the test to pass. Jetty 9 completely revamped Connector and related classes and casts such as: (ServerConnector)server.getConnectors() [0] ) was the only way I could see to get at the needed data. If there's a cleaner way I'm all for it.
          Hide
          Colin P. McCabe added a comment -

          Please target trunk, as we do for (almost) all upstream patches. Then we will backport it into stable branches as is appropriate.

          Jetty 8 revamped the ssl configuration and [conf.addResource] was part of that for the test to pass.

          OK.

          Can you be a little more clear about why the typecasts are needed? What other kinds of connectors might be returned by server#getConnectors? Have you considered making a utility routine to do this typecast?

          Note that in general, nothing can be committed without a clean jenkins run. There's more information here: http://wiki.apache.org/hadoop/HowToContribute

          Show
          Colin P. McCabe added a comment - Please target trunk, as we do for (almost) all upstream patches. Then we will backport it into stable branches as is appropriate. Jetty 8 revamped the ssl configuration and [conf.addResource] was part of that for the test to pass. OK. Can you be a little more clear about why the typecasts are needed? What other kinds of connectors might be returned by server#getConnectors ? Have you considered making a utility routine to do this typecast? Note that in general, nothing can be committed without a clean jenkins run. There's more information here: http://wiki.apache.org/hadoop/HowToContribute
          Hide
          Robert Rati added a comment -

          Jetty 9 redid the Connector interface and set of classes. The Connector interface no longer contains any network related methods and those are now in the NetworkConnector interface, which extends the Connector interface.

          server#getConnectors still returns an array of Connectors, but obviously those Connectors no longer have any networking data so I needed to cast to something that does. It might be better to cast to NetworkConnector instead of ServerConnector though.

          I have no problem creating a utility routine if that would make things more readable. I'd prefer to batch any requested changes into a single update if possible. Any other concerns?

          Show
          Robert Rati added a comment - Jetty 9 redid the Connector interface and set of classes. The Connector interface no longer contains any network related methods and those are now in the NetworkConnector interface, which extends the Connector interface. server#getConnectors still returns an array of Connectors, but obviously those Connectors no longer have any networking data so I needed to cast to something that does. It might be better to cast to NetworkConnector instead of ServerConnector though. I have no problem creating a utility routine if that would make things more readable. I'd prefer to batch any requested changes into a single update if possible. Any other concerns?
          Hide
          Colin P. McCabe added a comment -

          it looks fine aside from the things I mentioned.

          Show
          Colin P. McCabe added a comment - it looks fine aside from the things I mentioned.
          Hide
          Colin P. McCabe added a comment -

          Another thing: will this break HBase, which is currently using some of our jetty stuff?

          Show
          Colin P. McCabe added a comment - Another thing: will this break HBase, which is currently using some of our jetty stuff?
          Hide
          Liang Xie added a comment -

          Hi stack, could you invite some guys to double-check Colin P. McCabe's last comments? I'd like to help when i read but i am not familiar this area

          Show
          Liang Xie added a comment - Hi stack , could you invite some guys to double-check Colin P. McCabe 's last comments? I'd like to help when i read but i am not familiar this area
          Hide
          Robert Rati added a comment -

          Yes, HBase will need to change to jetty 9 as well. I'm working on HBase and will be providing a patch to them when done. The change needed for HBase to interact with Hadoop using jetty9 is pretty minor from the work I've done so far. Iiirc, it's a returned variable type change from a call into hadoop (Connector class issue again).

          Show
          Robert Rati added a comment - Yes, HBase will need to change to jetty 9 as well. I'm working on HBase and will be providing a patch to them when done. The change needed for HBase to interact with Hadoop using jetty9 is pretty minor from the work I've done so far. Iiirc, it's a returned variable type change from a call into hadoop (Connector class issue again).
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12610564/HADOOP-10075.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3828//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12610564/HADOOP-10075.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3828//console This message is automatically generated.
          Hide
          Demai Ni added a comment -

          Robert Rati, do you have a hbase jira/patch available? Thanks... Demai

          Show
          Demai Ni added a comment - Robert Rati , do you have a hbase jira/patch available? Thanks... Demai
          Hide
          Jinghui Wang added a comment -

          I am running some unit tests with the attached patch applied and started seeing errors in many httpserver related UTs:
          java.lang.SecurityException: Signers of 'javax.servlet.HttpConstraintElement' do not match signers of other classes in package

          After find going through maven dependency tree, I found that both javax.servlet:servlet-api and org.eclipse.jetty.orbit:javax.servlet (through jetty-server) are included on the classpath. Wondering if I am missing something or the patch has not been tested with Hadoop unit tests yet.

          maven dependency output:

          [INFO] +- javax.servlet:servlet-api:jar:3.0-alpha-1:compile
          [INFO] | +- org.eclipse.jetty.orbit:javax.servlet:jar:3.0.0.v201112011016:compile
          [INFO] +- org.eclipse.jetty:jetty-servlet:jar:9.0.4.v20130625:compile
          [INFO] | - (org.eclipse.jetty:jetty-servlet:jar:9.0.4.v20130625:compile - omitted for duplicate)
          [INFO] +- org.glassfish.web:javax.servlet.jsp:jar:2.2.6:compile
          [INFO] | - javax.servlet.jsp:javax.servlet.jsp-api:jar:2.2.1:compile
          [INFO] +- org.apache.tomcat:tomcat-servlet-api:jar:7.0.37:compile
          [INFO] | +- (javax.servlet:servlet-api:jar:3.0-alpha-1:provided - omitted for duplicate)
          [INFO] | | +- org.eclipse.jetty.orbit:javax.servlet:jar:3.0.0.v201112011016:provided
          [INFO] | +- org.eclipse.jetty:jetty-servlet:jar:9.0.4.v20130625:provided
          [INFO] | | - (org.eclipse.jetty:jetty-servlet:jar:9.0.4.v20130625:provided - omitted for duplicate)
          [INFO] | +- org.glassfish.web:javax.servlet.jsp:jar:2.2.6:provided
          [INFO] | | - javax.servlet.jsp:javax.servlet.jsp-api:jar:2.2.1:provided
          [INFO] | +- org.apache.tomcat:tomcat-servlet-api:jar:7.0.37:provided
          [INFO] +- javax.servlet:servlet-api:jar:3.0-alpha-1:provided

          Show
          Jinghui Wang added a comment - I am running some unit tests with the attached patch applied and started seeing errors in many httpserver related UTs: java.lang.SecurityException: Signers of 'javax.servlet.HttpConstraintElement' do not match signers of other classes in package After find going through maven dependency tree, I found that both javax.servlet:servlet-api and org.eclipse.jetty.orbit:javax.servlet (through jetty-server) are included on the classpath. Wondering if I am missing something or the patch has not been tested with Hadoop unit tests yet. maven dependency output: [INFO] +- javax.servlet:servlet-api:jar:3.0-alpha-1:compile [INFO] | +- org.eclipse.jetty.orbit:javax.servlet:jar:3.0.0.v201112011016:compile [INFO] +- org.eclipse.jetty:jetty-servlet:jar:9.0.4.v20130625:compile [INFO] | - (org.eclipse.jetty:jetty-servlet:jar:9.0.4.v20130625:compile - omitted for duplicate) [INFO] +- org.glassfish.web:javax.servlet.jsp:jar:2.2.6:compile [INFO] | - javax.servlet.jsp:javax.servlet.jsp-api:jar:2.2.1:compile [INFO] +- org.apache.tomcat:tomcat-servlet-api:jar:7.0.37:compile [INFO] | +- (javax.servlet:servlet-api:jar:3.0-alpha-1:provided - omitted for duplicate) [INFO] | | +- org.eclipse.jetty.orbit:javax.servlet:jar:3.0.0.v201112011016:provided [INFO] | +- org.eclipse.jetty:jetty-servlet:jar:9.0.4.v20130625:provided [INFO] | | - (org.eclipse.jetty:jetty-servlet:jar:9.0.4.v20130625:provided - omitted for duplicate) [INFO] | +- org.glassfish.web:javax.servlet.jsp:jar:2.2.6:provided [INFO] | | - javax.servlet.jsp:javax.servlet.jsp-api:jar:2.2.1:provided [INFO] | +- org.apache.tomcat:tomcat-servlet-api:jar:7.0.37:provided [INFO] +- javax.servlet:servlet-api:jar:3.0-alpha-1:provided
          Hide
          Steve Loughran added a comment -

          IMO we'd be better off moving out of Jetty and into jersey as the server; this would eliminate jersey version problems altogether, and more importantly, jersey "quirks"

          Show
          Steve Loughran added a comment - IMO we'd be better off moving out of Jetty and into jersey as the server; this would eliminate jersey version problems altogether, and more importantly, jersey "quirks"
          Hide
          Ravi Prakash added a comment -

          Hi folks! What's the status of this patch? It doesn't seem to apply on trunk. The desire to move to jersey shouldn't have blocked this patch. We can port over the server code to jersey even if we started using Jetty-9.

          Show
          Ravi Prakash added a comment - Hi folks! What's the status of this patch? It doesn't seem to apply on trunk. The desire to move to jersey shouldn't have blocked this patch. We can port over the server code to jersey even if we started using Jetty-9.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12610564/HADOOP-10075.patch
          against trunk revision 9850e15.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5525//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12610564/HADOOP-10075.patch against trunk revision 9850e15. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5525//console This message is automatically generated.
          Hide
          Tsuyoshi Ozawa added a comment -

          Cancelling a patch since the patch looks stale. I think it's good timing to upgrade the version of jetty because http/2 is supported on jetty 9.3.0: https://projects.eclipse.org/projects/rt.jetty/reviews/9.3.0-release-review

          Show
          Tsuyoshi Ozawa added a comment - Cancelling a patch since the patch looks stale. I think it's good timing to upgrade the version of jetty because http/2 is supported on jetty 9.3.0: https://projects.eclipse.org/projects/rt.jetty/reviews/9.3.0-release-review
          Hide
          Tsuyoshi Ozawa added a comment -

          Uploading WIP patch for pom.xml of trunk. A previous patch includes changes against HttpServer, not against HttpServer2, so we need to change the point.

          Show
          Tsuyoshi Ozawa added a comment - Uploading WIP patch for pom.xml of trunk. A previous patch includes changes against HttpServer, not against HttpServer2, so we need to change the point.
          Hide
          Tsuyoshi Ozawa added a comment -

          Robert Rati, could you help us to create a patch for trunk?

          Show
          Tsuyoshi Ozawa added a comment - Robert Rati , could you help us to create a patch for trunk?
          Hide
          Robert Kanter added a comment -

          I'm going to pick this up and get it moving forward again, unless anyone has any objections?

          Jetty 6 was EoL in 2010 (6 years ago!), so we should really do this. Hadoop 3 is a great opportunity to finally get this done. I agree with Ravi Prakash: even if we later move to Jersey, that doesn't need to block upgrading Jetty.

          I've started looking into the code, and I think it will be doable, just a little tedious to refactor things like HttpServer2 to the Jetty 9 APIs.

          Show
          Robert Kanter added a comment - I'm going to pick this up and get it moving forward again, unless anyone has any objections? Jetty 6 was EoL in 2010 (6 years ago!), so we should really do this. Hadoop 3 is a great opportunity to finally get this done. I agree with Ravi Prakash : even if we later move to Jersey, that doesn't need to block upgrading Jetty. I've started looking into the code, and I think it will be doable, just a little tedious to refactor things like HttpServer2 to the Jetty 9 APIs.
          Hide
          Tsuyoshi Ozawa added a comment -

          Robert Kanter I think it's okay to upgrade at server side, but I don't know we can do so at client-side. Please check HADOOP-13070.

          Show
          Tsuyoshi Ozawa added a comment - Robert Kanter I think it's okay to upgrade at server side, but I don't know we can do so at client-side. Please check HADOOP-13070 .
          Hide
          Tsuyoshi Ozawa added a comment - - edited

          Robert Kanter I looked over the result of grep -r jetty --include="*.java": it's used only in server-side excluding tests, so we can upgrade jetty with minimum pain on branch-3

          Show
          Tsuyoshi Ozawa added a comment - - edited Robert Kanter I looked over the result of grep -r jetty --include="*.java": it's used only in server-side excluding tests, so we can upgrade jetty with minimum pain on branch-3
          Hide
          Steve Loughran added a comment -

          I think it may get picked up downstream by things, which is why I was arguing for a move to Jersey instead. That way hadoop doesn't need to worry about downstream jetty use and version problems —only jersey ones

          Show
          Steve Loughran added a comment - I think it may get picked up downstream by things, which is why I was arguing for a move to Jersey instead. That way hadoop doesn't need to worry about downstream jetty use and version problems —only jersey ones
          Hide
          Robert Kanter added a comment -

          Isn't that one of the benefits of a new major version? With Hadoop 3, we should be (finally) able to upgrade Jetty, right? If a downstream component has a conflict here, then they can continue using Hadoop 2.x until they're ready to upgrade from Jetty 6 to 9 as well. Even if we replace Jetty with Jersey, that could still interfere with a downstream component using a different version of Jersey.

          Show
          Robert Kanter added a comment - Isn't that one of the benefits of a new major version? With Hadoop 3, we should be (finally) able to upgrade Jetty, right? If a downstream component has a conflict here, then they can continue using Hadoop 2.x until they're ready to upgrade from Jetty 6 to 9 as well. Even if we replace Jetty with Jersey, that could still interfere with a downstream component using a different version of Jersey.
          Hide
          Ravi Prakash added a comment -

          IMO we'd be better off moving out of Jetty and into jersey as the server; this would eliminate jersey version problems altogether, and more importantly, jersey "quirks"

          For those of us less familiar with Jersey, could you please elaborate on this Steve? Or did you mean "this would eliminate jetty version problems altogether" ? Or does Jersey promise never to change its API ever?

          In any case we can always make that happen later, so we shouldn't block the upgrade of an old and crufty Jetty if someone wants to do it.

          Show
          Ravi Prakash added a comment - IMO we'd be better off moving out of Jetty and into jersey as the server; this would eliminate jersey version problems altogether, and more importantly, jersey "quirks" For those of us less familiar with Jersey, could you please elaborate on this Steve? Or did you mean "this would eliminate jetty version problems altogether" ? Or does Jersey promise never to change its API ever? In any case we can always make that happen later, so we shouldn't block the upgrade of an old and crufty Jetty if someone wants to do it.
          Hide
          Steve Loughran added a comment -

          Jersey has been great to work with: the first embedded servlet engine. It did have problems, ones we had got familiar with (DNs used to have to probe on startup to see if jersey was actually serving requests, if it hadn't started properly they'd terminate). Things like that kept us on an old jetty version for a long time.

          Show
          Steve Loughran added a comment - Jersey has been great to work with: the first embedded servlet engine. It did have problems, ones we had got familiar with (DNs used to have to probe on startup to see if jersey was actually serving requests, if it hadn't started properly they'd terminate). Things like that kept us on an old jetty version for a long time.
          Hide
          Robert Kanter added a comment -

          Posted a 003 patch. Here's some notes on it:

          1. The bulk of the changes are in HttpServer2 and pom files
          2. There's a lot of misc changes in other files all over the place because package names and class names/usage were changed slightly.
          3. I verified that https works.
          4. I had a lot of trouble with the gzipped javascript files we have. I tried a lot of different configurations and looking around online. From what I can tell by looking at the Jetty code and using a debugger, it looks like Jetty won't serve .gz files unless the non-gz version is there. They have checks that the non-gz file exists before checking for the .gz file:
            https://github.com/eclipse/jetty.project/blob/jetty-9.3.x/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceCache.java#L235
            https://github.com/eclipse/jetty.project/blob/jetty-9.3.x/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceContentFactory.java#L63
            Unfortunately, this means having both the gz and non-gz versions of the files (which is one of the reasons why the patch is so big). I did verify that if the request says it accepts gzip, you'll get the smaller gzipped version of the file:
            >> curl 'http://localhost:8088/static/jquery/jquery-1.8.2.min.js' --compressed -s -D - -o /dev/null
            HTTP/1.1 200 OK
            Date: Wed, 14 Sep 2016 20:46:50 GMT
            Vary: Accept-Encoding
            Last-Modified: Wed, 14 Sep 2016 18:58:48 GMT
            Content-Type: application/javascript
            Content-Encoding: gzip
            Accept-Ranges: bytes
            Content-Length: 33430
            Server: Jetty(9.3.11.v20160721)
            
            >> curl 'http://localhost:8088/static/jquery/jquery-1.8.2.min.js' -s -D - -o /dev/null
            HTTP/1.1 200 OK
            Date: Wed, 14 Sep 2016 20:46:51 GMT
            Vary: Accept-Encoding
            Last-Modified: Wed, 14 Sep 2016 18:58:48 GMT
            Content-Type: application/javascript
            Accept-Ranges: bytes
            Content-Length: 93436
            Server: Jetty(9.3.11.v20160721)
            

            If anyone has any better ideas on how to get gz to work without the extra files, let me know and I'll change it. That said, we're probably supposed to have both the gz and non-gz files so that we can serve the non-gz files if the browser doesn't support gz; otherwise, you get 404s instead. So perhaps this is the correct thing to do anyway, and we had it wrong before.

          Show
          Robert Kanter added a comment - Posted a 003 patch. Here's some notes on it: The bulk of the changes are in HttpServer2 and pom files There's a lot of misc changes in other files all over the place because package names and class names/usage were changed slightly. I verified that https works. I had a lot of trouble with the gzipped javascript files we have. I tried a lot of different configurations and looking around online. From what I can tell by looking at the Jetty code and using a debugger, it looks like Jetty won't serve .gz files unless the non-gz version is there. They have checks that the non-gz file exists before checking for the .gz file: https://github.com/eclipse/jetty.project/blob/jetty-9.3.x/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceCache.java#L235 https://github.com/eclipse/jetty.project/blob/jetty-9.3.x/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceContentFactory.java#L63 Unfortunately, this means having both the gz and non-gz versions of the files (which is one of the reasons why the patch is so big). I did verify that if the request says it accepts gzip, you'll get the smaller gzipped version of the file: >> curl 'http://localhost:8088/static/jquery/jquery-1.8.2.min.js' --compressed -s -D - -o /dev/null HTTP/1.1 200 OK Date: Wed, 14 Sep 2016 20:46:50 GMT Vary: Accept-Encoding Last-Modified: Wed, 14 Sep 2016 18:58:48 GMT Content-Type: application/javascript Content-Encoding: gzip Accept-Ranges: bytes Content-Length: 33430 Server: Jetty(9.3.11.v20160721) >> curl 'http://localhost:8088/static/jquery/jquery-1.8.2.min.js' -s -D - -o /dev/null HTTP/1.1 200 OK Date: Wed, 14 Sep 2016 20:46:51 GMT Vary: Accept-Encoding Last-Modified: Wed, 14 Sep 2016 18:58:48 GMT Content-Type: application/javascript Accept-Ranges: bytes Content-Length: 93436 Server: Jetty(9.3.11.v20160721) If anyone has any better ideas on how to get gz to work without the extra files, let me know and I'll change it. That said, we're probably supposed to have both the gz and non-gz files so that we can serve the non-gz files if the browser doesn't support gz; otherwise, you get 404s instead. So perhaps this is the correct thing to do anyway, and we had it wrong before.
          Hide
          Steve Loughran added a comment -

          My suggestion would be jerzey

          actually, there's one more workaround, have the .gz. unzipped somewhere on installation. I don't like having to have both unzip and gzip, as it will only lead to version inconsistencies over time

          Show
          Steve Loughran added a comment - My suggestion would be jerzey actually, there's one more workaround, have the .gz. unzipped somewhere on installation. I don't like having to have both unzip and gzip, as it will only lead to version inconsistencies over time
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 36 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 38s trunk passed
          +1 compile 6m 52s trunk passed
          +1 checkstyle 1m 45s trunk passed
          +1 mvnsite 12m 49s trunk passed
          +1 mvneclipse 6m 10s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          +1 findbugs 12m 55s trunk passed
          +1 javadoc 9m 15s trunk passed
          0 mvndep 0m 29s Maven dependency ordering for patch
          +1 mvninstall 11m 17s the patch passed
          +1 compile 6m 54s the patch passed
          -1 javac 6m 54s root generated 4 new + 709 unchanged - 0 fixed = 713 total (was 709)
          -0 checkstyle 1m 52s root: The patch generated 45 new + 1452 unchanged - 17 fixed = 1497 total (was 1469)
          +1 mvnsite 15m 7s the patch passed
          +1 mvneclipse 7m 52s the patch passed
          -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 16s The patch 4277 line(s) with tabs.
          +1 xml 0m 29s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          +1 findbugs 18m 57s the patch passed
          +1 javadoc 11m 6s the patch passed
          +1 unit 0m 14s hadoop-project in the patch passed.
          +1 unit 3m 21s hadoop-auth in the patch passed.
          +1 unit 0m 16s hadoop-auth-examples in the patch passed.
          -1 unit 8m 53s hadoop-common in the patch failed.
          +1 unit 0m 28s hadoop-nfs in the patch passed.
          +1 unit 2m 10s hadoop-kms in the patch passed.
          -1 unit 63m 9s hadoop-hdfs in the patch failed.
          +1 unit 4m 10s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 1m 52s hadoop-hdfs-nfs in the patch passed.
          +1 unit 2m 24s hadoop-yarn-common in the patch passed.
          -1 unit 14m 18s hadoop-yarn-server-nodemanager in the patch failed.
          -1 unit 0m 29s hadoop-yarn-server-web-proxy in the patch failed.
          -1 unit 2m 51s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          +1 unit 0m 51s hadoop-yarn-server-timelineservice in the patch passed.
          -1 unit 34m 21s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 1m 22s hadoop-yarn-server-timeline-pluginstorage in the patch passed.
          -1 unit 140m 45s hadoop-mapreduce-client in the patch failed.
          +1 unit 0m 39s hadoop-mapreduce-client-shuffle in the patch passed.
          -1 unit 8m 57s hadoop-mapreduce-client-app in the patch failed.
          +1 unit 119m 46s hadoop-mapreduce-client-jobclient in the patch passed.
          +1 unit 2m 6s hadoop-azure in the patch passed.
          +1 unit 0m 21s hadoop-client in the patch passed.
          +1 unit 1m 12s hadoop-sls in the patch passed.
          +1 unit 2m 36s hadoop-azure-datalake in the patch passed.
          -1 unit 146m 57s hadoop-mapreduce-project in the patch failed.
          -1 asflicense 16m 8s The patch generated 4 ASF License warnings.
          742m 16s



          Reason Tests
          Failed junit tests hadoop.http.TestServletFilter
            hadoop.log.TestLogLevel
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.server.namenode.TestTransferFsImage
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
            hadoop.hdfs.TestEncryptionZones
            hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor
            hadoop.yarn.server.webproxy.TestWebAppProxyServlet
            hadoop.yarn.server.applicationhistoryservice.TestApplicationHistoryServer
            hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices
            hadoop.yarn.server.resourcemanager.TestRMHA
            hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828742/HADOOP-10075.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 51055a06ff73 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fcbac00
          Default Java 1.8.0_101
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 36 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 6m 52s trunk passed +1 checkstyle 1m 45s trunk passed +1 mvnsite 12m 49s trunk passed +1 mvneclipse 6m 10s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project +1 findbugs 12m 55s trunk passed +1 javadoc 9m 15s trunk passed 0 mvndep 0m 29s Maven dependency ordering for patch +1 mvninstall 11m 17s the patch passed +1 compile 6m 54s the patch passed -1 javac 6m 54s root generated 4 new + 709 unchanged - 0 fixed = 713 total (was 709) -0 checkstyle 1m 52s root: The patch generated 45 new + 1452 unchanged - 17 fixed = 1497 total (was 1469) +1 mvnsite 15m 7s the patch passed +1 mvneclipse 7m 52s the patch passed -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 16s The patch 4277 line(s) with tabs. +1 xml 0m 29s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project +1 findbugs 18m 57s the patch passed +1 javadoc 11m 6s the patch passed +1 unit 0m 14s hadoop-project in the patch passed. +1 unit 3m 21s hadoop-auth in the patch passed. +1 unit 0m 16s hadoop-auth-examples in the patch passed. -1 unit 8m 53s hadoop-common in the patch failed. +1 unit 0m 28s hadoop-nfs in the patch passed. +1 unit 2m 10s hadoop-kms in the patch passed. -1 unit 63m 9s hadoop-hdfs in the patch failed. +1 unit 4m 10s hadoop-hdfs-httpfs in the patch passed. +1 unit 1m 52s hadoop-hdfs-nfs in the patch passed. +1 unit 2m 24s hadoop-yarn-common in the patch passed. -1 unit 14m 18s hadoop-yarn-server-nodemanager in the patch failed. -1 unit 0m 29s hadoop-yarn-server-web-proxy in the patch failed. -1 unit 2m 51s hadoop-yarn-server-applicationhistoryservice in the patch failed. +1 unit 0m 51s hadoop-yarn-server-timelineservice in the patch passed. -1 unit 34m 21s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 1m 22s hadoop-yarn-server-timeline-pluginstorage in the patch passed. -1 unit 140m 45s hadoop-mapreduce-client in the patch failed. +1 unit 0m 39s hadoop-mapreduce-client-shuffle in the patch passed. -1 unit 8m 57s hadoop-mapreduce-client-app in the patch failed. +1 unit 119m 46s hadoop-mapreduce-client-jobclient in the patch passed. +1 unit 2m 6s hadoop-azure in the patch passed. +1 unit 0m 21s hadoop-client in the patch passed. +1 unit 1m 12s hadoop-sls in the patch passed. +1 unit 2m 36s hadoop-azure-datalake in the patch passed. -1 unit 146m 57s hadoop-mapreduce-project in the patch failed. -1 asflicense 16m 8s The patch generated 4 ASF License warnings. 742m 16s Reason Tests Failed junit tests hadoop.http.TestServletFilter   hadoop.log.TestLogLevel   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.namenode.TestTransferFsImage   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.TestEncryptionZones   hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor   hadoop.yarn.server.webproxy.TestWebAppProxyServlet   hadoop.yarn.server.applicationhistoryservice.TestApplicationHistoryServer   hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices   hadoop.yarn.server.resourcemanager.TestRMHA   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828742/HADOOP-10075.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 51055a06ff73 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fcbac00 Default Java 1.8.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10524/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Robert Kanter added a comment - - edited

          The 004 patch does the following:

          • Fixed unit tests
          • Fixed deprecated warnings
          • Removed some missed Jetty 6 usage
          • Removed js.gz and css.gz files, so only the original files are in the source codebase. A maven plugin is used to gzip these files into the target directories during build time. We now do this to all js and {{css} files, unlike before where we had some that were gzipped and some that were not.

          Note that I used --binary when generating the patch because it deletes some gzip files.

          Show
          Robert Kanter added a comment - - edited The 004 patch does the following: Fixed unit tests Fixed deprecated warnings Removed some missed Jetty 6 usage Removed js.gz and css.gz files, so only the original files are in the source codebase. A maven plugin is used to gzip these files into the target directories during build time. We now do this to all js and {{css} files, unlike before where we had some that were gzipped and some that were not. Note that I used --binary when generating the patch because it deletes some gzip files.
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 51 new or modified test files.
          0 mvndep 0m 13s Maven dependency ordering for branch
          +1 mvninstall 6m 41s trunk passed
          +1 compile 6m 53s trunk passed
          +1 checkstyle 1m 56s trunk passed
          +1 mvnsite 14m 13s trunk passed
          +1 mvneclipse 6m 58s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          +1 findbugs 15m 5s trunk passed
          -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in trunk failed.
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 12m 24s the patch passed
          +1 compile 7m 13s the patch passed
          +1 javac 7m 13s the patch passed
          -0 checkstyle 2m 5s root: The patch generated 52 new + 2283 unchanged - 24 fixed = 2335 total (was 2307)
          +1 mvnsite 15m 58s the patch passed
          +1 mvneclipse 8m 37s the patch passed
          -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 18s The patch 4277 line(s) with tabs.
          +1 xml 0m 27s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          +1 findbugs 19m 26s the patch passed
          -1 javadoc 0m 27s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 0m 15s hadoop-project in the patch passed.
          +1 unit 3m 21s hadoop-auth in the patch passed.
          +1 unit 0m 17s hadoop-auth-examples in the patch passed.
          +1 unit 8m 26s hadoop-common in the patch passed.
          +1 unit 0m 29s hadoop-nfs in the patch passed.
          +1 unit 2m 10s hadoop-kms in the patch passed.
          -1 unit 54m 46s hadoop-hdfs in the patch failed.
          +1 unit 3m 44s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 1m 51s hadoop-hdfs-nfs in the patch passed.
          +1 unit 2m 26s hadoop-yarn-common in the patch passed.
          -1 unit 14m 37s hadoop-yarn-server-nodemanager in the patch failed.
          -1 unit 0m 27s hadoop-yarn-server-web-proxy in the patch failed.
          -1 unit 2m 49s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          +1 unit 0m 51s hadoop-yarn-server-timelineservice in the patch passed.
          -1 unit 32m 0s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 16m 4s hadoop-yarn-client in the patch passed.
          +1 unit 1m 17s hadoop-yarn-server-timeline-pluginstorage in the patch passed.
          -1 unit 4m 3s hadoop-yarn-server-timelineservice-hbase-tests in the patch failed.
          -1 unit 19m 54s hadoop-mapreduce-client in the patch failed.
          +1 unit 0m 28s hadoop-mapreduce-client-shuffle in the patch passed.
          -1 unit 8m 56s hadoop-mapreduce-client-app in the patch failed.
          -1 unit 6m 39s hadoop-mapreduce-client-hs in the patch failed.
          -1 unit 0m 47s hadoop-mapreduce-client-jobclient in the patch failed.
          +1 unit 1m 39s hadoop-azure in the patch passed.
          +1 unit 0m 19s hadoop-client in the patch passed.
          +1 unit 1m 8s hadoop-sls in the patch passed.
          +1 unit 2m 27s hadoop-azure-datalake in the patch passed.
          -1 unit 10m 59s hadoop-mapreduce-project in the patch failed.
          -1 asflicense 16m 17s The patch generated 4 ASF License warnings.
          391m 31s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps
            hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesContainers
            hadoop.yarn.server.webproxy.TestWebAppProxyServlet
            hadoop.yarn.server.applicationhistoryservice.TestApplicationHistoryServer
            hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesForCSWithPartitions
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
            hadoop.yarn.webapp.TestRMWithCSRFFilter
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesReservation
            hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobConf
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesAttempts
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobs
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobsQuery
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServices
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempt
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempts
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobs
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobConf
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempt
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempts
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobs
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobConf
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobConf
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesAttempts
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobs
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobsQuery
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServices
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobConf
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesAttempts
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobs
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobsQuery
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServices
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempt
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempts
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobs
            hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobConf



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829421/HADOOP-10075.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 7c086b79a662 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c6d1d74
          Default Java 1.8.0_101
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/whitespace-tabs.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 51 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 6m 41s trunk passed +1 compile 6m 53s trunk passed +1 checkstyle 1m 56s trunk passed +1 mvnsite 14m 13s trunk passed +1 mvneclipse 6m 58s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project +1 findbugs 15m 5s trunk passed -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in trunk failed. 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 12m 24s the patch passed +1 compile 7m 13s the patch passed +1 javac 7m 13s the patch passed -0 checkstyle 2m 5s root: The patch generated 52 new + 2283 unchanged - 24 fixed = 2335 total (was 2307) +1 mvnsite 15m 58s the patch passed +1 mvneclipse 8m 37s the patch passed -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 18s The patch 4277 line(s) with tabs. +1 xml 0m 27s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project +1 findbugs 19m 26s the patch passed -1 javadoc 0m 27s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 15s hadoop-project in the patch passed. +1 unit 3m 21s hadoop-auth in the patch passed. +1 unit 0m 17s hadoop-auth-examples in the patch passed. +1 unit 8m 26s hadoop-common in the patch passed. +1 unit 0m 29s hadoop-nfs in the patch passed. +1 unit 2m 10s hadoop-kms in the patch passed. -1 unit 54m 46s hadoop-hdfs in the patch failed. +1 unit 3m 44s hadoop-hdfs-httpfs in the patch passed. +1 unit 1m 51s hadoop-hdfs-nfs in the patch passed. +1 unit 2m 26s hadoop-yarn-common in the patch passed. -1 unit 14m 37s hadoop-yarn-server-nodemanager in the patch failed. -1 unit 0m 27s hadoop-yarn-server-web-proxy in the patch failed. -1 unit 2m 49s hadoop-yarn-server-applicationhistoryservice in the patch failed. +1 unit 0m 51s hadoop-yarn-server-timelineservice in the patch passed. -1 unit 32m 0s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 16m 4s hadoop-yarn-client in the patch passed. +1 unit 1m 17s hadoop-yarn-server-timeline-pluginstorage in the patch passed. -1 unit 4m 3s hadoop-yarn-server-timelineservice-hbase-tests in the patch failed. -1 unit 19m 54s hadoop-mapreduce-client in the patch failed. +1 unit 0m 28s hadoop-mapreduce-client-shuffle in the patch passed. -1 unit 8m 56s hadoop-mapreduce-client-app in the patch failed. -1 unit 6m 39s hadoop-mapreduce-client-hs in the patch failed. -1 unit 0m 47s hadoop-mapreduce-client-jobclient in the patch failed. +1 unit 1m 39s hadoop-azure in the patch passed. +1 unit 0m 19s hadoop-client in the patch passed. +1 unit 1m 8s hadoop-sls in the patch passed. +1 unit 2m 27s hadoop-azure-datalake in the patch passed. -1 unit 10m 59s hadoop-mapreduce-project in the patch failed. -1 asflicense 16m 17s The patch generated 4 ASF License warnings. 391m 31s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps   hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesContainers   hadoop.yarn.server.webproxy.TestWebAppProxyServlet   hadoop.yarn.server.applicationhistoryservice.TestApplicationHistoryServer   hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesForCSWithPartitions   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps   hadoop.yarn.webapp.TestRMWithCSRFFilter   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesReservation   hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobConf   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesAttempts   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobs   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobsQuery   hadoop.mapreduce.v2.hs.webapp.TestHsWebServices   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempt   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempts   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobs   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobConf   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempt   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempts   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobs   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobConf   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobConf   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesAttempts   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobs   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobsQuery   hadoop.mapreduce.v2.hs.webapp.TestHsWebServices   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobConf   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesAttempts   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobs   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobsQuery   hadoop.mapreduce.v2.hs.webapp.TestHsWebServices   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempt   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempts   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobs   hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobConf Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829421/HADOOP-10075.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 7c086b79a662 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c6d1d74 Default Java 1.8.0_101 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/whitespace-tabs.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10552/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Robert Kanter added a comment -

          The 005 patch fixes a bunch of unit tests.

          There's an issue I need to still figure out with the tests in the hadoop-yarn-server-timelineservice-hbase-tests module. We're mixing Hadoop 2.5.1 and Hadoop 3 (trunk) in there (oy!) and it should be using Jetty 6, but something is causing it to try to use Jetty 9:

          java.lang.NoClassDefFoundError: org/eclipse/jetty/servlet/ServletContextHandler
          
          	at org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage.init(TestTimelineReaderWebServicesHBaseStorage.java:372)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:483)
          	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
          	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
          	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
          	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
          	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
          	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
          	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
          	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
          	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
          	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
          	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
          	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
          	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
          	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
          	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
          	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
          	at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
          	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:117)
          	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42)
          	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:262)
          	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:84)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:483)
          	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)
          Caused by: java.lang.ClassNotFoundException: org.eclipse.jetty.servlet.ServletContextHandler
          	at java.net.URLClassLoader$1.run(URLClassLoader.java:372)
          	at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
          	at java.security.AccessController.doPrivileged(Native Method)
          	at java.net.URLClassLoader.findClass(URLClassLoader.java:360)
          	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
          	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
          	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
          	... 31 more
          
          Show
          Robert Kanter added a comment - The 005 patch fixes a bunch of unit tests. There's an issue I need to still figure out with the tests in the hadoop-yarn-server-timelineservice-hbase-tests module. We're mixing Hadoop 2.5.1 and Hadoop 3 (trunk) in there (oy!) and it should be using Jetty 6, but something is causing it to try to use Jetty 9: java.lang.NoClassDefFoundError: org/eclipse/jetty/servlet/ServletContextHandler at org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage.init(TestTimelineReaderWebServicesHBaseStorage.java:372) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:483) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner.run(ParentRunner.java:309) at org.junit.runner.JUnitCore.run(JUnitCore.java:160) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:117) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42) at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:262) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:84) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:483) at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147) Caused by: java.lang.ClassNotFoundException: org.eclipse.jetty.servlet.ServletContextHandler at java.net.URLClassLoader$1.run(URLClassLoader.java:372) at java.net.URLClassLoader$1.run(URLClassLoader.java:361) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:360) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 31 more
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 74 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 36s trunk passed
          +1 compile 6m 49s trunk passed
          +1 checkstyle 2m 1s trunk passed
          +1 mvnsite 13m 56s trunk passed
          +1 mvneclipse 6m 46s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          +1 findbugs 17m 8s trunk passed
          +1 javadoc 10m 19s trunk passed
          0 mvndep 0m 37s Maven dependency ordering for patch
          +1 mvninstall 12m 30s the patch passed
          +1 compile 7m 16s the patch passed
          +1 javac 7m 16s the patch passed
          -0 checkstyle 2m 7s root: The patch generated 57 new + 2560 unchanged - 27 fixed = 2617 total (was 2587)
          +1 mvnsite 15m 51s the patch passed
          +1 mvneclipse 8m 29s the patch passed
          -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 16s The patch 4277 line(s) with tabs.
          +1 xml 0m 28s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          +1 findbugs 19m 11s the patch passed
          +1 javadoc 11m 58s the patch passed
          +1 unit 0m 14s hadoop-project in the patch passed.
          +1 unit 3m 25s hadoop-auth in the patch passed.
          +1 unit 0m 17s hadoop-auth-examples in the patch passed.
          -1 unit 7m 54s hadoop-common in the patch failed.
          +1 unit 0m 27s hadoop-nfs in the patch passed.
          +1 unit 2m 8s hadoop-kms in the patch passed.
          +1 unit 56m 21s hadoop-hdfs in the patch passed.
          +1 unit 3m 45s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 1m 51s hadoop-hdfs-nfs in the patch passed.
          +1 unit 2m 26s hadoop-yarn-common in the patch passed.
          +1 unit 14m 41s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 0m 27s hadoop-yarn-server-web-proxy in the patch failed.
          -1 unit 2m 47s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          +1 unit 0m 50s hadoop-yarn-server-timelineservice in the patch passed.
          +1 unit 35m 10s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 unit 16m 27s hadoop-yarn-client in the patch passed.
          +1 unit 1m 22s hadoop-yarn-server-timeline-pluginstorage in the patch passed.
          -1 unit 4m 16s hadoop-yarn-server-timelineservice-hbase-tests in the patch failed.
          -1 unit 21m 17s hadoop-mapreduce-client in the patch failed.
          +1 unit 0m 30s hadoop-mapreduce-client-shuffle in the patch passed.
          +1 unit 9m 21s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 6m 43s hadoop-mapreduce-client-hs in the patch passed.
          -1 unit 122m 16s hadoop-mapreduce-client-jobclient in the patch passed.
          +1 unit 1m 49s hadoop-azure in the patch passed.
          +1 unit 0m 21s hadoop-client in the patch passed.
          +1 unit 1m 6s hadoop-sls in the patch passed.
          +1 unit 2m 35s hadoop-azure-datalake in the patch passed.
          -1 unit 159m 1s hadoop-mapreduce-project in the patch failed.
          -1 asflicense 19m 12s The patch generated 4 ASF License warnings.
          673m 12s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.yarn.server.webproxy.TestWebAppProxyServlet
            hadoop.yarn.server.applicationhistoryservice.TestApplicationHistoryServer
            hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices
            hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage
            hadoop.mapreduce.TestMRJobClient
            hadoop.mapreduce.TestMRJobClient
            hadoop.mapreduce.TestMRJobClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829717/HADOOP-10075.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux d1ec001bccb9 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 964e546
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 74 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 36s trunk passed +1 compile 6m 49s trunk passed +1 checkstyle 2m 1s trunk passed +1 mvnsite 13m 56s trunk passed +1 mvneclipse 6m 46s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project +1 findbugs 17m 8s trunk passed +1 javadoc 10m 19s trunk passed 0 mvndep 0m 37s Maven dependency ordering for patch +1 mvninstall 12m 30s the patch passed +1 compile 7m 16s the patch passed +1 javac 7m 16s the patch passed -0 checkstyle 2m 7s root: The patch generated 57 new + 2560 unchanged - 27 fixed = 2617 total (was 2587) +1 mvnsite 15m 51s the patch passed +1 mvneclipse 8m 29s the patch passed -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 16s The patch 4277 line(s) with tabs. +1 xml 0m 28s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project +1 findbugs 19m 11s the patch passed +1 javadoc 11m 58s the patch passed +1 unit 0m 14s hadoop-project in the patch passed. +1 unit 3m 25s hadoop-auth in the patch passed. +1 unit 0m 17s hadoop-auth-examples in the patch passed. -1 unit 7m 54s hadoop-common in the patch failed. +1 unit 0m 27s hadoop-nfs in the patch passed. +1 unit 2m 8s hadoop-kms in the patch passed. +1 unit 56m 21s hadoop-hdfs in the patch passed. +1 unit 3m 45s hadoop-hdfs-httpfs in the patch passed. +1 unit 1m 51s hadoop-hdfs-nfs in the patch passed. +1 unit 2m 26s hadoop-yarn-common in the patch passed. +1 unit 14m 41s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 0m 27s hadoop-yarn-server-web-proxy in the patch failed. -1 unit 2m 47s hadoop-yarn-server-applicationhistoryservice in the patch failed. +1 unit 0m 50s hadoop-yarn-server-timelineservice in the patch passed. +1 unit 35m 10s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 16m 27s hadoop-yarn-client in the patch passed. +1 unit 1m 22s hadoop-yarn-server-timeline-pluginstorage in the patch passed. -1 unit 4m 16s hadoop-yarn-server-timelineservice-hbase-tests in the patch failed. -1 unit 21m 17s hadoop-mapreduce-client in the patch failed. +1 unit 0m 30s hadoop-mapreduce-client-shuffle in the patch passed. +1 unit 9m 21s hadoop-mapreduce-client-app in the patch passed. +1 unit 6m 43s hadoop-mapreduce-client-hs in the patch passed. -1 unit 122m 16s hadoop-mapreduce-client-jobclient in the patch passed. +1 unit 1m 49s hadoop-azure in the patch passed. +1 unit 0m 21s hadoop-client in the patch passed. +1 unit 1m 6s hadoop-sls in the patch passed. +1 unit 2m 35s hadoop-azure-datalake in the patch passed. -1 unit 159m 1s hadoop-mapreduce-project in the patch failed. -1 asflicense 19m 12s The patch generated 4 ASF License warnings. 673m 12s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.yarn.server.webproxy.TestWebAppProxyServlet   hadoop.yarn.server.applicationhistoryservice.TestApplicationHistoryServer   hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices   hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage   hadoop.mapreduce.TestMRJobClient   hadoop.mapreduce.TestMRJobClient   hadoop.mapreduce.TestMRJobClient Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829717/HADOOP-10075.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux d1ec001bccb9 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 964e546 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10562/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Robert Kanter added a comment -

          The 006 patch fixes some checkstyle and unit tests, including the hadoop-yarn-server-timelineservice-hbase-tests module. The problem is that we have ATS classes from Hadoop 3, mixed with Hadoop 2.5.1 for everything else. This means that the ATS is running with HttpServer2 from Hadoop 2.5.1, with Jetty 6, not Jetty 9. To deal with this, I made two changes:

          1. Added some Jetty 9 dependencies to the module as there is some ATS code that directly uses it (e.g. logging)
          2. Moved a single HttpServer2 call in an ATS class into it's own method so that a test could overwrite it to do nothing during the test. Otherwise, you get a MethodNotFoundException. This doesn't affect the normal operation of the class, just during this test.
          Show
          Robert Kanter added a comment - The 006 patch fixes some checkstyle and unit tests, including the hadoop-yarn-server-timelineservice-hbase-tests module. The problem is that we have ATS classes from Hadoop 3, mixed with Hadoop 2.5.1 for everything else. This means that the ATS is running with HttpServer2 from Hadoop 2.5.1, with Jetty 6, not Jetty 9. To deal with this, I made two changes: Added some Jetty 9 dependencies to the module as there is some ATS code that directly uses it (e.g. logging) Moved a single HttpServer2 call in an ATS class into it's own method so that a test could overwrite it to do nothing during the test. Otherwise, you get a MethodNotFoundException . This doesn't affect the normal operation of the class, just during this test.
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 75 new or modified test files.
          0 mvndep 1m 40s Maven dependency ordering for branch
          +1 mvninstall 8m 6s trunk passed
          +1 compile 8m 8s trunk passed
          +1 checkstyle 2m 4s trunk passed
          +1 mvnsite 14m 41s trunk passed
          +1 mvneclipse 7m 59s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          +1 findbugs 17m 19s trunk passed
          +1 javadoc 11m 15s trunk passed
          0 mvndep 0m 30s Maven dependency ordering for patch
          +1 mvninstall 15m 17s the patch passed
          +1 compile 8m 28s the patch passed
          +1 javac 8m 28s the patch passed
          -0 checkstyle 2m 16s root: The patch generated 33 new + 2546 unchanged - 42 fixed = 2579 total (was 2588)
          +1 mvnsite 17m 3s the patch passed
          +1 mvneclipse 8m 27s the patch passed
          -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 18s The patch 4277 line(s) with tabs.
          +1 xml 0m 28s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          +1 findbugs 18m 50s the patch passed
          +1 javadoc 12m 11s the patch passed
          +1 unit 0m 15s hadoop-project in the patch passed.
          -1 unit 3m 27s hadoop-auth in the patch failed.
          +1 unit 0m 17s hadoop-auth-examples in the patch passed.
          +1 unit 8m 41s hadoop-common in the patch passed.
          +1 unit 0m 28s hadoop-nfs in the patch passed.
          +1 unit 2m 11s hadoop-kms in the patch passed.
          +1 unit 60m 13s hadoop-hdfs in the patch passed.
          +1 unit 3m 52s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 1m 50s hadoop-hdfs-nfs in the patch passed.
          +1 unit 2m 25s hadoop-yarn-common in the patch passed.
          -1 unit 14m 36s hadoop-yarn-server-nodemanager in the patch failed.
          +1 unit 0m 30s hadoop-yarn-server-web-proxy in the patch passed.
          -1 unit 2m 47s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          +1 unit 0m 54s hadoop-yarn-server-timelineservice in the patch passed.
          +1 unit 35m 9s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 unit 15m 55s hadoop-yarn-client in the patch passed.
          +1 unit 1m 18s hadoop-yarn-server-timeline-pluginstorage in the patch passed.
          +1 unit 4m 22s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed.
          -1 unit 150m 2s hadoop-mapreduce-client in the patch failed.
          +1 unit 0m 35s hadoop-mapreduce-client-shuffle in the patch passed.
          +1 unit 8m 53s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 6m 55s hadoop-mapreduce-client-hs in the patch passed.
          +1 unit 123m 49s hadoop-mapreduce-client-jobclient in the patch passed.
          +1 unit 1m 36s hadoop-azure in the patch passed.
          +1 unit 0m 26s hadoop-client in the patch passed.
          +1 unit 1m 10s hadoop-sls in the patch passed.
          +1 unit 2m 32s hadoop-azure-datalake in the patch passed.
          -1 unit 144m 48s hadoop-mapreduce-project in the patch failed.
          -1 asflicense 15m 3s The patch generated 4 ASF License warnings.
          802m 0s



          Reason Tests
          Failed junit tests hadoop.security.authentication.util.TestZKSignerSecretProvider
            hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager
            hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830133/HADOOP-10075.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 3c76c56813ca 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6eb700e
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 75 new or modified test files. 0 mvndep 1m 40s Maven dependency ordering for branch +1 mvninstall 8m 6s trunk passed +1 compile 8m 8s trunk passed +1 checkstyle 2m 4s trunk passed +1 mvnsite 14m 41s trunk passed +1 mvneclipse 7m 59s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project +1 findbugs 17m 19s trunk passed +1 javadoc 11m 15s trunk passed 0 mvndep 0m 30s Maven dependency ordering for patch +1 mvninstall 15m 17s the patch passed +1 compile 8m 28s the patch passed +1 javac 8m 28s the patch passed -0 checkstyle 2m 16s root: The patch generated 33 new + 2546 unchanged - 42 fixed = 2579 total (was 2588) +1 mvnsite 17m 3s the patch passed +1 mvneclipse 8m 27s the patch passed -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 18s The patch 4277 line(s) with tabs. +1 xml 0m 28s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project +1 findbugs 18m 50s the patch passed +1 javadoc 12m 11s the patch passed +1 unit 0m 15s hadoop-project in the patch passed. -1 unit 3m 27s hadoop-auth in the patch failed. +1 unit 0m 17s hadoop-auth-examples in the patch passed. +1 unit 8m 41s hadoop-common in the patch passed. +1 unit 0m 28s hadoop-nfs in the patch passed. +1 unit 2m 11s hadoop-kms in the patch passed. +1 unit 60m 13s hadoop-hdfs in the patch passed. +1 unit 3m 52s hadoop-hdfs-httpfs in the patch passed. +1 unit 1m 50s hadoop-hdfs-nfs in the patch passed. +1 unit 2m 25s hadoop-yarn-common in the patch passed. -1 unit 14m 36s hadoop-yarn-server-nodemanager in the patch failed. +1 unit 0m 30s hadoop-yarn-server-web-proxy in the patch passed. -1 unit 2m 47s hadoop-yarn-server-applicationhistoryservice in the patch failed. +1 unit 0m 54s hadoop-yarn-server-timelineservice in the patch passed. +1 unit 35m 9s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 15m 55s hadoop-yarn-client in the patch passed. +1 unit 1m 18s hadoop-yarn-server-timeline-pluginstorage in the patch passed. +1 unit 4m 22s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed. -1 unit 150m 2s hadoop-mapreduce-client in the patch failed. +1 unit 0m 35s hadoop-mapreduce-client-shuffle in the patch passed. +1 unit 8m 53s hadoop-mapreduce-client-app in the patch passed. +1 unit 6m 55s hadoop-mapreduce-client-hs in the patch passed. +1 unit 123m 49s hadoop-mapreduce-client-jobclient in the patch passed. +1 unit 1m 36s hadoop-azure in the patch passed. +1 unit 0m 26s hadoop-client in the patch passed. +1 unit 1m 10s hadoop-sls in the patch passed. +1 unit 2m 32s hadoop-azure-datalake in the patch passed. -1 unit 144m 48s hadoop-mapreduce-project in the patch failed. -1 asflicense 15m 3s The patch generated 4 ASF License warnings. 802m 0s Reason Tests Failed junit tests hadoop.security.authentication.util.TestZKSignerSecretProvider   hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager   hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830133/HADOOP-10075.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 3c76c56813ca 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6eb700e Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10586/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Ravi Prakash added a comment -

          Thanks for all your work Robert.

          • Why did you have to deprecate RequestLoggerFilter.setStatus ?
          • Is there precedent for trusting external plugins in Maven? Even though I'm sure com.github.phuonghuynh is a perfectly trustworthy repo, is there something else we can do? I would almost rather keep the 2 files (compressed and uncompressed)
          Show
          Ravi Prakash added a comment - Thanks for all your work Robert. Why did you have to deprecate RequestLoggerFilter.setStatus ? Is there precedent for trusting external plugins in Maven? Even though I'm sure com.github.phuonghuynh is a perfectly trustworthy repo, is there something else we can do? I would almost rather keep the 2 files (compressed and uncompressed)
          Hide
          Robert Kanter added a comment -

          Thanks for looking at the patch; I know it's a big one

          • I had to deprecate RequestLoggerFilter.setStatus because it calls super.setStatus, which is deprecated. There is a one argument setStatus, which is not. See https://docs.oracle.com/javaee/7/api/javax/servlet/http/HttpServletResponseWrapper.html#setStatus-int-java.lang.String-
          • I couldn't find anything about the safety/security of maven plugins. It is coming from the maven central repo, so it's probably safe as long as the author of the plugin doesn't upload something malicious there (I don't know if the repo does any checking on that sort of thing). I guess we have these options:
            1. Use this plugin
            2. Keep both compressed and uncompressed files
            3. Keep only uncompressed files
            4. Write our own plugin to do the same thing. It looks like we already have a "hadoop-maven-plugins" maven plugin that does a number of different things. We could add it there. I took a quick look and writing a simple plugin like this doesn't look too complicated.
          Show
          Robert Kanter added a comment - Thanks for looking at the patch; I know it's a big one I had to deprecate RequestLoggerFilter.setStatus because it calls super.setStatus , which is deprecated. There is a one argument setStatus , which is not. See https://docs.oracle.com/javaee/7/api/javax/servlet/http/HttpServletResponseWrapper.html#setStatus-int-java.lang.String- I couldn't find anything about the safety/security of maven plugins. It is coming from the maven central repo, so it's probably safe as long as the author of the plugin doesn't upload something malicious there (I don't know if the repo does any checking on that sort of thing). I guess we have these options: Use this plugin Keep both compressed and uncompressed files Keep only uncompressed files Write our own plugin to do the same thing. It looks like we already have a "hadoop-maven-plugins" maven plugin that does a number of different things. We could add it there. I took a quick look and writing a simple plugin like this doesn't look too complicated.
          Hide
          Robert Kanter added a comment -

          The 007 patch:

          • No longer uses the com.github.phuonghuynh plugin. I've written one in hadoop-maven-plugins that does something similar instead.
          Show
          Robert Kanter added a comment - The 007 patch: No longer uses the com.github.phuonghuynh plugin. I've written one in hadoop-maven-plugins that does something similar instead.
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 75 new or modified test files.
          0 mvndep 1m 40s Maven dependency ordering for branch
          +1 mvninstall 7m 24s trunk passed
          +1 compile 7m 19s trunk passed
          +1 checkstyle 2m 3s trunk passed
          +1 mvnsite 14m 20s trunk passed
          +1 mvneclipse 6m 56s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          +1 findbugs 14m 27s trunk passed
          +1 javadoc 9m 59s trunk passed
          0 mvndep 0m 56s Maven dependency ordering for patch
          +1 mvninstall 13m 59s the patch passed
          +1 compile 9m 8s the patch passed
          +1 javac 9m 8s the patch passed
          -0 checkstyle 2m 11s root: The patch generated 42 new + 2544 unchanged - 42 fixed = 2586 total (was 2586)
          +1 mvnsite 15m 47s the patch passed
          +1 mvneclipse 8m 49s the patch passed
          -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 18s The patch 4277 line(s) with tabs.
          +1 xml 0m 28s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          -1 findbugs 0m 35s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 11m 40s the patch passed
          +1 unit 0m 14s hadoop-project in the patch passed.
          +1 unit 0m 16s hadoop-maven-plugins in the patch passed.
          +1 unit 3m 19s hadoop-auth in the patch passed.
          +1 unit 0m 16s hadoop-auth-examples in the patch passed.
          +1 unit 7m 39s hadoop-common in the patch passed.
          +1 unit 0m 28s hadoop-nfs in the patch passed.
          +1 unit 2m 9s hadoop-kms in the patch passed.
          -1 unit 55m 30s hadoop-hdfs in the patch failed.
          +1 unit 3m 50s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 1m 52s hadoop-hdfs-nfs in the patch passed.
          +1 unit 2m 25s hadoop-yarn-common in the patch passed.
          +1 unit 15m 16s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 0m 30s hadoop-yarn-server-web-proxy in the patch passed.
          -1 unit 2m 50s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          +1 unit 0m 52s hadoop-yarn-server-timelineservice in the patch passed.
          +1 unit 35m 26s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 unit 16m 15s hadoop-yarn-client in the patch passed.
          +1 unit 1m 22s hadoop-yarn-server-timeline-pluginstorage in the patch passed.
          +1 unit 4m 24s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed.
          -1 unit 19m 52s hadoop-mapreduce-client in the patch failed.
          +1 unit 0m 28s hadoop-mapreduce-client-shuffle in the patch passed.
          -1 unit 8m 50s hadoop-mapreduce-client-app in the patch failed.
          +1 unit 3m 16s hadoop-mapreduce-client-hs in the patch passed.
          +1 unit 108m 9s hadoop-mapreduce-client-jobclient in the patch passed.
          +1 unit 1m 37s hadoop-azure in the patch passed.
          +1 unit 0m 26s hadoop-client in the patch passed.
          +1 unit 1m 11s hadoop-sls in the patch passed.
          +1 unit 2m 32s hadoop-azure-datalake in the patch passed.
          -1 unit 20m 6s hadoop-mapreduce-project in the patch failed.
          -1 asflicense 18m 2s The patch generated 4 ASF License warnings.
          517m 48s



          Reason Tests
          FindBugs module:hadoop-maven-plugins
            Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:[line 105]
          Failed junit tests hadoop.hdfs.TestFileCreationDelete
            hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices
            hadoop.mapreduce.v2.app.webapp.TestAMWebApp
            hadoop.mapreduce.v2.app.webapp.TestAMWebApp
            hadoop.mapreduce.v2.app.webapp.TestAMWebApp



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831668/HADOOP-10075.007.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 110e840013e0 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 31f8da2
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/whitespace-tabs.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-project hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 75 new or modified test files. 0 mvndep 1m 40s Maven dependency ordering for branch +1 mvninstall 7m 24s trunk passed +1 compile 7m 19s trunk passed +1 checkstyle 2m 3s trunk passed +1 mvnsite 14m 20s trunk passed +1 mvneclipse 6m 56s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project +1 findbugs 14m 27s trunk passed +1 javadoc 9m 59s trunk passed 0 mvndep 0m 56s Maven dependency ordering for patch +1 mvninstall 13m 59s the patch passed +1 compile 9m 8s the patch passed +1 javac 9m 8s the patch passed -0 checkstyle 2m 11s root: The patch generated 42 new + 2544 unchanged - 42 fixed = 2586 total (was 2586) +1 mvnsite 15m 47s the patch passed +1 mvneclipse 8m 49s the patch passed -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 18s The patch 4277 line(s) with tabs. +1 xml 0m 28s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project -1 findbugs 0m 35s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 11m 40s the patch passed +1 unit 0m 14s hadoop-project in the patch passed. +1 unit 0m 16s hadoop-maven-plugins in the patch passed. +1 unit 3m 19s hadoop-auth in the patch passed. +1 unit 0m 16s hadoop-auth-examples in the patch passed. +1 unit 7m 39s hadoop-common in the patch passed. +1 unit 0m 28s hadoop-nfs in the patch passed. +1 unit 2m 9s hadoop-kms in the patch passed. -1 unit 55m 30s hadoop-hdfs in the patch failed. +1 unit 3m 50s hadoop-hdfs-httpfs in the patch passed. +1 unit 1m 52s hadoop-hdfs-nfs in the patch passed. +1 unit 2m 25s hadoop-yarn-common in the patch passed. +1 unit 15m 16s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 0m 30s hadoop-yarn-server-web-proxy in the patch passed. -1 unit 2m 50s hadoop-yarn-server-applicationhistoryservice in the patch failed. +1 unit 0m 52s hadoop-yarn-server-timelineservice in the patch passed. +1 unit 35m 26s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 16m 15s hadoop-yarn-client in the patch passed. +1 unit 1m 22s hadoop-yarn-server-timeline-pluginstorage in the patch passed. +1 unit 4m 24s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed. -1 unit 19m 52s hadoop-mapreduce-client in the patch failed. +1 unit 0m 28s hadoop-mapreduce-client-shuffle in the patch passed. -1 unit 8m 50s hadoop-mapreduce-client-app in the patch failed. +1 unit 3m 16s hadoop-mapreduce-client-hs in the patch passed. +1 unit 108m 9s hadoop-mapreduce-client-jobclient in the patch passed. +1 unit 1m 37s hadoop-azure in the patch passed. +1 unit 0m 26s hadoop-client in the patch passed. +1 unit 1m 11s hadoop-sls in the patch passed. +1 unit 2m 32s hadoop-azure-datalake in the patch passed. -1 unit 20m 6s hadoop-mapreduce-project in the patch failed. -1 asflicense 18m 2s The patch generated 4 ASF License warnings. 517m 48s Reason Tests FindBugs module:hadoop-maven-plugins   Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java: [line 105] Failed junit tests hadoop.hdfs.TestFileCreationDelete   hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices   hadoop.mapreduce.v2.app.webapp.TestAMWebApp   hadoop.mapreduce.v2.app.webapp.TestAMWebApp   hadoop.mapreduce.v2.app.webapp.TestAMWebApp Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831668/HADOOP-10075.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 110e840013e0 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 31f8da2 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10666/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Steve Loughran added a comment -

          wow, this is getting a big patch. Bet you wish you hadn't volunteered for it now ...

          Show
          Steve Loughran added a comment - wow, this is getting a big patch. Bet you wish you hadn't volunteered for it now ...
          Hide
          Kihwal Lee added a comment -

          Our baby has grown from 100KB to 1.27MB in three years. Thanks for volunteering to take care of our problem child, Robert Kanter.

          Show
          Kihwal Lee added a comment - Our baby has grown from 100KB to 1.27MB in three years. Thanks for volunteering to take care of our problem child, Robert Kanter .
          Hide
          Daniel Templeton added a comment -

          Damn, that's a patch. Thanks for pushing that boulder up the mountain. Let's get it reviewed before it rolls back down again.

          Taking a first pass at reviewing. Here are some initial comments:

          • RequestLoggerFilter is an example, so it would be nice to add some javadoc with a @deprecated tag to explain why and what should be used instead. I think that's generally true for all the classes you deprecated.
          • It would be good to log something here:
                // Jetty doesn't like the same path spec mapping to different servlets, so
                // if there's already a mapping for this pathSpec, remove it and assume that
                // the newest one is the one we want
                final ServletMapping[] servletMappings =
                    webAppContext.getServletHandler().getServletMappings();
                for (int i = 0; i < servletMappings.length; i++) {
                  if (servletMappings[i].containsPathSpec(pathSpec)) {
                    ServletMapping[] newServletMappings =
                        ArrayUtil.removeFromArray(servletMappings, servletMappings[i]);
                    webAppContext.getServletHandler()
                        .setServletMappings(newServletMappings);
                    break;
                  }
                }
          • Can you get away with a diamond operator here?
                for (Map.Entry<ServletContextHandler, Boolean> e
                    : defaultContexts.entrySet()) {
                   if (e.getValue()) {
                     ...
                   }
                }
          • You have a few casts, like this:
                ServerConnector c = (ServerConnector) webServer.getConnectors()[index];

            I don't think you're supposed to have the space between the parens around the type and the target.

          • I'm not a fan of ternary operators, but this patch is big enough that I'm willing to let it slide this time.
          • Is it safe to remove class without letting them sit around deprecated for a release?
          • You took out the space before the semicolon everywhere else, so you shouldn't add it here:
              @Produces({MediaType.APPLICATION_JSON + "; charset=utf-8"})
          • Please add space around the operators here:
                  http_config.setRequestHeaderSize(1024*64);
                  http_config.setResponseHeaderSize(1024*64);
          • What's the story here?
            -  @Test(timeout = 5000)
            +  @Test(timeout = 10000)

            Extending timeouts isn't usually the right answer...

          • I think the spacing could be better here:
                    Log.getLog().warn(
                        "Job end notification couldn't parse configured proxy's port "
                       + portConf + ". Not going to use a proxy");
          • Might it be worthwhile defining ";charset=utf-8" as a constant?
          • Since you're messing with
                    Log.getLog().info(" == alloc " + allocatedContainerCount
                        + " it left " + iterationsLeft)

            would you mind making that log message actually make sense?

          • At great risk to my personal safety, I will suggest that it would be nice to add messages to the asserts you're touching in the test classes, e.g.
                assertEquals(MediaType.APPLICATION_XML_TYPE + "; charset=utf-8",
                    response.getType().toString());
          • You should probably be more specific here:
                      // Once ${hbase-compatible-hadoop.version} is changed to Hadoop 3,
                      // we should be able to get rid of this.

            Get rid of what and how?

          • TimelineReaderServer.setupOptions() should have a javadoc header.
          Show
          Daniel Templeton added a comment - Damn, that's a patch. Thanks for pushing that boulder up the mountain. Let's get it reviewed before it rolls back down again. Taking a first pass at reviewing. Here are some initial comments: RequestLoggerFilter is an example, so it would be nice to add some javadoc with a @deprecated tag to explain why and what should be used instead. I think that's generally true for all the classes you deprecated. It would be good to log something here: // Jetty doesn't like the same path spec mapping to different servlets, so // if there's already a mapping for this pathSpec, remove it and assume that // the newest one is the one we want final ServletMapping[] servletMappings = webAppContext.getServletHandler().getServletMappings(); for ( int i = 0; i < servletMappings.length; i++) { if (servletMappings[i].containsPathSpec(pathSpec)) { ServletMapping[] newServletMappings = ArrayUtil.removeFromArray(servletMappings, servletMappings[i]); webAppContext.getServletHandler() .setServletMappings(newServletMappings); break ; } } Can you get away with a diamond operator here? for (Map.Entry<ServletContextHandler, Boolean > e : defaultContexts.entrySet()) { if (e.getValue()) { ... } } You have a few casts, like this: ServerConnector c = (ServerConnector) webServer.getConnectors()[index]; I don't think you're supposed to have the space between the parens around the type and the target. I'm not a fan of ternary operators, but this patch is big enough that I'm willing to let it slide this time. Is it safe to remove class without letting them sit around deprecated for a release? You took out the space before the semicolon everywhere else, so you shouldn't add it here: @Produces({MediaType.APPLICATION_JSON + "; charset=utf-8" }) Please add space around the operators here: http_config.setRequestHeaderSize(1024*64); http_config.setResponseHeaderSize(1024*64); What's the story here? - @Test(timeout = 5000) + @Test(timeout = 10000) Extending timeouts isn't usually the right answer... I think the spacing could be better here: Log.getLog().warn( "Job end notification couldn't parse configured proxy's port " + portConf + ". Not going to use a proxy" ); Might it be worthwhile defining ";charset=utf-8" as a constant? Since you're messing with Log.getLog().info( " == alloc " + allocatedContainerCount + " it left " + iterationsLeft) would you mind making that log message actually make sense? At great risk to my personal safety, I will suggest that it would be nice to add messages to the asserts you're touching in the test classes, e.g. assertEquals(MediaType.APPLICATION_XML_TYPE + "; charset=utf-8" , response.getType().toString()); You should probably be more specific here: // Once ${hbase-compatible-hadoop.version} is changed to Hadoop 3, // we should be able to get rid of this . Get rid of what and how? TimelineReaderServer.setupOptions() should have a javadoc header.
          Hide
          Steve Loughran added a comment -

          I'm not a fan of ternary operators, but this patch is big enough that I'm willing to let it slide this time.

          I am, if you get more into the java 8 streams APIs or scala, you may appreciate them more too. The biggest risk that you get the query and the two results mixed up

          Show
          Steve Loughran added a comment - I'm not a fan of ternary operators, but this patch is big enough that I'm willing to let it slide this time. I am, if you get more into the java 8 streams APIs or scala, you may appreciate them more too. The biggest risk that you get the query and the two results mixed up
          Hide
          Robert Kanter added a comment -

          Thanks for the feedback Daniel Templeton.

          The 008 patch:

          • Adds javadoc explaining the @deprecated
          • Adds a log message to that servlet mapping thing
          • Makes cast styling of (ServerConnector) consistent
          • Added spaces around the * operator
          • Updated log messages
          • Clarified the comment about Hadoop 3
          • Added javadoc in TimelineReaderServer#setupOptions
          • Rebased on latest trunk

          And my responses to your remaining feedback:

          • I couldn't put in a diamond operator there; it didn't like that.
          • The only removed class is SslSelectChannelConnectorSecure, which was marked private, so I think we're okay removing it.
          • I'm not sure I understand your comment about the space and the semicolon. I know I updated the @Produces a lot, but as far as I can tell, they're all identical. Can you give me some file names and lines where they differ?
          • On the test timeout increase, I had to increase it because the server now takes longer to shutdown. I did some checking, and with Jetty 9, it takes ~3000ms, but with Jetty 6, it takes only ~100ms. Due to this, I had to increase the timeout. I'm not sure there's much we can do about this; it's mostly Jetty code and I didn't change much in the stop method.
          • I looks like the way to get the utf-8 charset as a constant String is via StandardCharsets.UTF_8.name(). Any suggestions on an easy way to do that? There's over 600 instances of this in the patch.
          • I agree that it's generally good to put messages into assert statements, but I don't think that's necessary when it's obvious what it's checking and what is wrong with it. We're clearly checking the response type here, and when it's incorrect, you get an obvious message like this:
            org.junit.ComparisonFailure: 
            Expected :application/json; charset=foo
            Actual   :application/json; charset=utf-8
            

            Adding a message like "Expected response type X but got response type Y" won't be any more helpful than this.

          Show
          Robert Kanter added a comment - Thanks for the feedback Daniel Templeton . The 008 patch: Adds javadoc explaining the @deprecated Adds a log message to that servlet mapping thing Makes cast styling of (ServerConnector) consistent Added spaces around the * operator Updated log messages Clarified the comment about Hadoop 3 Added javadoc in TimelineReaderServer#setupOptions Rebased on latest trunk And my responses to your remaining feedback: I couldn't put in a diamond operator there; it didn't like that. The only removed class is SslSelectChannelConnectorSecure , which was marked private, so I think we're okay removing it. I'm not sure I understand your comment about the space and the semicolon. I know I updated the @Produces a lot, but as far as I can tell, they're all identical. Can you give me some file names and lines where they differ? On the test timeout increase, I had to increase it because the server now takes longer to shutdown. I did some checking, and with Jetty 9, it takes ~3000ms, but with Jetty 6, it takes only ~100ms. Due to this, I had to increase the timeout. I'm not sure there's much we can do about this; it's mostly Jetty code and I didn't change much in the stop method. I looks like the way to get the utf-8 charset as a constant String is via StandardCharsets.UTF_8.name() . Any suggestions on an easy way to do that? There's over 600 instances of this in the patch. I agree that it's generally good to put messages into assert statements, but I don't think that's necessary when it's obvious what it's checking and what is wrong with it. We're clearly checking the response type here, and when it's incorrect, you get an obvious message like this: org.junit.ComparisonFailure: Expected :application/json; charset=foo Actual :application/json; charset=utf-8 Adding a message like "Expected response type X but got response type Y" won't be any more helpful than this.
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 75 new or modified test files.
          0 mvndep 1m 37s Maven dependency ordering for branch
          +1 mvninstall 7m 42s trunk passed
          +1 compile 7m 44s trunk passed
          +1 checkstyle 2m 7s trunk passed
          +1 mvnsite 15m 3s trunk passed
          +1 mvneclipse 7m 54s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          -1 findbugs 0m 27s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.
          +1 javadoc 11m 5s trunk passed
          0 mvndep 0m 28s Maven dependency ordering for patch
          +1 mvninstall 15m 15s the patch passed
          +1 compile 8m 47s the patch passed
          +1 javac 8m 47s the patch passed
          -0 checkstyle 2m 22s root: The patch generated 42 new + 2541 unchanged - 43 fixed = 2583 total (was 2584)
          +1 mvnsite 15m 49s the patch passed
          +1 mvneclipse 8m 47s the patch passed
          -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 17s The patch 4277 line(s) with tabs.
          +1 xml 0m 32s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          -1 findbugs 0m 38s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 11m 36s the patch passed
          +1 unit 0m 14s hadoop-project in the patch passed.
          +1 unit 0m 18s hadoop-maven-plugins in the patch passed.
          +1 unit 3m 10s hadoop-auth in the patch passed.
          +1 unit 0m 16s hadoop-auth-examples in the patch passed.
          +1 unit 8m 25s hadoop-common in the patch passed.
          +1 unit 0m 29s hadoop-nfs in the patch passed.
          +1 unit 2m 9s hadoop-kms in the patch passed.
          +1 unit 53m 52s hadoop-hdfs in the patch passed.
          +1 unit 3m 44s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 1m 50s hadoop-hdfs-nfs in the patch passed.
          +1 unit 2m 24s hadoop-yarn-common in the patch passed.
          +1 unit 14m 53s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 0m 30s hadoop-yarn-server-web-proxy in the patch passed.
          -1 unit 2m 48s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          +1 unit 0m 51s hadoop-yarn-server-timelineservice in the patch passed.
          -1 unit 35m 10s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 16m 12s hadoop-yarn-client in the patch passed.
          +1 unit 1m 18s hadoop-yarn-server-timeline-pluginstorage in the patch passed.
          +1 unit 4m 10s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed.
          -1 unit 127m 37s hadoop-mapreduce-client in the patch failed.
          +1 unit 0m 36s hadoop-mapreduce-client-shuffle in the patch passed.
          +1 unit 8m 52s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 23s hadoop-mapreduce-client-hs in the patch passed.
          +1 unit 101m 14s hadoop-mapreduce-client-jobclient in the patch passed.
          +1 unit 1m 40s hadoop-azure in the patch passed.
          +1 unit 0m 26s hadoop-client in the patch passed.
          +1 unit 1m 11s hadoop-sls in the patch passed.
          +1 unit 2m 37s hadoop-azure-datalake in the patch passed.
          -1 unit 143m 16s hadoop-mapreduce-project in the patch failed.
          -1 asflicense 16m 16s The patch generated 4 ASF License warnings.
          748m 55s



          Reason Tests
          FindBugs module:hadoop-maven-plugins
            Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:[line 105]
          Failed junit tests hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices
            hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832609/HADOOP-10075.008.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 3866c91b402d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 96b1266
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/whitespace-tabs.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-project hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 75 new or modified test files. 0 mvndep 1m 37s Maven dependency ordering for branch +1 mvninstall 7m 42s trunk passed +1 compile 7m 44s trunk passed +1 checkstyle 2m 7s trunk passed +1 mvnsite 15m 3s trunk passed +1 mvneclipse 7m 54s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project -1 findbugs 0m 27s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings. +1 javadoc 11m 5s trunk passed 0 mvndep 0m 28s Maven dependency ordering for patch +1 mvninstall 15m 15s the patch passed +1 compile 8m 47s the patch passed +1 javac 8m 47s the patch passed -0 checkstyle 2m 22s root: The patch generated 42 new + 2541 unchanged - 43 fixed = 2583 total (was 2584) +1 mvnsite 15m 49s the patch passed +1 mvneclipse 8m 47s the patch passed -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 17s The patch 4277 line(s) with tabs. +1 xml 0m 32s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project -1 findbugs 0m 38s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 11m 36s the patch passed +1 unit 0m 14s hadoop-project in the patch passed. +1 unit 0m 18s hadoop-maven-plugins in the patch passed. +1 unit 3m 10s hadoop-auth in the patch passed. +1 unit 0m 16s hadoop-auth-examples in the patch passed. +1 unit 8m 25s hadoop-common in the patch passed. +1 unit 0m 29s hadoop-nfs in the patch passed. +1 unit 2m 9s hadoop-kms in the patch passed. +1 unit 53m 52s hadoop-hdfs in the patch passed. +1 unit 3m 44s hadoop-hdfs-httpfs in the patch passed. +1 unit 1m 50s hadoop-hdfs-nfs in the patch passed. +1 unit 2m 24s hadoop-yarn-common in the patch passed. +1 unit 14m 53s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 0m 30s hadoop-yarn-server-web-proxy in the patch passed. -1 unit 2m 48s hadoop-yarn-server-applicationhistoryservice in the patch failed. +1 unit 0m 51s hadoop-yarn-server-timelineservice in the patch passed. -1 unit 35m 10s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 16m 12s hadoop-yarn-client in the patch passed. +1 unit 1m 18s hadoop-yarn-server-timeline-pluginstorage in the patch passed. +1 unit 4m 10s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed. -1 unit 127m 37s hadoop-mapreduce-client in the patch failed. +1 unit 0m 36s hadoop-mapreduce-client-shuffle in the patch passed. +1 unit 8m 52s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 23s hadoop-mapreduce-client-hs in the patch passed. +1 unit 101m 14s hadoop-mapreduce-client-jobclient in the patch passed. +1 unit 1m 40s hadoop-azure in the patch passed. +1 unit 0m 26s hadoop-client in the patch passed. +1 unit 1m 11s hadoop-sls in the patch passed. +1 unit 2m 37s hadoop-azure-datalake in the patch passed. -1 unit 143m 16s hadoop-mapreduce-project in the patch failed. -1 asflicense 16m 16s The patch generated 4 ASF License warnings. 748m 55s Reason Tests FindBugs module:hadoop-maven-plugins   Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java: [line 105] Failed junit tests hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832609/HADOOP-10075.008.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 3866c91b402d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 96b1266 Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10728/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Karthik Kambatla added a comment -

          Robert Kanter - mind throwing this on RB or Github PR for easier review?

          Show
          Karthik Kambatla added a comment - Robert Kanter - mind throwing this on RB or Github PR for easier review?
          Hide
          Ravi Prakash added a comment -

          Thanks a lot for the massive amount of effort Robert and others.
          The patch is deceptively big. A lot of the bulk is added because of renaming classes or adding charset or just the logging method. Thanks also for writing the maven plugin Robert.

          Is there a reason you changed httpServer.addContext(uiWebAppContext, true); to httpServer.addHandlerAtFront(uiWebAppContext); in ApplicationHistoryServer?

          The main changes are in HttpServer2 and I am going through them right now. Will hopefully get done soon.

          Show
          Ravi Prakash added a comment - Thanks a lot for the massive amount of effort Robert and others. The patch is deceptively big. A lot of the bulk is added because of renaming classes or adding charset or just the logging method. Thanks also for writing the maven plugin Robert. Is there a reason you changed httpServer.addContext(uiWebAppContext, true); to httpServer.addHandlerAtFront(uiWebAppContext); in ApplicationHistoryServer? The main changes are in HttpServer2 and I am going through them right now. Will hopefully get done soon.
          Hide
          Robert Kanter added a comment -

          Is there a reason you changed httpServer.addContext(uiWebAppContext, true); to httpServer.addHandlerAtFront(uiWebAppContext); in ApplicationHistoryServer?

          The order of the handlers is important when Jetty is trying to figure out which Servlet to use. To get the AHS to work correctly there, I had to make sure that uiWebAppContext was first in the list, even though we add it later.

          Thanks for taking a look Ravi, I know it's a discouraging patch to look at
          I'm currently working on making the charset changes a constant (I had a good idea to make this a little easier), and I'll post an updated patch. I'll also post it on RB to make it easier to comment on; I had trouble finding some of the things Daniel was talking about in his feedback.

          Show
          Robert Kanter added a comment - Is there a reason you changed httpServer.addContext(uiWebAppContext, true); to httpServer.addHandlerAtFront(uiWebAppContext); in ApplicationHistoryServer? The order of the handlers is important when Jetty is trying to figure out which Servlet to use. To get the AHS to work correctly there, I had to make sure that uiWebAppContext was first in the list, even though we add it later. Thanks for taking a look Ravi, I know it's a discouraging patch to look at I'm currently working on making the charset changes a constant (I had a good idea to make this a little easier), and I'll post an updated patch. I'll also post it on RB to make it easier to comment on; I had trouble finding some of the things Daniel was talking about in his feedback.
          Hide
          Robert Kanter added a comment -

          The 009 patch:

          • Adds a constant for the "charset=utf-8" string. It doesn't do this in TestTimelineReaderWebServicesHBaseStorage because that module uses Hadoop Common 2.5, which doesn't have this new constant.

          I also wasn't able to upload the patch to ReviewBoard.

          Show
          Robert Kanter added a comment - The 009 patch: Adds a constant for the "charset=utf-8" string. It doesn't do this in TestTimelineReaderWebServicesHBaseStorage because that module uses Hadoop Common 2.5, which doesn't have this new constant. I also wasn't able to upload the patch to ReviewBoard.
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 75 new or modified test files.
          0 mvndep 1m 38s Maven dependency ordering for branch
          +1 mvninstall 6m 51s trunk passed
          +1 compile 6m 43s trunk passed
          +1 checkstyle 2m 0s trunk passed
          +1 mvnsite 13m 55s trunk passed
          +1 mvneclipse 7m 44s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          -1 findbugs 0m 22s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.
          +1 javadoc 9m 25s trunk passed
          0 mvndep 0m 26s Maven dependency ordering for patch
          +1 mvninstall 12m 4s the patch passed
          +1 compile 6m 48s the patch passed
          +1 javac 6m 48s the patch passed
          -0 checkstyle 2m 8s root: The patch generated 56 new + 2528 unchanged - 43 fixed = 2584 total (was 2571)
          +1 mvnsite 15m 25s the patch passed
          +1 mvneclipse 8m 31s the patch passed
          -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 19s The patch 4277 line(s) with tabs.
          +1 xml 0m 28s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project
          -1 findbugs 1m 20s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 11m 16s the patch passed
          +1 unit 0m 13s hadoop-project in the patch passed.
          +1 unit 0m 16s hadoop-maven-plugins in the patch passed.
          +1 unit 3m 8s hadoop-auth in the patch passed.
          +1 unit 0m 16s hadoop-auth-examples in the patch passed.
          +1 unit 7m 27s hadoop-common in the patch passed.
          +1 unit 0m 27s hadoop-nfs in the patch passed.
          +1 unit 2m 11s hadoop-kms in the patch passed.
          -1 unit 56m 23s hadoop-hdfs in the patch failed.
          -1 unit 0m 36s hadoop-hdfs-httpfs in the patch failed.
          -1 unit 0m 20s hadoop-hdfs-nfs in the patch failed.
          -1 unit 0m 32s hadoop-yarn-common in the patch failed.
          -1 unit 0m 27s hadoop-yarn-server-nodemanager in the patch failed.
          -1 unit 0m 19s hadoop-yarn-server-web-proxy in the patch failed.
          -1 unit 0m 22s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          -1 unit 0m 43s hadoop-yarn-server-timelineservice in the patch failed.
          -1 unit 0m 29s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 unit 0m 24s hadoop-yarn-client in the patch failed.
          -1 unit 0m 19s hadoop-yarn-server-timeline-pluginstorage in the patch failed.
          -1 unit 0m 23s hadoop-yarn-server-timelineservice-hbase-tests in the patch failed.
          -1 unit 0m 24s hadoop-mapreduce-client in the patch failed.
          -1 unit 0m 22s hadoop-mapreduce-client-shuffle in the patch failed.
          -1 unit 0m 22s hadoop-mapreduce-client-app in the patch failed.
          -1 unit 0m 22s hadoop-mapreduce-client-hs in the patch failed.
          -1 unit 0m 27s hadoop-mapreduce-client-jobclient in the patch failed.
          -1 unit 0m 22s hadoop-azure in the patch failed.
          +1 unit 0m 16s hadoop-client in the patch passed.
          -1 unit 0m 24s hadoop-sls in the patch failed.
          -1 unit 0m 18s hadoop-azure-datalake in the patch failed.
          -1 unit 0m 24s hadoop-mapreduce-project in the patch failed.
          -1 asflicense 15m 20s The patch generated 4 ASF License warnings.
          277m 9s



          Reason Tests
          FindBugs module:hadoop-maven-plugins
            Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:[line 105]
          Failed junit tests hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833441/HADOOP-10075.009.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux e5b7175a12e6 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0007360
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/whitespace-tabs.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-nfs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timeline-pluginstorage.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-datalake.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-project hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 75 new or modified test files. 0 mvndep 1m 38s Maven dependency ordering for branch +1 mvninstall 6m 51s trunk passed +1 compile 6m 43s trunk passed +1 checkstyle 2m 0s trunk passed +1 mvnsite 13m 55s trunk passed +1 mvneclipse 7m 44s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project -1 findbugs 0m 22s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings. +1 javadoc 9m 25s trunk passed 0 mvndep 0m 26s Maven dependency ordering for patch +1 mvninstall 12m 4s the patch passed +1 compile 6m 48s the patch passed +1 javac 6m 48s the patch passed -0 checkstyle 2m 8s root: The patch generated 56 new + 2528 unchanged - 43 fixed = 2584 total (was 2571) +1 mvnsite 15m 25s the patch passed +1 mvneclipse 8m 31s the patch passed -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 19s The patch 4277 line(s) with tabs. +1 xml 0m 28s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client hadoop-mapreduce-project -1 findbugs 1m 20s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 11m 16s the patch passed +1 unit 0m 13s hadoop-project in the patch passed. +1 unit 0m 16s hadoop-maven-plugins in the patch passed. +1 unit 3m 8s hadoop-auth in the patch passed. +1 unit 0m 16s hadoop-auth-examples in the patch passed. +1 unit 7m 27s hadoop-common in the patch passed. +1 unit 0m 27s hadoop-nfs in the patch passed. +1 unit 2m 11s hadoop-kms in the patch passed. -1 unit 56m 23s hadoop-hdfs in the patch failed. -1 unit 0m 36s hadoop-hdfs-httpfs in the patch failed. -1 unit 0m 20s hadoop-hdfs-nfs in the patch failed. -1 unit 0m 32s hadoop-yarn-common in the patch failed. -1 unit 0m 27s hadoop-yarn-server-nodemanager in the patch failed. -1 unit 0m 19s hadoop-yarn-server-web-proxy in the patch failed. -1 unit 0m 22s hadoop-yarn-server-applicationhistoryservice in the patch failed. -1 unit 0m 43s hadoop-yarn-server-timelineservice in the patch failed. -1 unit 0m 29s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 0m 24s hadoop-yarn-client in the patch failed. -1 unit 0m 19s hadoop-yarn-server-timeline-pluginstorage in the patch failed. -1 unit 0m 23s hadoop-yarn-server-timelineservice-hbase-tests in the patch failed. -1 unit 0m 24s hadoop-mapreduce-client in the patch failed. -1 unit 0m 22s hadoop-mapreduce-client-shuffle in the patch failed. -1 unit 0m 22s hadoop-mapreduce-client-app in the patch failed. -1 unit 0m 22s hadoop-mapreduce-client-hs in the patch failed. -1 unit 0m 27s hadoop-mapreduce-client-jobclient in the patch failed. -1 unit 0m 22s hadoop-azure in the patch failed. +1 unit 0m 16s hadoop-client in the patch passed. -1 unit 0m 24s hadoop-sls in the patch failed. -1 unit 0m 18s hadoop-azure-datalake in the patch failed. -1 unit 0m 24s hadoop-mapreduce-project in the patch failed. -1 asflicense 15m 20s The patch generated 4 ASF License warnings. 277m 9s Reason Tests FindBugs module:hadoop-maven-plugins   Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java: [line 105] Failed junit tests hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833441/HADOOP-10075.009.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux e5b7175a12e6 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0007360 Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-nfs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timeline-pluginstorage.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-datalake.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-unit-hadoop-mapreduce-project.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10793/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Robert Kanter added a comment -

          Karthik Kambatla

          I've put the 009 patch (after a rebase on the latest trunk) on github if that's easier to review:
          https://github.com/rkanter/hadoop/commit/645818889bf756efadfe6b7392faeeb1af3db383

          Show
          Robert Kanter added a comment - Karthik Kambatla I've put the 009 patch (after a rebase on the latest trunk) on github if that's easier to review: https://github.com/rkanter/hadoop/commit/645818889bf756efadfe6b7392faeeb1af3db383
          Hide
          Ravi Prakash added a comment -

          Thanks Robert!

          • Why did you have to add ep.getPort() == -2 in HttpServer2.Builder.build()? The javadoc for URI never claims to return a -2. Is it bleeding in from ServerConnector.getLocalPort() somehow?
          • HttpServer2.createDefaultChannelConnector() has started taking a server as an argument. Is that really necessary? Or are we always asking to pass in an instance of Server to this method that we already have access to?

          My notes (and not necessarily questions, but if you have more info, it'd be great to document here):

          Show
          Ravi Prakash added a comment - Thanks Robert! Why did you have to add ep.getPort() == -2 in HttpServer2.Builder.build() ? The javadoc for URI never claims to return a -2. Is it bleeding in from ServerConnector.getLocalPort() somehow? HttpServer2.createDefaultChannelConnector() has started taking a server as an argument. Is that really necessary? Or are we always asking to pass in an instance of Server to this method that we already have access to? My notes (and not necessarily questions, but if you have more info, it'd be great to document here): http://www.eclipse.org/jetty/documentation/current/architecture.html#basic-architecture and http://www.eclipse.org/jetty/documentation/current/embedding-jetty.html are good pages to read up. conn.addFirstConnectionFactory( new SslConnectionFactory(sslContextFactory, HttpVersion.HTTP_1_1.asString())); http://archive.eclipse.org/jetty/9.0.0.M3/apidocs/org/eclipse/jetty/server/ssl/SslSelectChannelConnector.html suggests to use SelectChannelConnector . Couldn't find any documentation on how to do that. c.setLowResourceMaxIdleTime(10000); has been changed to c.setIdleTimeout(10000); This just means that timeout will occur after 10s whether or not there were more than LowResourcesConnections. I'm fine with this change. We haven't set c.setResolveNames(false); This thread claims that by default names will not be resolved, so I'm fine with this change. Tagging Min Shen who had put in original arguments. addNoCacheFilter(webAppContext); was changed to addNoCacheFilter(logContext); Was this a bug earlier? addInternalServlet() removes existing path bindings now. I don't see what else we could do about it. Fine by me.
          Hide
          Robert Kanter added a comment -

          Thanks Ravi Prakash for taking a look.
          Here's my responses to your questions/notes:

          • On your -2 port question: I was maybe a bit overzelous in updating -1 port checks to -2. I think this should only happen on ServerConnector.getLocalPort(). I'll change this to only check of -1.
          • HttpServer2.createDefaultChannelConnector() is static, so it doesn't have access to the Server instance unless we pass it.
          • The Javadoc says "use SelectChannelConnector with SslContextFactory". I also couldn't find anything on SelectChannelConnector, but I am using SslContextFactory with a ServerConnector. The fact that SelectChannelConnector isn't hyperlinked in the Javadoc and I can't find a class for it makes me think it's a typo or mistake. ServerConnector's Javadoc does say that it can work with SSL. I have also tested SSL and it works with the current patch. I don't remember where, but I did look at some examples when figuring out the SSL stuff, and it was done this way.
          • On the addNoCacheFilter change: Yes, I believe this was a bug earlier; though I could be wrong.

          Given that the -2 port change is trivial, I'll wait on more feedback before uploading a new patch version with that change.

          Show
          Robert Kanter added a comment - Thanks Ravi Prakash for taking a look. Here's my responses to your questions/notes: On your -2 port question: I was maybe a bit overzelous in updating -1 port checks to -2. I think this should only happen on ServerConnector.getLocalPort() . I'll change this to only check of -1. HttpServer2.createDefaultChannelConnector() is static, so it doesn't have access to the Server instance unless we pass it. The Javadoc says "use SelectChannelConnector with SslContextFactory". I also couldn't find anything on SelectChannelConnector , but I am using SslContextFactory with a ServerConnector . The fact that SelectChannelConnector isn't hyperlinked in the Javadoc and I can't find a class for it makes me think it's a typo or mistake. ServerConnector 's Javadoc does say that it can work with SSL. I have also tested SSL and it works with the current patch. I don't remember where, but I did look at some examples when figuring out the SSL stuff, and it was done this way. On the addNoCacheFilter change: Yes, I believe this was a bug earlier; though I could be wrong. Given that the -2 port change is trivial, I'll wait on more feedback before uploading a new patch version with that change.
          Hide
          Ravi Prakash added a comment -

          Thanks Robert! I think I am done with my feedback. If all the tests that passed earlier, would pass with the new patch, I'm happy to +1 it.

          Show
          Ravi Prakash added a comment - Thanks Robert! I think I am done with my feedback. If all the tests that passed earlier, would pass with the new patch, I'm happy to +1 it.
          Hide
          Daniel Templeton added a comment -

          Latest patch looks great. One more round of quibbles:

          • Seems like maybe 1024 * 64 should be a constant since it appears several times. It's also still in there as 1024*64 a few times.
          • In TestHttpServer, it would be better to use the constants instead of "text/plain;charset=utf-8". (That, by the way, is what I meant with you stripping the space after the semicolon. You stripped it here, but then added the space everywhere else.)
          • In MiniKMS, you have
                      ((ServerConnector)server.getConnectors()[0]).getHost() + ":" +
                      ((ServerConnector)server.getConnectors()[0]).getLocalPort());

            I believe the convention is to have the + at the start of the next line. Same thing in JobEndNotifier.

          • In ResourceGzMojo you should probably catch Exception instead of Throwable:
                } catch (Throwable t) {
                  throw new MojoExecutionException(t.toString(), t);
                }

            and

                    } catch (Throwable t) {
                      this.throwable = t;
                    }
                  } catch (Throwable t) {
                    this.throwable = t;
                  }
          Show
          Daniel Templeton added a comment - Latest patch looks great. One more round of quibbles: Seems like maybe 1024 * 64 should be a constant since it appears several times. It's also still in there as 1024*64 a few times. In TestHttpServer , it would be better to use the constants instead of "text/plain;charset=utf-8" . (That, by the way, is what I meant with you stripping the space after the semicolon. You stripped it here, but then added the space everywhere else.) In MiniKMS , you have ((ServerConnector)server.getConnectors()[0]).getHost() + ":" + ((ServerConnector)server.getConnectors()[0]).getLocalPort()); I believe the convention is to have the + at the start of the next line. Same thing in JobEndNotifier . In ResourceGzMojo you should probably catch Exception instead of Throwable : } catch (Throwable t) { throw new MojoExecutionException(t.toString(), t); } and } catch (Throwable t) { this .throwable = t; } } catch (Throwable t) { this .throwable = t; }
          Hide
          Robert Kanter added a comment -

          The 010 patch:

          • Addresses Ravi Prakash's comment about the -2 check
          • Relevant CheckStyle warnings. Also, I think it's confused about indentation levels for lambda expressions.
          • Replaces 1024 * 64 with a constant
          • Uses constants in TestHttpServer for the types. However, for some reason, it keeps being without a space, even though I'm directly setting the type in the servlet with a space. Even stranger, if I directly set the type in the servlet to a different charset (e.g. utf-16), it does keep the space. So I'm not really sure what's going on here...
          • Moved + signs as per Daniel Templeton's comments
          • Rebased on latest trunk

          Here's the changes in github if that's easier to look at:
          https://github.com/rkanter/hadoop/commit/546a7e36a7eeacf4b68fe31a1a09b9badc6b7560

          I didn't remove catching throwable in ResourceGzMojo. The other Hadoop maven plugins also do this, and I think the idea is that Maven knows how to nicely handle a MojoExecutionException and report that properly to the user.

          Show
          Robert Kanter added a comment - The 010 patch: Addresses Ravi Prakash 's comment about the -2 check Relevant CheckStyle warnings. Also, I think it's confused about indentation levels for lambda expressions. Replaces 1024 * 64 with a constant Uses constants in TestHttpServer for the types. However, for some reason, it keeps being without a space, even though I'm directly setting the type in the servlet with a space. Even stranger, if I directly set the type in the servlet to a different charset (e.g. utf-16 ), it does keep the space. So I'm not really sure what's going on here... Moved + signs as per Daniel Templeton 's comments Rebased on latest trunk Here's the changes in github if that's easier to look at: https://github.com/rkanter/hadoop/commit/546a7e36a7eeacf4b68fe31a1a09b9badc6b7560 I didn't remove catching throwable in ResourceGzMojo . The other Hadoop maven plugins also do this, and I think the idea is that Maven knows how to nicely handle a MojoExecutionException and report that properly to the user.
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 1s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 75 new or modified test files.
          0 mvndep 2m 39s Maven dependency ordering for branch
          +1 mvninstall 7m 17s trunk passed
          +1 compile 6m 54s trunk passed
          +1 checkstyle 2m 3s trunk passed
          +1 mvnsite 9m 30s trunk passed
          +1 mvneclipse 1m 5s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client . hadoop-mapreduce-project
          -1 findbugs 0m 24s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.
          +1 javadoc 4m 34s trunk passed
          0 mvndep 0m 26s Maven dependency ordering for patch
          +1 mvninstall 20m 3s the patch passed
          +1 compile 6m 57s the patch passed
          +1 javac 6m 57s the patch passed
          -0 checkstyle 2m 7s root: The patch generated 25 new + 2508 unchanged - 71 fixed = 2533 total (was 2579)
          +1 mvnsite 10m 59s the patch passed
          +1 mvneclipse 1m 19s the patch passed
          -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 16s The patch 4278 line(s) with tabs.
          +1 xml 0m 30s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client . hadoop-mapreduce-project
          -1 findbugs 0m 37s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 4m 24s the patch passed
          -1 unit 93m 38s root in the patch failed.
          -1 asflicense 15m 30s The patch generated 6 ASF License warnings.
          256m 21s



          Reason Tests
          FindBugs module:hadoop-maven-plugins
            Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:[line 105]
          Failed junit tests hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834271/HADOOP-10075.010.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux bd17c7d3b320 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e9c4616
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/whitespace-tabs.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-project hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake . hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 75 new or modified test files. 0 mvndep 2m 39s Maven dependency ordering for branch +1 mvninstall 7m 17s trunk passed +1 compile 6m 54s trunk passed +1 checkstyle 2m 3s trunk passed +1 mvnsite 9m 30s trunk passed +1 mvneclipse 1m 5s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client . hadoop-mapreduce-project -1 findbugs 0m 24s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings. +1 javadoc 4m 34s trunk passed 0 mvndep 0m 26s Maven dependency ordering for patch +1 mvninstall 20m 3s the patch passed +1 compile 6m 57s the patch passed +1 javac 6m 57s the patch passed -0 checkstyle 2m 7s root: The patch generated 25 new + 2508 unchanged - 71 fixed = 2533 total (was 2579) +1 mvnsite 10m 59s the patch passed +1 mvneclipse 1m 19s the patch passed -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 16s The patch 4278 line(s) with tabs. +1 xml 0m 30s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client . hadoop-mapreduce-project -1 findbugs 0m 37s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 4m 24s the patch passed -1 unit 93m 38s root in the patch failed. -1 asflicense 15m 30s The patch generated 6 ASF License warnings. 256m 21s Reason Tests FindBugs module:hadoop-maven-plugins   Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java: [line 105] Failed junit tests hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834271/HADOOP-10075.010.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux bd17c7d3b320 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e9c4616 Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake . hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10832/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 75 new or modified test files.
          0 mvndep 1m 37s Maven dependency ordering for branch
          +1 mvninstall 6m 47s trunk passed
          +1 compile 6m 52s trunk passed
          +1 checkstyle 1m 59s trunk passed
          +1 mvnsite 10m 0s trunk passed
          +1 mvneclipse 1m 3s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client . hadoop-mapreduce-project
          -1 findbugs 0m 24s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.
          +1 javadoc 4m 23s trunk passed
          0 mvndep 0m 26s Maven dependency ordering for patch
          +1 mvninstall 19m 57s the patch passed
          +1 compile 13m 32s the patch passed
          +1 javac 13m 32s the patch passed
          -0 checkstyle 3m 47s root: The patch generated 25 new + 2510 unchanged - 71 fixed = 2535 total (was 2581)
          +1 mvnsite 9m 43s the patch passed
          +1 mvneclipse 1m 15s the patch passed
          -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 19s The patch 4278 line(s) with tabs.
          +1 xml 0m 30s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client . hadoop-mapreduce-project
          -1 findbugs 0m 37s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 5m 13s the patch passed
          -1 unit 98m 20s root in the patch failed.
          -1 asflicense 15m 29s The patch generated 6 ASF License warnings.
          268m 35s



          Reason Tests
          FindBugs module:hadoop-maven-plugins
            Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:[line 105]
          Failed junit tests hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager
            hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServices



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834271/HADOOP-10075.010.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 26e77fadce7d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 23d7d53
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/whitespace-tabs.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-project hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake . hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 75 new or modified test files. 0 mvndep 1m 37s Maven dependency ordering for branch +1 mvninstall 6m 47s trunk passed +1 compile 6m 52s trunk passed +1 checkstyle 1m 59s trunk passed +1 mvnsite 10m 0s trunk passed +1 mvneclipse 1m 3s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client . hadoop-mapreduce-project -1 findbugs 0m 24s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings. +1 javadoc 4m 23s trunk passed 0 mvndep 0m 26s Maven dependency ordering for patch +1 mvninstall 19m 57s the patch passed +1 compile 13m 32s the patch passed +1 javac 13m 32s the patch passed -0 checkstyle 3m 47s root: The patch generated 25 new + 2510 unchanged - 71 fixed = 2535 total (was 2581) +1 mvnsite 9m 43s the patch passed +1 mvneclipse 1m 15s the patch passed -1 whitespace 0m 0s The patch has 582 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 19s The patch 4278 line(s) with tabs. +1 xml 0m 30s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client . hadoop-mapreduce-project -1 findbugs 0m 37s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 5m 13s the patch passed -1 unit 98m 20s root in the patch failed. -1 asflicense 15m 29s The patch generated 6 ASF License warnings. 268m 35s Reason Tests FindBugs module:hadoop-maven-plugins   Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java: [line 105] Failed junit tests hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager   hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServices Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834271/HADOOP-10075.010.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 26e77fadce7d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 23d7d53 Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake . hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10857/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          John Zhuge added a comment - - edited

          Trailing white spaces in patch 010 at line 5624, 5631-5633, 8125, 8131, 8159-8160, 8173-8175, 8178, and many others.

          Show
          John Zhuge added a comment - - edited Trailing white spaces in patch 010 at line 5624, 5631-5633, 8125, 8131, 8159-8160, 8173-8175, 8178, and many others.
          Hide
          Robert Kanter added a comment -

          The 011 patch:

          • Removes trailing whitespace from js files
          • Replaces tabs with spaces from js files
          • Fixed broken unit tests in TestTimelineReaderWebServices that came in during an earlier rebase
          • rebased on latest trunk
          Show
          Robert Kanter added a comment - The 011 patch: Removes trailing whitespace from js files Replaces tabs with spaces from js files Fixed broken unit tests in TestTimelineReaderWebServices that came in during an earlier rebase rebased on latest trunk
          Hide
          Ravi Prakash added a comment -

          Thanks Robert for your work. I'm trying to run all the unit tests which on the computer that I can spare takes 10 hours. If the jenkins bot came back with a +1, it'd be much easier for me to +1 the patch too.

          Show
          Ravi Prakash added a comment - Thanks Robert for your work. I'm trying to run all the unit tests which on the computer that I can spare takes 10 hours. If the jenkins bot came back with a +1, it'd be much easier for me to +1 the patch too.
          Hide
          Robert Kanter added a comment -

          I should have hopefully fixed the remaining test failures other than TestQueuingContainerManager (see YARN-5377).

          Show
          Robert Kanter added a comment - I should have hopefully fixed the remaining test failures other than TestQueuingContainerManager (see YARN-5377 ).
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 75 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 51s trunk passed
          +1 compile 7m 25s trunk passed
          +1 checkstyle 2m 7s trunk passed
          +1 mvnsite 10m 40s trunk passed
          +1 mvneclipse 1m 7s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client . hadoop-mapreduce-project
          -1 findbugs 0m 25s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.
          +1 javadoc 4m 24s trunk passed
          0 mvndep 0m 26s Maven dependency ordering for patch
          +1 mvninstall 19m 38s the patch passed
          +1 compile 7m 16s the patch passed
          +1 javac 7m 16s the patch passed
          -0 checkstyle 2m 7s root: The patch generated 24 new + 2505 unchanged - 71 fixed = 2529 total (was 2576)
          +1 mvnsite 9m 58s the patch passed
          +1 mvneclipse 1m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 33s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client . hadoop-mapreduce-project
          -1 findbugs 0m 40s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 4m 29s the patch passed
          -1 unit 97m 6s root in the patch failed.
          -1 asflicense 15m 7s The patch generated 6 ASF License warnings.
          257m 46s



          Reason Tests
          FindBugs module:hadoop-maven-plugins
            Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:[line 105]
          Failed junit tests hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
            hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835003/HADOOP-10075.011.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 518be3c0a6b5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a1a0281
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-project hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake . hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 75 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 51s trunk passed +1 compile 7m 25s trunk passed +1 checkstyle 2m 7s trunk passed +1 mvnsite 10m 40s trunk passed +1 mvneclipse 1m 7s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client . hadoop-mapreduce-project -1 findbugs 0m 25s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings. +1 javadoc 4m 24s trunk passed 0 mvndep 0m 26s Maven dependency ordering for patch +1 mvninstall 19m 38s the patch passed +1 compile 7m 16s the patch passed +1 javac 7m 16s the patch passed -0 checkstyle 2m 7s root: The patch generated 24 new + 2505 unchanged - 71 fixed = 2529 total (was 2576) +1 mvnsite 9m 58s the patch passed +1 mvneclipse 1m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 33s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client . hadoop-mapreduce-project -1 findbugs 0m 40s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 4m 29s the patch passed -1 unit 97m 6s root in the patch failed. -1 asflicense 15m 7s The patch generated 6 ASF License warnings. 257m 46s Reason Tests FindBugs module:hadoop-maven-plugins   Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java:ignored in org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo$GZConsumer.accept(Path) At ResourceGzMojo.java: [line 105] Failed junit tests hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery   hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835003/HADOOP-10075.011.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 518be3c0a6b5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a1a0281 Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure hadoop-client hadoop-tools/hadoop-sls hadoop-tools/hadoop-azure-datalake . hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10880/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Robert Kanter added a comment -

          The test failures are unrelated. Ravi Prakash, how did your testing go?

          Show
          Robert Kanter added a comment - The test failures are unrelated. Ravi Prakash , how did your testing go?
          Hide
          Ravi Prakash added a comment -

          Still working on it Robert! I'll try to finish by today

          Show
          Ravi Prakash added a comment - Still working on it Robert! I'll try to finish by today
          Hide
          Ravi Prakash added a comment -

          All the changes in java and pom files look good to me. I ran all the unit tests on trunk with and without patch, and the same unit tests fail, so I'm crossing my fingers that the patch doesn't introduce any new unit test failures. I also started all daemons and clicked around and saw nothing unusual. I checked that the /conf, /jmx and REST URIs still work.

          I can't submit jobs on unpatched trunk right now (it complains Could not find or load main class org.apache.hadoop.mapreduce.v2.app.MRAppMaster) but its an orthogonal issue and not affected by your patch.

          Thanks for the massive amount of effort. The 011 patch looks good to me. +1.

          Please feel free to commit it yourself. Otherwise I'm happy to do it by the end of the day.

          Show
          Ravi Prakash added a comment - All the changes in java and pom files look good to me. I ran all the unit tests on trunk with and without patch, and the same unit tests fail, so I'm crossing my fingers that the patch doesn't introduce any new unit test failures. I also started all daemons and clicked around and saw nothing unusual. I checked that the /conf, /jmx and REST URIs still work. I can't submit jobs on unpatched trunk right now (it complains Could not find or load main class org.apache.hadoop.mapreduce.v2.app.MRAppMaster ) but its an orthogonal issue and not affected by your patch. Thanks for the massive amount of effort. The 011 patch looks good to me. +1. Please feel free to commit it yourself. Otherwise I'm happy to do it by the end of the day.
          Hide
          Robert Kanter added a comment -

          Thanks Ravi Prakash. I know reviewing this and looking at the tests also took a lot of time.

          I can take care of committing it now.

          Show
          Robert Kanter added a comment - Thanks Ravi Prakash . I know reviewing this and looking at the tests also took a lot of time. I can take care of committing it now.
          Hide
          Robert Kanter added a comment -

          Thanks everyone for reviews and comments. Committed to trunk!

          Show
          Robert Kanter added a comment - Thanks everyone for reviews and comments. Committed to trunk!
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10713 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10713/)
          HADOOP-10075. Update jetty dependency to version 9 (rkanter) (rkanter: rev 5877f20f9c3f6f0afa505715e9a2ee312475af17)

          • (edit) hadoop-common-project/hadoop-nfs/pom.xml
          • (edit) hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/AuthenticatorTestCase.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/MockResourceManagerFacade.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java
          • (edit) hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/MiniKMS.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestTimelineWebServices.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/planning/TestAlignedPlanner.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServices.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFSForHA.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
          • (edit) hadoop-common-project/hadoop-common/pom.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSWithKerberos.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemTestSetup.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServerNoXAttrs.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestAuthenticationSessionCookie.java
          • (add) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/resourcegz/ResourceGzMojo.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServer.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/web/TestWebDelegationToken.java
          • (edit) hadoop-client/pom.xml
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/jquery-1.8.2.min.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/test/java/org/apache/hadoop/mapred/TestShuffleHandler.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jt/jquery.jstree.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesDelegationTokens.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebServicesTasks.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMNMInfo.java
          • (edit) hadoop-mapreduce-project/pom.xml
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebServicesJobConf.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobsQuery.java
          • (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestHTestCase.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/test/MiniDFSClusterManager.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/MyTestWebService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServicesContainers.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java
          • (edit) hadoop-tools/hadoop-sls/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • (edit) hadoop-common-project/hadoop-auth/pom.xml
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource/JerseyResource.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/MiniHadoopClusterManager.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebServicesJobs.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServices.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestTransferFsImage.java
          • (edit) hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/RequestLoggerFilter.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/TestRollingLevelDBTimelineStore.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/planning/TestGreedyReservationAgent.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServer.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfServlet.java
          • (edit) pom.xml
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/NotificationTestCase.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/JSONProvider.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsTestSetup.java
          • (edit) hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONWriter.java
          • (edit) hadoop-common-project/hadoop-auth-examples/pom.xml
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobConf.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAMRMClient.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNodeMXBean.java
          • (edit) hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesSchedulerActivities.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebServicesAttempt.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsWebServices.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FSMainOperationsBaseTest.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/jquery-ui-1.9.1.custom.min.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/webapp/TestRMWithCSRFFilter.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/AdminAuthorizedServlet.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesAttempts.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesTasks.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
          • (edit) hadoop-tools/hadoop-azure-datalake/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesForCSWithPartitions.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebServices.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpRequestLog.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobs.java
          • (edit) hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/web/SLSWebApp.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestServletFilter.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebServicesAttempts.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestAHSWebServices.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServicesApps.java
          • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/jquery-1.8.2.min.js.gz
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/pom.xml
          • (edit) hadoop-common-project/hadoop-kms/pom.xml
          • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.9.4/js/jquery.dataTables.min.js.gz
          • (edit) hadoop-project/pom.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServerNoACLs.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestHFSTestCase.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpRequestLog.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
          • (edit) hadoop-maven-plugins/pom.xml
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml
          • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/jquery-ui-1.9.1.custom.min.js.gz
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServices.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHA.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStartupProgressServlet.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/pom.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AHSWebServices.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/reader/TimelineReaderWebServices.java
          • (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/BlockBlobAppendStream.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/pom.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/JSONMapProvider.java
          • (edit) hadoop-tools/hadoop-azure/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockNM.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/reader/TimelineReaderServer.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.9.4/js/jquery.dataTables.min.js
          • (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/JettyUtils.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSNamesystemMBean.java
          • (edit) hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/collector/TimelineCollectorWebService.java
          • (delete) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SslSelectChannelConnectorSecure.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AMWebServices.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesReservation.java
          • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jt/jquery.jstree.js.gz
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/TimelineWebServices.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10713 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10713/ ) HADOOP-10075 . Update jetty dependency to version 9 (rkanter) (rkanter: rev 5877f20f9c3f6f0afa505715e9a2ee312475af17) (edit) hadoop-common-project/hadoop-nfs/pom.xml (edit) hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/AuthenticatorTestCase.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/MockResourceManagerFacade.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java (edit) hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/MiniKMS.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestTimelineWebServices.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/planning/TestAlignedPlanner.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServices.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFSForHA.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java (edit) hadoop-common-project/hadoop-common/pom.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSWithKerberos.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemTestSetup.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServerNoXAttrs.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java (edit) hadoop-hdfs-project/hadoop-hdfs/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestAuthenticationSessionCookie.java (add) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/resourcegz/ResourceGzMojo.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServer.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/web/TestWebDelegationToken.java (edit) hadoop-client/pom.xml (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/jquery-1.8.2.min.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/test/java/org/apache/hadoop/mapred/TestShuffleHandler.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jt/jquery.jstree.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesDelegationTokens.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebServicesTasks.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMNMInfo.java (edit) hadoop-mapreduce-project/pom.xml (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebServicesJobConf.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobsQuery.java (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestHTestCase.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/test/MiniDFSClusterManager.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/MyTestWebService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServicesContainers.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java (edit) hadoop-tools/hadoop-sls/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java (edit) hadoop-common-project/hadoop-auth/pom.xml (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource/JerseyResource.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/MiniHadoopClusterManager.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebServicesJobs.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServices.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestTransferFsImage.java (edit) hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/RequestLoggerFilter.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/TestRollingLevelDBTimelineStore.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/planning/TestGreedyReservationAgent.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServer.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfServlet.java (edit) pom.xml (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/NotificationTestCase.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/JSONProvider.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsTestSetup.java (edit) hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONWriter.java (edit) hadoop-common-project/hadoop-auth-examples/pom.xml (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobConf.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAMRMClient.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNodeMXBean.java (edit) hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesSchedulerActivities.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebServicesAttempt.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsWebServices.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FSMainOperationsBaseTest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/jquery-ui-1.9.1.custom.min.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/webapp/TestRMWithCSRFFilter.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/AdminAuthorizedServlet.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesAttempts.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesTasks.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java (edit) hadoop-tools/hadoop-azure-datalake/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesForCSWithPartitions.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebServices.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpRequestLog.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobs.java (edit) hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/web/SLSWebApp.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestServletFilter.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebServicesAttempts.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestAHSWebServices.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServicesApps.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/jquery-1.8.2.min.js.gz (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/pom.xml (edit) hadoop-common-project/hadoop-kms/pom.xml (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.9.4/js/jquery.dataTables.min.js.gz (edit) hadoop-project/pom.xml (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServerNoACLs.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestHFSTestCase.java (edit) hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpRequestLog.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java (edit) hadoop-maven-plugins/pom.xml (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/jquery-ui-1.9.1.custom.min.js.gz (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServices.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHA.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStartupProgressServlet.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/pom.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AHSWebServices.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/reader/TimelineReaderWebServices.java (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/BlockBlobAppendStream.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/pom.xml (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/JSONMapProvider.java (edit) hadoop-tools/hadoop-azure/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockNM.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/reader/TimelineReaderServer.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.9.4/js/jquery.dataTables.min.js (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/JettyUtils.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSNamesystemMBean.java (edit) hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/collector/TimelineCollectorWebService.java (delete) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SslSelectChannelConnectorSecure.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AMWebServices.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesReservation.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jt/jquery.jstree.js.gz (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/TimelineWebServices.java
          Hide
          Brahma Reddy Battula added a comment - - edited

          Compilation fails with following error, after this checked-in. Not going to revert, as the chnages are more..

          [ERROR] Failed to execute goal org.apache.hadoop:hadoop-maven-plugins:3.0.0-alpha2-SNAPSHOT:resource-gz (resource-gz) on
           project hadoop-common: org.apache.maven.plugin.MojoExecutionException: java.util.regex.PatternSyntaxException: Illegal/
          unsupported escape sequence near index 3
          [ERROR] D:\hadoop-trunk\hadoop\hadoop-common-project\hadoop-common\src\main\webapps\static
          [ERROR] ^
          [ERROR] -> [Help 1]
          org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.hadoop:hadoop-maven-plugins:3.
          0.0-alpha2-SNAPSHOT:resource-gz (resource-gz) on project hadoop-common: org.apache.maven.plugin.MojoExecutionException:
          java.util.regex.PatternSyntaxException: Illegal/unsupported escape sequence near index 3
          D:\hadoop-trunk\hadoop\hadoop-common-project\hadoop-common\src\main\webapps\static
             ^
                  at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
                  at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
                  at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
                  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
                  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
                  at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
                  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
                  at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
                  at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
                  at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
                  at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
                  at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
                  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
                  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
                  at java.lang.reflect.Method.invoke(Method.java:497)
                  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
                  at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
                  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
                  at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
          Caused by: org.apache.maven.plugin.MojoExecutionException: org.apache.maven.plugin.MojoExecutionException: java.util.reg
          ex.PatternSyntaxException: Illegal/unsupported escape sequence near index 3
          D:\OSCode\hadoop-trunk\hadoop\hadoop-common-project\hadoop-common\src\main\webapps\static
             ^
                  at org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo.execute(ResourceGzMojo.java:82)
                  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
                  at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
                  ... 19 more
          Caused by: org.apache.maven.plugin.MojoExecutionException: java.util.regex.PatternSyntaxException: Illegal/unsupported e
          scape sequence near index 3
          D:\hadoop-trunk\hadoop\hadoop-common-project\hadoop-common\src\main\webapps\static
          

          Following added as part of this jira,

          <execution>
                      <id>resource-gz</id>
                      <phase>generate-resources</phase>
                      <goals>
                        <goal>resource-gz</goal>
                      </goals>
                      <configuration>
                        <inputDirectory>${basedir}/src/main/webapps/static</inputDirectory>
                        <outputDirectory>${basedir}/target/webapps/static</outputDirectory>
                        <extensions>js,css</extensions>
                      </configuration>
                    </execution>
          
          Show
          Brahma Reddy Battula added a comment - - edited Compilation fails with following error, after this checked-in. Not going to revert, as the chnages are more.. [ERROR] Failed to execute goal org.apache.hadoop:hadoop-maven-plugins:3.0.0-alpha2-SNAPSHOT:resource-gz (resource-gz) on project hadoop-common: org.apache.maven.plugin.MojoExecutionException: java.util.regex.PatternSyntaxException: Illegal/ unsupported escape sequence near index 3 [ERROR] D:\hadoop-trunk\hadoop\hadoop-common-project\hadoop-common\src\main\webapps\static [ERROR] ^ [ERROR] -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.hadoop:hadoop-maven-plugins:3. 0.0-alpha2-SNAPSHOT:resource-gz (resource-gz) on project hadoop-common: org.apache.maven.plugin.MojoExecutionException: java.util.regex.PatternSyntaxException: Illegal/unsupported escape sequence near index 3 D:\hadoop-trunk\hadoop\hadoop-common-project\hadoop-common\src\main\webapps\static ^ at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352) Caused by: org.apache.maven.plugin.MojoExecutionException: org.apache.maven.plugin.MojoExecutionException: java.util.reg ex.PatternSyntaxException: Illegal/unsupported escape sequence near index 3 D:\OSCode\hadoop-trunk\hadoop\hadoop-common-project\hadoop-common\src\main\webapps\static ^ at org.apache.hadoop.maven.plugin.resourcegz.ResourceGzMojo.execute(ResourceGzMojo.java:82) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) ... 19 more Caused by: org.apache.maven.plugin.MojoExecutionException: java.util.regex.PatternSyntaxException: Illegal/unsupported e scape sequence near index 3 D:\hadoop-trunk\hadoop\hadoop-common-project\hadoop-common\src\main\webapps\static Following added as part of this jira, <execution> <id>resource-gz</id> <phase>generate-resources</phase> <goals> <goal>resource-gz</goal> </goals> <configuration> <inputDirectory>${basedir}/src/main/webapps/ static </inputDirectory> <outputDirectory>${basedir}/target/webapps/ static </outputDirectory> <extensions>js,css</extensions> </configuration> </execution>
          Hide
          Robert Kanter added a comment -

          Sorry about that Brahma Reddy Battula. I believe I've figured out the problem. It has to do with Windows filepaths and this code in ResourceGzMojo:

          File outFile = new File(outputDir, path.toFile().getCanonicalPath()
                      .replaceFirst(inputDir.getCanonicalPath(), "") + ".gz");
          

          The first argument in replaceFirst is actually a regex, so with a Windows path, you end up with an unescaped "\" and it fails.

          I've attached an addendum patch that I think should fix the problem, assuming my diagnosis is correct. Can you verify that it solves the problem? I don't have a Windows setup handy at the moment.

          Show
          Robert Kanter added a comment - Sorry about that Brahma Reddy Battula . I believe I've figured out the problem. It has to do with Windows filepaths and this code in ResourceGzMojo : File outFile = new File(outputDir, path.toFile().getCanonicalPath() .replaceFirst(inputDir.getCanonicalPath(), "") + " .gz"); The first argument in replaceFirst is actually a regex, so with a Windows path, you end up with an unescaped "\" and it fails. I've attached an addendum patch that I think should fix the problem, assuming my diagnosis is correct. Can you verify that it solves the problem? I don't have a Windows setup handy at the moment.
          Hide
          Rakesh R added a comment -

          I too faced same problem in my Windows env. I could see the issue has been resolved with this addendum patch and able to continue building. Thanks Robert Kanter.

          Show
          Rakesh R added a comment - I too faced same problem in my Windows env. I could see the issue has been resolved with this addendum patch and able to continue building. Thanks Robert Kanter .
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 55s trunk passed
          +1 compile 0m 12s trunk passed
          +1 checkstyle 0m 11s trunk passed
          +1 mvnsite 0m 13s trunk passed
          +1 mvneclipse 0m 11s trunk passed
          -1 findbugs 0m 20s hadoop-maven-plugins in trunk has 1 extant Findbugs warnings.
          +1 javadoc 0m 11s trunk passed
          +1 mvninstall 0m 10s the patch passed
          +1 compile 0m 9s the patch passed
          +1 javac 0m 9s the patch passed
          +1 checkstyle 0m 9s the patch passed
          +1 mvnsite 0m 11s the patch passed
          +1 mvneclipse 0m 7s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 24s the patch passed
          +1 javadoc 0m 8s the patch passed
          +1 unit 0m 9s hadoop-maven-plugins in the patch passed.
          -1 asflicense 14m 38s The patch generated 4 ASF License warnings.
          25m 52s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835744/HADOOP-10075_addendum.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 83571c421430 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 57187fd
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10913/artifact/patchprocess/branch-findbugs-hadoop-maven-plugins-warnings.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10913/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10913/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-maven-plugins U: hadoop-maven-plugins
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10913/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 55s trunk passed +1 compile 0m 12s trunk passed +1 checkstyle 0m 11s trunk passed +1 mvnsite 0m 13s trunk passed +1 mvneclipse 0m 11s trunk passed -1 findbugs 0m 20s hadoop-maven-plugins in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 10s the patch passed +1 compile 0m 9s the patch passed +1 javac 0m 9s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvnsite 0m 11s the patch passed +1 mvneclipse 0m 7s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 24s the patch passed +1 javadoc 0m 8s the patch passed +1 unit 0m 9s hadoop-maven-plugins in the patch passed. -1 asflicense 14m 38s The patch generated 4 ASF License warnings. 25m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835744/HADOOP-10075_addendum.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 83571c421430 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 57187fd Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10913/artifact/patchprocess/branch-findbugs-hadoop-maven-plugins-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10913/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10913/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-maven-plugins U: hadoop-maven-plugins Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10913/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Brahma Reddy Battula added a comment -

          Robert Kanter thanks for the quick patch. It's worked for me..YARN-5794 fixed the ASF License warnings. Findbugs needs to handle..

          Show
          Brahma Reddy Battula added a comment - Robert Kanter thanks for the quick patch. It's worked for me.. YARN-5794 fixed the ASF License warnings. Findbugs needs to handle..
          Hide
          Robert Kanter added a comment -

          The 002 addendum patch should now also fix the findbugs warning.

          Show
          Robert Kanter added a comment - The 002 addendum patch should now also fix the findbugs warning.
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 53s trunk passed
          +1 compile 0m 11s trunk passed
          +1 checkstyle 0m 11s trunk passed
          +1 mvnsite 0m 14s trunk passed
          +1 mvneclipse 0m 10s trunk passed
          -1 findbugs 0m 22s hadoop-maven-plugins in trunk has 1 extant Findbugs warnings.
          +1 javadoc 0m 11s trunk passed
          +1 mvninstall 0m 10s the patch passed
          +1 compile 0m 9s the patch passed
          +1 javac 0m 9s the patch passed
          +1 checkstyle 0m 8s the patch passed
          +1 mvnsite 0m 10s the patch passed
          +1 mvneclipse 0m 8s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 26s hadoop-maven-plugins generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
          +1 javadoc 0m 9s the patch passed
          +1 unit 0m 10s hadoop-maven-plugins in the patch passed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          13m 32s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835868/HADOOP-10075_addendum.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2faab728b40c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8a9388e
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10918/artifact/patchprocess/branch-findbugs-hadoop-maven-plugins-warnings.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10918/testReport/
          modules C: hadoop-maven-plugins U: hadoop-maven-plugins
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10918/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 53s trunk passed +1 compile 0m 11s trunk passed +1 checkstyle 0m 11s trunk passed +1 mvnsite 0m 14s trunk passed +1 mvneclipse 0m 10s trunk passed -1 findbugs 0m 22s hadoop-maven-plugins in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 10s the patch passed +1 compile 0m 9s the patch passed +1 javac 0m 9s the patch passed +1 checkstyle 0m 8s the patch passed +1 mvnsite 0m 10s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 26s hadoop-maven-plugins generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) +1 javadoc 0m 9s the patch passed +1 unit 0m 10s hadoop-maven-plugins in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 13m 32s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835868/HADOOP-10075_addendum.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2faab728b40c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8a9388e Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10918/artifact/patchprocess/branch-findbugs-hadoop-maven-plugins-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10918/testReport/ modules C: hadoop-maven-plugins U: hadoop-maven-plugins Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10918/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Robert Kanter added a comment - - edited

          Just to clarify, the findbugs in the Hadoop QA report is misleading. It found the previous findbugs error and gave a -1, but if you look lower, you'll see:

          hadoop-maven-plugins generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

          So it's actually fixed now, with the addendum 2 patch.

          Show
          Robert Kanter added a comment - - edited Just to clarify, the findbugs in the Hadoop QA report is misleading. It found the previous findbugs error and gave a -1, but if you look lower, you'll see: hadoop-maven-plugins generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) So it's actually fixed now, with the addendum 2 patch.
          Hide
          Daniel Templeton added a comment -

          Hmmm... Looks like the accept() method could have one fewer catch (Throwable t). The inner one is redundant.

          Show
          Daniel Templeton added a comment - Hmmm... Looks like the accept() method could have one fewer catch (Throwable t) . The inner one is redundant.
          Hide
          Robert Kanter added a comment -

          The 003 addendum patch removes the unnecessary catch.

          Show
          Robert Kanter added a comment - The 003 addendum patch removes the unnecessary catch.
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 40s trunk passed
          +1 compile 0m 12s trunk passed
          +1 checkstyle 0m 11s trunk passed
          +1 mvnsite 0m 14s trunk passed
          +1 mvneclipse 0m 10s trunk passed
          -1 findbugs 0m 23s hadoop-maven-plugins in trunk has 1 extant Findbugs warnings.
          +1 javadoc 0m 11s trunk passed
          +1 mvninstall 0m 9s the patch passed
          +1 compile 0m 10s the patch passed
          +1 javac 0m 10s the patch passed
          +1 checkstyle 0m 8s the patch passed
          +1 mvnsite 0m 11s the patch passed
          +1 mvneclipse 0m 8s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 26s hadoop-maven-plugins generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
          +1 javadoc 0m 8s the patch passed
          +1 unit 0m 10s hadoop-maven-plugins in the patch passed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          12m 18s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835868/HADOOP-10075_addendum.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 92287fe27d8b 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8a9388e
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10919/artifact/patchprocess/branch-findbugs-hadoop-maven-plugins-warnings.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10919/testReport/
          modules C: hadoop-maven-plugins U: hadoop-maven-plugins
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10919/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 40s trunk passed +1 compile 0m 12s trunk passed +1 checkstyle 0m 11s trunk passed +1 mvnsite 0m 14s trunk passed +1 mvneclipse 0m 10s trunk passed -1 findbugs 0m 23s hadoop-maven-plugins in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 9s the patch passed +1 compile 0m 10s the patch passed +1 javac 0m 10s the patch passed +1 checkstyle 0m 8s the patch passed +1 mvnsite 0m 11s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 26s hadoop-maven-plugins generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) +1 javadoc 0m 8s the patch passed +1 unit 0m 10s hadoop-maven-plugins in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 12m 18s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835868/HADOOP-10075_addendum.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 92287fe27d8b 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8a9388e Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10919/artifact/patchprocess/branch-findbugs-hadoop-maven-plugins-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10919/testReport/ modules C: hadoop-maven-plugins U: hadoop-maven-plugins Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10919/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Daniel Templeton added a comment -

          Whoops, super tiny nit.

                  if (outFile.getParentFile().isDirectory()
                      || outFile.getParentFile().mkdirs()) {
          

          Shouldn't the || be at the end of the first line, not the beginning of the second?

          Oh, and where are the unit tests?

          Show
          Daniel Templeton added a comment - Whoops, super tiny nit. if (outFile.getParentFile().isDirectory() || outFile.getParentFile().mkdirs()) { Shouldn't the || be at the end of the first line, not the beginning of the second? Oh, and where are the unit tests?
          Hide
          Robert Kanter added a comment -

          The 004 patch addresses the || nit.

          Show
          Robert Kanter added a comment - The 004 patch addresses the || nit.
          Hide
          Daniel Templeton added a comment -

          Cool. +1 Thanks, Robert Kanter.

          Show
          Daniel Templeton added a comment - Cool. +1 Thanks, Robert Kanter .
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 53s trunk passed
          +1 compile 0m 12s trunk passed
          +1 checkstyle 0m 11s trunk passed
          +1 mvnsite 0m 14s trunk passed
          +1 mvneclipse 0m 10s trunk passed
          -1 findbugs 0m 21s hadoop-maven-plugins in trunk has 1 extant Findbugs warnings.
          +1 javadoc 0m 12s trunk passed
          +1 mvninstall 0m 10s the patch passed
          +1 compile 0m 9s the patch passed
          +1 javac 0m 9s the patch passed
          +1 checkstyle 0m 9s the patch passed
          +1 mvnsite 0m 11s the patch passed
          +1 mvneclipse 0m 8s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 25s hadoop-maven-plugins generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
          +1 javadoc 0m 8s the patch passed
          +1 unit 0m 9s hadoop-maven-plugins in the patch passed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          11m 29s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10075
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835896/HADOOP-10075_addendum.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5298d081aae1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8a9388e
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10920/artifact/patchprocess/branch-findbugs-hadoop-maven-plugins-warnings.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10920/testReport/
          modules C: hadoop-maven-plugins U: hadoop-maven-plugins
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10920/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 53s trunk passed +1 compile 0m 12s trunk passed +1 checkstyle 0m 11s trunk passed +1 mvnsite 0m 14s trunk passed +1 mvneclipse 0m 10s trunk passed -1 findbugs 0m 21s hadoop-maven-plugins in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 10s the patch passed +1 compile 0m 9s the patch passed +1 javac 0m 9s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvnsite 0m 11s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 25s hadoop-maven-plugins generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) +1 javadoc 0m 8s the patch passed +1 unit 0m 9s hadoop-maven-plugins in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 11m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10075 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835896/HADOOP-10075_addendum.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5298d081aae1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8a9388e Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10920/artifact/patchprocess/branch-findbugs-hadoop-maven-plugins-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10920/testReport/ modules C: hadoop-maven-plugins U: hadoop-maven-plugins Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10920/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Robert Kanter added a comment -

          Thanks for the review Daniel Templeton plus Rakesh R and Brahma Reddy Battula for verifying the fix. The addendum patch has been committed to trunk!

          Show
          Robert Kanter added a comment - Thanks for the review Daniel Templeton plus Rakesh R and Brahma Reddy Battula for verifying the fix. The addendum patch has been committed to trunk!
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10726 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10726/)
          HADOOP-10075. addendum to fix compilation on Windows (rkanter: rev ebb88231f802918096159da453bed2c4839e6042)

          • (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/resourcegz/ResourceGzMojo.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10726 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10726/ ) HADOOP-10075 . addendum to fix compilation on Windows (rkanter: rev ebb88231f802918096159da453bed2c4839e6042) (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/resourcegz/ResourceGzMojo.java

            People

            • Assignee:
              Robert Kanter
              Reporter:
              Robert Rati
            • Votes:
              0 Vote for this issue
              Watchers:
              33 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development