Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0
    • Component/s: None
    • Labels:
      None

      Description

      Compiling for Fedora revels a missing declaration for javax.annotation.Nullable. This is the result of a missing explicit dependency on jsr305.

      1. HADOOP-10067_2.patch
        0.6 kB
        Robert Rati
      2. HADOOP-10067_3.patch
        1 kB
        Robert Rati
      3. HADOOP-10067.patch
        1 kB
        Robert Rati

        Issue Links

          Activity

          Hide
          Steve Loughran added a comment -

          Robert -this POM patches in commons-collections. Is it the right dependency?

          Show
          Steve Loughran added a comment - Robert -this POM patches in commons-collections. Is it the right dependency?
          Hide
          Robert Rati added a comment -

          Previous patch in correct and for a different issue. This new patch resolves the jsr305 dependency issue.

          Show
          Robert Rati added a comment - Previous patch in correct and for a different issue. This new patch resolves the jsr305 dependency issue.
          Hide
          Steve Loughran added a comment -

          looks better. The version declaration needs to go into hadoop-project/pom.xml for unified versions across the entire project. HADOOP-9594 is an example of this

          Show
          Steve Loughran added a comment - looks better. The version declaration needs to go into hadoop-project/pom.xml for unified versions across the entire project. HADOOP-9594 is an example of this
          Hide
          Robert Rati added a comment -

          Moved version declaration into hadoop-project.pom.xml

          Show
          Robert Rati added a comment - Moved version declaration into hadoop-project.pom.xml
          Hide
          Steve Loughran added a comment -

          +1 for the change, though I note that the patch does't apply directly to trunk or branch-2 -can you make sure your branches are up to date for patches.

          I also made the scope for the JAR <compile> to stop yet another JAR going downstream.

          Show
          Steve Loughran added a comment - +1 for the change, though I note that the patch does't apply directly to trunk or branch-2 -can you make sure your branches are up to date for patches. I also made the scope for the JAR <compile> to stop yet another JAR going downstream.
          Hide
          Steve Loughran added a comment -

          Fixed in 2.3 -thanks!

          Show
          Steve Loughran added a comment - Fixed in 2.3 -thanks!
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #4735 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4735/)
          HADOOP-10067 Missing POM dependency on jsr305 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541862)

          • /hadoop/common/trunk
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4735 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4735/ ) HADOOP-10067 Missing POM dependency on jsr305 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541862 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #391 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/391/)
          HADOOP-10067 Missing POM dependency on jsr305 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541862)

          • /hadoop/common/trunk
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #391 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/391/ ) HADOOP-10067 Missing POM dependency on jsr305 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541862 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1608 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1608/)
          HADOOP-10067 Missing POM dependency on jsr305 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541862)

          • /hadoop/common/trunk
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1608 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1608/ ) HADOOP-10067 Missing POM dependency on jsr305 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541862 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1582 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1582/)
          HADOOP-10067 Missing POM dependency on jsr305 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541862)

          • /hadoop/common/trunk
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1582 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1582/ ) HADOOP-10067 Missing POM dependency on jsr305 (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541862 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          Steve Loughran added a comment -

          (it looks like this was triggered by you forcing a build against guava >= 12; HADOOP-10101 will force that on all. If that's the case, we may find that this dependency will have to be propagated downstream or at least patched in as compile-time for every subproject

          Show
          Steve Loughran added a comment - (it looks like this was triggered by you forcing a build against guava >= 12; HADOOP-10101 will force that on all. If that's the case, we may find that this dependency will have to be propagated downstream or at least patched in as compile-time for every subproject
          Hide
          Robert Rati added a comment -

          Is there anything that needs to be done here or will HADOOP-10101 take care of any issues?

          Show
          Robert Rati added a comment - Is there anything that needs to be done here or will HADOOP-10101 take care of any issues?
          Hide
          Steve Loughran added a comment -

          -dont worry, this issue is closed

          Show
          Steve Loughran added a comment - -dont worry, this issue is closed

            People

            • Assignee:
              Robert Rati
              Reporter:
              Robert Rati
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development