[HADOOP-10062] race condition in MetricsSystemImpl#publishMetricsNow that causes incorrect results

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha1
• Fix Version/s: 2.7.0
• Component/s: metrics

Environment

CentOS 6.4, Oracle JDK 1.6.0_31, JDK1.7.0_45

• Target Version/s: 2.7.0
• Hadoop Flags: Reviewed
• Assignee: Sangjin Lee
• Reporter: Shinichi Yamashita
• Created: 21/Oct/13 18:39
• Updated: 25/Oct/19 20:26
• Resolved: 05/Feb/15 03:01

Description

TestMetricsSystemInpl#testMultiThreadedPublish failed with "Metrics not collected"

Running org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl
Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.688 sec <<< FAILURE! - in org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl
testMultiThreadedPublish(org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl)  Time elapsed: 0.056 sec  <<< FAILURE!
java.lang.AssertionError: Metric not collected!
Metric not collected!
Metric not collected!
Metric not collected!
Metric not collected!
Metric not collected!
Metric not collected!
Metric not collected!
Metric not collected!
Passed
        at org.junit.Assert.fail(Assert.java:93)
        at org.junit.Assert.assertTrue(Assert.java:43)
        at org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl.testMultiThreadedPublish(TestMetricsSystemImpl.java:232)


Results :

Failed tests:
  TestMetricsSystemImpl.testMultiThreadedPublish:232 Metric not collected!
Metric not collected!
Metric not collected!
Metric not collected!
Metric not collected!
Metric not collected!
Metric not collected!
Metric not collected!
Metric not collected!
Passed

Tests run: 6, Failures: 1, Errors: 0, Skipped: 0

Issue Links

• duplicates: HADOOP-9990 TestMetricsSystemImpl fails
• duplicates: HADOOP-10165 TestMetricsSystemImpl#testMultiThreadedPublish occasionally fails
• relates to: HADOOP-10058 TestMetricsSystemImpl#testInitFirstVerifyStopInvokedImmediately fails on trunk