Gump
  1. Gump
  2. GUMP-19

Support encoding of international characters in nag mail headers

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Gump2-2.3
    • Fix Version/s: Gump2-2.3
    • Component/s: Python-based Gump
    • Labels:
      None

      Description

      As wittnessed by the failing nag mails to log4j.

      Escaping of non-ASCII characters is well defined, sounds like a rather simple fix that might make a good candidate fix for somebody with a very low working knowledge of Python. Read, I'll look into it unless anybody beats me.

        Activity

        Hide
        Adam Jack added a comment -

        We have a utility function (in gump.utils) that should help here. When
        this problem was surfacing in other areas use of that function helped.

        Show
        Adam Jack added a comment - We have a utility function (in gump.utils) that should help here. When this problem was surfacing in other areas use of that function helped.
        Hide
        Stefan Bodewig added a comment -

        I was sure that something as common as MIME encoding must have been done
        by somebody - and it turns out the email module offers everything we
        need.

        I've committed a change that should turn Ceki's name into an accepted
        header part, but right now iso-8859-1 is hardcoded (bad) and it looks
        fairly incomplete to me.

        It seems the email module has more to offer, in particular we should be
        wrapping the body into a MIMEText object to get it properly escaped
        as well (for example if author names get visible in the output).

        Show
        Stefan Bodewig added a comment - I was sure that something as common as MIME encoding must have been done by somebody - and it turns out the email module offers everything we need. I've committed a change that should turn Ceki's name into an accepted header part, but right now iso-8859-1 is hardcoded (bad) and it looks fairly incomplete to me. It seems the email module has more to offer, in particular we should be wrapping the body into a MIMEText object to get it properly escaped as well (for example if author names get visible in the output).
        Hide
        Leo Simons added a comment -

        fixed long time ago as per Stefan's comment.

        Show
        Leo Simons added a comment - fixed long time ago as per Stefan's comment.

          People

          • Assignee:
            Unassigned
            Reporter:
            Stefan Bodewig
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development