[GUACAMOLE-930] "Display language" menu is empty in Guacamole preferences

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.1.0
• Component/s: guacamole
• Assignee: Mike Jumper
• Reporter: Mike Jumper
• Created: 20/Jan/20 03:05
• Updated: 03/Feb/20 02:13
• Resolved: 20/Jan/20 20:05

Description

As noted in guacamole-client pull request #453 for GUACAMOLE-903, the current staging/1.1.0 branch fails to render the "Display language" menu in the Guacamole preferences page, instead presenting an empty menu. This behavior appears to be a regression introduced by GUACAMOLE-630 and was not present in 1.0.0.

The failure is due to an [$rootScope:inprog] error on the $scope.$apply() call within languageFieldController which assigns the available languages:

// Retrieve defined languages
languageService.getLanguages().then(function languagesRetrieved(languages) {
    $scope.$apply(function updateLanguageOptions() {
        $scope.languages = languages;
    });
}, requestService.DIE);

According to git bisect, the specific commit introducing the issue is commit 93ba19a:

commit 93ba19ac26a3509878023886eee0140bcf3face9
Author: Michael Jumper <[e-mail]>
Date:   Sun Aug 18 22:00:16 2019 -0700

    GUACAMOLE-630: Create a new injector for field type instances only if needed.
    
    Creating a new injector re-initializes services and providers within
    its modules. If those services or providers rely on being singletons
    (as colorPickerService does), this produces unexpected behavior.

:040000 040000 d915e8e91b46dfae89c126515aca83a215e0becf 884ef37f363f2e180f94b4fd48f13782cc77657d M	guacamole

Issue Links

• is caused by: GUACAMOLE-630 Allow terminal color scheme to be changed while connection is running
• is duplicated by: GUACAMOLE-915 International seletor is unavailable
• relates to: GUACAMOLE-903 Improved Chinese internationalization support