Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-930

"Display language" menu is empty in Guacamole preferences

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.1.0
    • 1.1.0
    • guacamole
    • None

    Description

      As noted in guacamole-client pull request #453 for GUACAMOLE-903, the current staging/1.1.0 branch fails to render the "Display language" menu in the Guacamole preferences page, instead presenting an empty menu. This behavior appears to be a regression introduced by GUACAMOLE-630 and was not present in 1.0.0.

      The failure is due to an [$rootScope:inprog] error on the $scope.$apply() call within languageFieldController which assigns the available languages:

      // Retrieve defined languages
      languageService.getLanguages().then(function languagesRetrieved(languages) {
          $scope.$apply(function updateLanguageOptions() {
              $scope.languages = languages;
          });
      }, requestService.DIE);
      

      According to git bisect, the specific commit introducing the issue is commit 93ba19a:

      commit 93ba19ac26a3509878023886eee0140bcf3face9
      Author: Michael Jumper <mjumper@apache.org>
      Date:   Sun Aug 18 22:00:16 2019 -0700
      
          GUACAMOLE-630: Create a new injector for field type instances only if needed.
          
          Creating a new injector re-initializes services and providers within
          its modules. If those services or providers rely on being singletons
          (as colorPickerService does), this produces unexpected behavior.
      
      :040000 040000 d915e8e91b46dfae89c126515aca83a215e0becf 884ef37f363f2e180f94b4fd48f13782cc77657d M	guacamole
      

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mjumper Mike Jumper
            mjumper Mike Jumper
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment