[GUACAMOLE-870] Connection history query fails against SQL Server

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: guacamole-auth-jdbc-sqlserver
• Assignee: Nick Couchman
• Reporter: Mike Jumper
• Created: 04/Sep/19 02:58
• Updated: 07/Sep/19 20:48
• Resolved: 07/Sep/19 20:48

Description

While the connection history initially displays correctly, any queries against the history fail with the following error:

com.microsoft.sqlserver.jdbc.SQLServerException: Incorrect syntax near 'username'.

This is due to the use of the POSITION() function within the query and is presumably a holdover from the initial creation of SQL Server support for Guacamole. This function is present in both the MySQL and PostgreSQL flavors of the Guacamole history query, which predate SQL Server support and would have been used as its basis.

Unlike MySQL and PostgreSQL, SQL Server does not support the POSITION() function. The CHARINDEX() function should be used instead.