[GUACAMOLE-637] Compile error: 'strncpy' output may be truncated copying 7 bytes from a string of length 7

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.1.0
• Component/s: guacamole-server
• Environment: Fedora 28
• Assignee: Mike Jumper
• Reporter: T Gale
• Created: 01/Oct/18 08:20
• Updated: 29/Apr/19 01:59
• Resolved: 10/Apr/19 16:47

Description

Build error on Fedora 28:

CC guac_svc/guacsvc_client_la-svc_service.lo
guac_svc/svc_service.c: In function 'VirtualChannelEntry':
guac_svc/svc_service.c:56:5: error: 'strncpy' output may be truncated copying 7 bytes from a string of length 7 [-Werror=stringop-truncation]
 strncpy(svc_plugin->plugin.channel_def.name, svc->name,
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 GUAC_RDP_SVC_MAX_LENGTH);
 ~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Issue Links

• is duplicated by: GUACAMOLE-720 Build failure with GCC 9