[GUACAMOLE-556] Incorrect warning regarding decreasing timestamps in session recordings

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.0.0
• Component/s: guacenc
• Assignee: Unassigned
• Reporter: Mike Jumper
• Created: 25/Apr/18 17:34
• Updated: 25/Apr/18 17:36

Description

In addition to timestamps sent within "sync" instructions at the end of a frame, session recordings may also contain timestamps associated with mouse events ("mouse" instructions) and, if enabled, keyboard events ("key" instructions). As these instructions are written by different threads and come from different sources, they are not guaranteed to be in sync with each other.

guacenc currently assumes that these timestamps are in sync, and logs a warning if this is not the case:

guacenc: WARNING: Decreasing sync timestamp

This is technically incorrect. The warning should only be logged if "sync" timestamps are decreasing relative to other "sync" instructions, and the "mouse" timestamp should interpreted as advisory, defaulting to the last "sync" timestamp if it appears to come from the past.

Issue Links

• is caused by: GUACAMOLE-313 Allow input events within session recording
• relates to: GUACAMOLE-551 guacenc warning "Layer index out of bounds: -1"