Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-489

Secondary socket of "tee" socket is not threadsafe

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0
    • Component/s: libguac
    • Labels:
      None

      Description

      While working on GUACAMOLE-313, it was discovered that the "tee" implementation of guac_socket (created through a call to guac_socket_tee()) only actually locks/unlocks the primary socket when sending instructions. This means that instructions which are manually sent along the secondary socket may overlap with instructions written through the tee socket, resulting in protocol errors.

      Both primary and secondary sockets should be threadsafe relative to instruction writes on the tee socket.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mjumper Mike Jumper
                Reporter:
                mjumper Mike Jumper
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: