[GUACAMOLE-411] guacd_send_fd call's sendmsg with uninitialized buffer

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.13-incubating
• Fix Version/s: 0.9.14
• Component/s: guacd
• Assignee: Unassigned
• Reporter: Jukka-Pekka Virtanen
• Created: 10/Oct/17 09:39
• Updated: 15/Oct/17 00:54
• Resolved: 15/Oct/17 00:54

Description

When launching an RDP session through guacd, valgrind complains of using uninitialized values in guacd_send_fd.

==8081== Thread 2:
==8081== Syscall param sendmsg(msg.msg_control) points to uninitialised byte(s)
==8081==    at 0x505EA6D: ??? (syscall-template.S:84)
==8081==    by 0x403F5C: guacd_send_fd (move-fd.c:61)
==8081==    by 0x40390A: guacd_add_user (connection.c:196)
==8081==    by 0x40390A: guacd_route_connection (connection.c:311)
==8081==    by 0x40390A: guacd_connection_thread (connection.c:393)
==8081==    by 0x50556B9: start_thread (pthread_create.c:333)
==8081==    by 0x5A1F3DC: clone (clone.S:109)
==8081==  Address 0xa558d54 is on thread 2's stack
==8081==  in frame #1, created by guacd_send_fd (move-fd.c:34)
==8081==  Uninitialised value was created by a stack allocation
==8081==    at 0x403ED0: guacd_send_fd (move-fd.c:34)
==8081==