[GUACAMOLE-384] Terminal writes during disconnect may segfault

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.12-incubating
• Fix Version/s: 1.0.0
• Component/s: Terminal
• Environment: GNU/Linux x86_64
• Assignee: Unassigned
• Reporter: Phillip Arcuri
• Created: 21/Sep/17 00:31
• Updated: 23/Jan/18 22:46
• Resolved: 23/Jan/18 22:46

Description

In a stress test we kick off an SSH session every second. The session does a minimal amount of work and exits after a few seconds. A ps -ef shows we have 2 to 6 instances running at one time. About 1 in 10 of the instances cores with corrupted buffer data at line buffer.c:108.:
(gdb) p *buffer
$2 = {default_character = {value = -1269703408, attributes =

{bold = 170, reverse = 42, cursor = false, underscore = false, foreground = 0, background = 0}

, width = -1269422328}, rows = 0x2aaab456fa30, top = 686, length = 0, available = 686}

As an aside I also see roughly 1 in 100 instances become a zombie process hung in pthread_join. Doubt that is related, but thought I'd mention it.

This is a blocker for our deployment of a guacamole-enabled feature-set.