[GUACAMOLE-383] Failures to open guacd.conf, read RDP clipboard data, or load terminal font may leak memory

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.9.14
• Assignee: Unassigned
• Reporter: Ilya Shipitsin
• Created: 20/Sep/17 17:44
• Updated: 17/Dec/17 07:18
• Resolved: 23/Sep/17 20:32

Description

The static analysis tool "cppcheck" has reported the following:

[src/guacd/conf-file.c:206]: (error) Memory leak: conf
[src/protocols/rdp/rdp_cliprdr.c:205]: (error) Memory leak: output
[src/terminal/display.c:283]: (error) Memory leak: display
[src/terminal/display.c:290]: (error) Memory leak: display

These correspond to the following issues:

1. In the event that guacd.conf fails to be opened (for any reason other than it simply doesn't exist), the memory for the config structure meant to house the interpreted contents of guacd.conf will not be freed.
2. If the RDP server violates protocol and requests a clipboard format which the RDP client has not declared as supported, the memory for the buffer meant to hold the clipboard contents sent to the RDP server is leaked.
3. If the details of the requested font for an SSH or telnet connection cannot be loaded (Pango reports an error while retrieving font metrics), the memory for the abstract terminal display is leaked.