Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-257

Segfault in on VNC/SSH file upload if SFTP is disabled

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.11-incubating
    • Fix Version/s: 0.9.13-incubating
    • Component/s: SSH, VNC
    • Labels:
      None

      Description

      I have a VNC system that I'm connecting to. I'm not expecting file transfer to work because I don't have SFTP set up. Previously on 0.9.9 on drag and drop I'd see an error "File transfer is either not supported or not enabled." This is what I'm expecting. Now on 0.9.11, I get disconnected from the VM and have to click reconnect. Looking at the logs, I see a segfault:

      kernel: guacd[21554]: segfault at 18 ip 00007f47f4f7b2bf sp 00007f47efffe428 error 4 in libguac-client-vnc.so.0.0.0[7f47f4f6e000+12000]
      abrt-hook-ccpp: Process 21549 (guacd) of user 993 killed by SIGSEGV - dumping core
      

      Log is attached.

      1. guac-log.txt
        3 kB
        Daryl Borth

        Activity

        Hide
        mike.jumper Michael Jumper added a comment -

        Should be fixed on master.

        Show
        mike.jumper Michael Jumper added a comment - Should be fixed on master.
        Hide
        mike.jumper Michael Jumper added a comment -

        Affects SSH connections as well. This is due to the file upload handler being erroneously set in all cases, even if SFTP is not enabled.

        RDP is unaffected, as the file upload handler is expected to always be set (simplifies the logic around the multiple possible file transfer methods) and handles its own success/unsupported responses.

        Show
        mike.jumper Michael Jumper added a comment - Affects SSH connections as well. This is due to the file upload handler being erroneously set in all cases, even if SFTP is not enabled. RDP is unaffected, as the file upload handler is expected to always be set (simplifies the logic around the multiple possible file transfer methods) and handles its own success/unsupported responses.

          People

          • Assignee:
            mike.jumper Michael Jumper
            Reporter:
            dborth@hatsize.com Daryl Borth
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development