[GUACAMOLE-206] Alt key combinations broken in SSH and telnet

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 0.9.13-incubating
• Component/s: SSH, Telnet, Terminal
• Assignee: Mike Jumper
• Reporter: Mike Jumper
• Created: 15/Feb/17 05:25
• Updated: 16/Feb/17 06:29
• Resolved: 16/Feb/17 06:29

Description

Apparently, ever since Guacamole had SSH support, handling of the Alt key has been broken. Roughly four years ago, support for the Alt key was added through the following block of code:

/* If alt being held, also send escape character */
if (term->mod_alt)
    return guac_terminal_send_string(term, "\x1B");

This is a clear logic error. Because of that return, this block doesn't "also" send anything; it bails out of the keyboard handling prior to actually sending the key pressed.

... Sorry emacs folks.