Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-184

guac_common_surface_dup() may send invalid PNG

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      guac_common_surface_dup() fails to check whether the dimensions of the surface are 0x0. Though this is a perfectly valid state for a surface, it is not possible to send a 0x0 image (nor does it really make sense to try); the PNG encoding functions fail, producing an invalid Guacamole instruction and breaking the protocol stream.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mjumper Mike Jumper
            mjumper Mike Jumper
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment