Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.10-incubating
    • Fix Version/s: 0.9.12-incubating
    • Component/s: guacenc
    • Labels:
      None
    • Environment:
      FreeBSD, Head, 11.0, 10.3

      Description

      FFmpeg has deprecated avcodec_encode_video2() in favor of avcodec_send_frame() / avcodec_receive_packet(). See:

      https://github.com/FFmpeg/FFmpeg/blob/n3.2.2/libavcodec/avcodec.h#L5320

      Attached is a log file of the build if you are interested in other env, I can add those too.

      1. guacamole-server-0.9.10.log
        258 kB
        Richard Gallamore
      2. guacamole-server-tag_9a51675.log
        337 kB
        Richard Gallamore

        Issue Links

          Activity

          Hide
          mike.jumper Michael Jumper added a comment -

          Hi Richard Gallamore - I think I have this fixed on the "ffmpeg-compat" branch on my fork of incubator-guacamole-server:

          https://github.com/mike-jumper/incubator-guacamole-server/tree/ffmpeg-compat

          Mind giving that a try?

          Show
          mike.jumper Michael Jumper added a comment - Hi Richard Gallamore - I think I have this fixed on the "ffmpeg-compat" branch on my fork of incubator-guacamole-server: https://github.com/mike-jumper/incubator-guacamole-server/tree/ffmpeg-compat Mind giving that a try?
          Hide
          ultima1252 Richard Gallamore added a comment - - edited

          Compiler is happy, thanks Michael.

          Show
          ultima1252 Richard Gallamore added a comment - - edited Compiler is happy, thanks Michael.
          Hide
          mike.jumper Michael Jumper added a comment -

          We're using the wrong version check for the newer FFmpeg API. From GUACAMOLE-217:

          From doc/APIchanges:

          2016-04-21 - 7fc329e - lavc 57.37.100 - avcodec.h
            Add a new audio/video encoding and decoding API with decoupled input
            and output -- avcodec_send_packet(), avcodec_receive_frame(),
            avcodec_send_frame() and avcodec_receive_packet()
          

          We should be using the older API for anything older than 57.37.100, which does include the version currently in Ubuntu 16.10.

          Show
          mike.jumper Michael Jumper added a comment - We're using the wrong version check for the newer FFmpeg API. From GUACAMOLE-217 : From doc/APIchanges : 2016-04-21 - 7fc329e - lavc 57.37.100 - avcodec.h Add a new audio/video encoding and decoding API with decoupled input and output -- avcodec_send_packet(), avcodec_receive_frame(), avcodec_send_frame() and avcodec_receive_packet() We should be using the older API for anything older than 57.37.100, which does include the version currently in Ubuntu 16.10.

            People

            • Assignee:
              mike.jumper Michael Jumper
              Reporter:
              ultima1252 Richard Gallamore
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development