[GUACAMOLE-165] Optimal height/width calculations incorrect if client template is modified

• Type: Bug
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Affects Version/s: 0.9.10-incubating
• Component/s: guacamole
• Environment: browser
• Assignee: Unassigned
• Reporter: Marko Nikolić
• Created: 22/Jan/17 20:37
• Updated: 28/Jan/17 07:09

Description

If the client template is modified such that the Guacamole display does not occupy the whole browser window, the width/height values submitted as "optimal" via GUAC_WIDTH and GUAC_HEIGHT will not match the actual space available for the client display:

ManagedClient.js

        // Calculate optimal width/height for display
        var pixel_density = $window.devicePixelRatio || 1;
        var optimal_dpi = pixel_density * 96;
        var optimal_width = $window.innerWidth * pixel_density;
        var optimal_height = $window.innerHeight * pixel_density;

        // Build base connect string
        var connectString =
              "token="             + encodeURIComponent(authenticationService.getCurrentToken())
            + "&GUAC_DATA_SOURCE=" + encodeURIComponent(identifier.dataSource)
            + "&GUAC_ID="          + encodeURIComponent(identifier.id)
            + "&GUAC_TYPE="        + encodeURIComponent(identifier.type)
            + "&GUAC_WIDTH="       + Math.floor(optimal_width)
            + "&GUAC_HEIGHT="      + Math.floor(optimal_height)
            + "&GUAC_DPI="         + Math.floor(optimal_dpi)
            + (connectionParameters ? '&' + connectionParameters : '');

Issue Links

• relates to: GUACAMOLE-164 Downstream modifications to client template can cause fitVisibleArea() to fail