[GUACAMOLE-1570] start.sh SAML Extension load logic incomplete

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Component/s: guacamole-docker
• Assignee: Unassigned
• Reporter: Stu B
• Created: 29/Mar/22 12:10
• Updated: 09/Apr/22 17:59
• Resolved: 09/Apr/22 17:59

Description

The logic contained within the current start.sh script is incomplete when deciding to load the guacamole-auth-saml extension.

As per the documentation the SAML Extension can be configured by setting either `$SAML_IDP_METADATA_URL` or `$SAML_ENTITY_ID` and `$SAML_CALLBACK_URL`

At line 1049 in script start.sh the SAML Extension is only loaded if `$SAML_IDP_METADATA_URL` is present.

if [ -n "$SAML_IDP_METADATA_URL" ]; then
    associate_saml
    INSTALLED_AUTH="$INSTALLED_AUTH saml"
fi

This should include logic similar to line 754 in the same start.sh

if [ -z "$SAML_IDP_METADATA_URL" ] && [ -z "$SAML_ENTITY_ID" -o -z "$SAML_CALLBACK_URL" ]

 

 

 

Issue Links

• duplicates: GUACAMOLE-1322 SAML environment variables
• relates to: GUACAMOLE-1322 SAML environment variables