[GUACAMOLE-132] Build unstable since RAT plugin added

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.9.10-incubating
• Fix Version/s: 0.9.10-incubating
• Component/s: guacamole-client
• Assignee: Mike Jumper
• Reporter: Mike Jumper
• Created: 29/Nov/16 01:34
• Updated: 04/Dec/16 01:49
• Resolved: 04/Dec/16 01:49

Description

From gtrasuk regarding 0.9.10-incubating:

When I run ‘mvn clean install’ or ‘mvn clean package’, I get a rat failure:

1 Unknown Licenses

*****************************************************

Files with unapproved licenses:

  /Users/trasukg/devel/guacamole/guacamole-client-0.9.10-incubating/guacamole/src/main/webapp/generated/templates-main/templates.js

I agree that appears to be a false positive (as it’s a generated file) - maybe we’re missing an exclusion?

(See the original email in the VOTE thread)

As is, the RAT portion of the build will fail if rerun against the extracted .tar.gz, but not when run against git. This is because the RAT plugin ignores files which match ".gitignore" by default, and those files are not present in the source .tar.gz.

Since RAT pays attention to ".gitignore", my $0.02 is that these files should now be considered part of the build, and should be included in the source archive.