[GUACAMOLE-117] File descriptor leak if SSL/TLS negotiation fails

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.11-incubating
• Component/s: guacd
• Assignee: Mike Jumper
• Reporter: Mike Jumper
• Created: 11/Nov/16 20:13
• Updated: 12/Nov/16 00:51
• Resolved: 12/Nov/16 00:51

Description

From downstream GUAC-1572:

In guacd's SSL/TLS socket implementation, the file descriptor is not closed if SSL_accept() fails, resulting in a leak. See:

https://github.com/apache/incubator-guacamole-server/blob/16a8b9b94bfe35e5eba0079965856e46533c79c0/src/guacd/connection.c#L377-L382

guac_socket_open_secure() should not free the file descriptor itself (having a failed allocation do anything but return an error code would violate the Principle of Least Surprise), but callers of guac_socket_open_secure() should handle error conditions properly and clean up after themselves.