[GROOVY-9927] Stub not using fully qualified class for inner java class when importing outer class

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.7
• Fix Version/s: 3.0.10
• Component/s: Stub generator / Joint compiler
• Assignee: Unassigned
• Reporter: Keegan Witt
• Created: 03/Feb/21 04:04
• Updated: 08/Mar/22 12:16
• Resolved: 12/Oct/21 18:49

Description

Here's a failing test, demonstrating the problem

/*
 *  Licensed to the Apache Software Foundation (ASF) under one
 *  or more contributor license agreements.  See the NOTICE file
 *  distributed with this work for additional information
 *  regarding copyright ownership.  The ASF licenses this file
 *  to you under the Apache License, Version 2.0 (the
 *  "License"); you may not use this file except in compliance
 *  with the License.  You may obtain a copy of the License at
 *
 *    http://www.apache.org/licenses/LICENSE-2.0
 *
 *  Unless required by applicable law or agreed to in writing,
 *  software distributed under the License is distributed on an
 *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 *  KIND, either express or implied.  See the License for the
 *  specific language governing permissions and limitations
 *  under the License.
 */
package org.codehaus.groovy.tools.stubgenerator

class InnerJavaClassOuterImportInGroovy extends StringSourcesStubTestCase {

    Map<String, String> provideSources() {
        [
                'model/Logger.java': '''
                    package model;

                    public class Logger {
                        public enum Level {
                            DEBUG, INFO, WARN, ERROR
                        }
                    }
                ''',
                'service/LoggerLevelDescriber.groovy': '''
                    package service

                    import model.Logger

                    class LoggerLevelDescriber {
                        String describeLevel(Logger.Level loggerLevel) { return loggerLevel.name }
                    }
                '''
        ]
    }

    void verifyStubs() {
        def stubSource = stubJavaSourceFor('service.LoggerLevelDescriber')
        assert stubSource.contains(' describeLevel(model.Logger.Level ')

        // TODO: should this be tested too?
//        def classLoader = new URLClassLoader([targetDir.toURI().toURL()] as URL[], loader)
//        classLoader.loadClass('model.Logger')
//        classLoader.loadClass('model.Logger.Level')
//        classLoader.loadClass('service.LoggerLevelDescriber')
    }
}

The stub has

public  java.lang.String describeLevel(Logger.Level loggerLevel) { return (java.lang.String)null;}

With no import for Logger.

If you instead do

import model.Logger.LogLevel

instead of

import model.Logger

it prints the qualified name in the stub.

It also works if you put the qualified name in Groovy, that also works, like

String describeLevel(model.Logger.Level loggerLevel)