[GROOVY-9847] STC: regression in private inner class type inference

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.20, 2.5.13
• Fix Version/s: 2.4.22, 2.5.15
• Assignee: Eric Milles
• Reporter: Eric Milles
• Created: 04/Dec/20 17:44
• Updated: 07/Dec/20 22:09
• Resolved: 07/Dec/20 03:58

Description

Backport of GROOVY-7549 caused a regression in temp type inference of local variable assignment. Consider the following:

            class Test {
                @groovy.transform.ToString(excludes='children')
                private static class TreeAttr {
                    String name
                    Integer val = 0
                    List<TreeAttr> children = []
                }

                void test(Integer count) {
                    TreeAttr root = new TreeAttr(name:'foo')
                    List<TreeAttr> collector = root.children

                    for (name in ['bar','baz']) { // tokens in a path
                        def item = collector.find { it.name == name }
                        if (!item) {
                            item = new TreeAttr(name: name)
// inferred type of "item" is Object after this point
                            collector.add(item)
                        }
                        collector = item.children
                        if (count) item.val += count
                    }
                }
            }

Note: This test case works fine for 3_0_X and master.