[GROOVY-9662] Groovy 3.0.5: Closure delegate is not working properly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.2, 3.0.3, 3.0.4, 3.0.5, 2.5.14
• Fix Version/s: 2.5.15, 3.0.8, 4.0.0-alpha-3
• Assignee: Eric Milles
• Reporter: Puneet Behl
• Created: 27/Jul/20 13:36
• Updated: 15/Aug/22 15:49
• Resolved: 24/Dec/20 17:48

Description

In Grails Views, we are using closures to generate JSON using StreamingJsonBuilder. The HAL implementation for an entity now generates an incorrect JSON after updating to Groovy 3.

Here is the problem code snipped from grails.plugin.json.view.api.internal.DefaultHalViewHelper#links: 

jsonDelegate.call(LINKS_ATTRIBUTE) {
    call(SELF_ATTRIBUTE) {
        call HREF_ATTRIBUTE, viewHelper.link(resource: object, method: HttpMethod.GET, absolute: true)
        call HREFLANG_ATTRIBUTE, locale.toString()

        call TYPE_ATTRIBUTE, contentType
    }

    Set<Link> links = getLinks(object)
    for (link in links) {
        call(link.rel) {
            call HREF_ATTRIBUTE, link.href
            call HREFLANG_ATTRIBUTE, link.hreflang?.toString() ?: locale.toString()
            def linkType = link.contentType
            if (linkType) {
                call TYPE_ATTRIBUTE, linkType
            }
        }
    }
}

 
Although the `resolveStatergy` for the closures is `DELEGATE_FIRST` but I believe that is not working correctly because it works if I change the above to:

delegate.call (...

 

To reproduce the issue please checkout https://github.com/grails/grails-views/commits/bugs/groovy-9962

 

Issue Links

• is related to: GROOVY-9279 StreamingJsonBuilder adding extra comma