[GROOVY-9607] Class generation regression in 3.0.5-ss: This method should not have been called

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.5
• Fix Version/s: 4.0.0-alpha-1, 3.0.5, 2.5.16
• Assignee: Eric Milles
• Reporter: Eric Helgeson
• Created: 27/Jun/20 16:03
• Updated: 23/Feb/22 20:40
• Resolved: 04/Jul/20 16:28

Description

Compiling grails-core master branch on 3.0.5-SNAPSHOT I noticed a regression since 3.0.4 -

 Execution failed for task ':grails-web-databinding:compileGroovy'. > BUG! exception in phase 'class generation' in source unit '/Users/erichelgeson/source/grails-core/grails-web-databinding/src/main/groovy/grails/web/databinding/GrailsWebDataBinder.groovy' At line 541 column 33 On receiver: obj with message: getAt and arguments: propName This method should not have been called. Please try to create a simple example reproducing this error and file a bug report at https://issues.apache.org/jira/browse/GROOVY 

Offending line in grails-core here: https://github.com/grails/grails-core/blob/master/grails-web-databinding/src/main/groovy/grails/web/databinding/GrailsWebDataBinder.groovy#L541

I am unsure how to recreate a concise reproducible bug from this so I ran a git bisect and found this to be the commit that introduced the error: https://issues.apache.org/jira/browse/GROOVY-9344 / https://github.com/apache/groovy/commit/fafa3c60f3beaec71298e1e95bc27f83ccea5e1e - I also validated it by reverting the commit and re-testing.