[GROOVY-9600] Picocli-related VersionProvider helper classes should be public to avoid access warnings

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1, 3.0.5, 2.5.13
• Component/s: command line processing
• Assignee: Paul King
• Reporter: Paul King
• Created: 19/Jun/20 08:23
• Updated: 23/Jul/20 14:16
• Resolved: 19/Jun/20 12:17

Description

Otherwise results in errors on JDK9+ such as below:

java.lang.IllegalAccessException: class groovyjarjarpicocli.CommandLine$DefaultFactory cannot access a member of class groovy.ui.GroovyMain$VersionProvider with modifiers ""
        at java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:376)
        at java.base/java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:647)
        at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:490)
        at java.base/java.lang.reflect.ReflectAccess.newInstance(ReflectAccess.java:124)
        at java.base/jdk.internal.reflect.ReflectionFactory.newInstance(ReflectionFactory.java:346)
        at java.base/java.lang.Class.newInstance(Class.java:604)
        at groovyjarjarpicocli.CommandLine$DefaultFactory.create(CommandLine.java:5090)
        at groovyjarjarpicocli.CommandLine$DefaultFactory.create(CommandLine.java:5116)
        at groovyjarjarpicocli.CommandLine$DefaultFactory.createVersionProvider(CommandLine.java:5104)
        at groovyjarjarpicocli.CommandLine$Model$CommandSpec.updateVersionProvider(CommandLine.java:6698)
        at groovyjarjarpicocli.CommandLine$Model$CommandSpec.updateCommandAttributes(CommandLine.java:6673)
        at groovyjarjarpicocli.CommandLine$Model$CommandReflection.extractCommandSpec(CommandLine.java:10597)
        at groovyjarjarpicocli.CommandLine$Model$CommandSpec.forAnnotatedObject(CommandLine.java:5765)
        at groovyjarjarpicocli.CommandLine.<init>(CommandLine.java:223)
        at groovyjarjarpicocli.CommandLine.<init>(CommandLine.java:196)
        at groovy.ui.GroovyMain.processArgs(GroovyMain.java:128)