[GROOVY-9575] ASTNode.hashCode violates Object.hashCode contract: does not return consistent value

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.4
• Fix Version/s: 4.0.0-alpha-1, 3.0.5, 2.5.16
• Assignee: Daniel Sun
• Reporter: Anders Wallgren
• Created: 27/May/20 01:16
• Updated: 31/Jan/22 18:58
• Resolved: 28/May/20 01:07

Description

While upgrading groovy from 2.4.18 to 3.0.4 in a project we ran into a problem: ASTNode.hashCode uses mutable properties of the object to calculate the hash.

Those object properties are not, however, used when equals() is invoked on an ASTNode instance (as of 3.0.4 ASTNode does not implement equals).

This means ASTNode violates an important part of the Object.hashCode contract and you cannot safely put ASTNode instances into collections where the hashcode is relied upon to be consistent.

Quoting the Object.hashCode javadoc:

• Whenever it is invoked on the same object more than once during an execution of a Java application, the hashCode method must consistently return the same integer, provided no information used in equals comparisons on the object is modified. This integer need not remain consistent from one execution of an application to another execution of the same application.