[GROOVY-9484] Closure on the next line should not be treated as argument - ASF JIRA

XML

Word

Printable

JSON

Here is the issue reported by a Spock user:

in groovy 2.5

 modification                                | expected
 { Instant i, ZoneId z -> i.plusSeconds(1) } | defaultInstant.plusSeconds(1)

these were treated as separate expressions
in groovy 3.0 the closure gets merged as argument to the expected above.

 modification | this.expected({ Instant i, ZoneId z ->
            i.plusSeconds(1)
        }) | defaultInstant.plusSeconds(1)

I propose to unify the grammar of closure arguments:

// 2 expressions: variable and closure
meth
{ p ->
}

// 2 expressions: binary expression and closure
a | meth
{ p ->
}

In the old grammar, the following code is parsed as method call with a closure argument.

meth
{ p ->
}

Luckily, groovy-parser project containing source code of some famous groovy projects, none of which are broken because of the proposed change.

is duplicated by

GROOVY-9494 Closure in next line continues previous expression in 3.0 but didn't in 2.5

links to

GitHub Pull Request #1211

Estimated:

Not Specified

Remaining:

Logged:

20m