[GROOVY-9336] Shift operator used in field initial value expression causing incorrect type conversion

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-rc-3, 2.5.16
• External issue URL: https://github.com/groovy/groovy-eclipse/issues/1001
• Assignee: Eric Milles
• Reporter: Eric Milles
• Created: 12/Dec/19 23:15
• Updated: 31/Jan/22 18:57
• Resolved: 11/Jan/20 20:07

Description

Consider the following:

class C {
  public static final double D = 2 << 16 - 1
}

User has omitted parentheses around "2 << 16" and so this is evaluated as 2 << (16 - 1). During inline constant conversion (ExpressionUtils.transformInlineConstants), the right side of the shift operator is converted to a double and this results in:

java.lang.UnsupportedOperationException: Shift distance must be an integral type, but 15.0 (java.lang.Double) was supplied
	at org.codehaus.groovy.runtime.typehandling.NumberMath.leftShift(NumberMath.java:99)
	at org.apache.groovy.ast.tools.ExpressionUtils.transformBinaryConstantExpression(ExpressionUtils.java:113)

I think that the right side of any shift operation should be converted to int (not double in this case).

Issue Links

• links to: GitHub Pull Request #1138